application

Clone Tools

Stats

Commits this week: 0
Total Committers: 14
Last Commit: 16 Dec
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 15 Jan 2021
10:33 am

Peter Lucia <plucia@diality.com>

DEN-6359: Addressed code review comments

Options
    • -0
    • +1
    /.gitignore
    • -0
    • +10
    /denali.pro
    • -5
    • +5
    /denali.pro.user
    • -1
    • +1
    /scripts/run.sh
    • -1
    • +5
    /sources/storage/StorageGlobals.cpp
    • -10
    • +10
    /sources/view/VBluetooth.cpp
    • -1
    • +1
    /sources/view/VBluetooth.h
9:17 am

plucia  (deleted user)

Done

Done

Thursday 14 Jan 2021
8:22 pm

Behrouz NematiPour

RESOLVED

RESOLVED

4:44 pm

Behrouz NematiPour

So we may need to be careful when we are adding the WiFi driver in here later. RESOLVED.

So we may need to be careful when we are adding the WiFi driver in here later.
RESOLVED.

4:43 pm

Peter Lucia <plucia@diality.com>

DEN-4867: Preventing create treatment class from thinking a new treatment profile was saved when the bledevices.conf file is updated.

Options
    • -4
    • +14
    /sources/view/VTreatmentCreate.cpp
    • -0
    • +2
    /sources/view/VTreatmentCreate.h
4:43 pm

Behrouz NematiPour

Perfect, RESOLVED.

Perfect,
RESOLVED.

4:42 pm

Behrouz NematiPour

We need to have a folder next to the application for all the settings since it is not related to the treatment it is only settings configuration files. Since the SD card might be damaged and we sti...

We need to have a folder next to the application for all the settings since it is not related to the treatment it is only settings configuration files.
Since the SD card might be damaged and we still need to store settings.
Please change it to refer to the application location and name the folder as configuration or settings.

4:39 pm

Peter Lucia <plucia@diality.com>

DEN-4867: Addressed code review comments

Options
    • -20
    • +60
    /sources/bluetooth/BLEScanner.cpp
    • -2
    • +9
    /sources/bluetooth/BLEScanner.h
4:39 pm

Behrouz NematiPour

Oh I see. RESOLVED

Oh I see.
RESOLVED

3:32 pm

Behrouz NematiPour

deleted.

deleted.

3:31 pm

Behrouz NematiPour

Good catch, Dleted.

Good catch,
Dleted.

3:29 pm

Behrouz NematiPour

You actually had it with the value of 0.1 ms and I increased it to 0.5 because after running the test multiple times I figured it is not enough time. I will review the waits in the pTx-UF COCO.

You actually had it with the value of 0.1 ms and I increased it to 0.5 because after running the test multiple times I figured it is not enough time.
I will review the waits in the pTx-UF COCO.

3:15 pm

Behrouz NematiPour

I kept it for debugging. The usual behavior of the SquishQt is to continue even if an error happens to stop it if an error happens this value needs to be set. I'm still trying to figure out how exa...

I kept it for debugging.
The usual behavior of the SquishQt is to continue even if an error happens to stop it if an error happens this value needs to be set.
I'm still trying to figure out how exactly this works and later may move it in a better file.

Wednesday 13 Jan 2021
6:45 pm

Behrouz NematiPour

I checked out into the code and seems like the VBluetoothDeviceInfo class is not a view class although it has properties. So, why it has V in the naming, and why it has property? Views are only int...

I checked out into the code and seems like the VBluetoothDeviceInfo class is not a view class although it has properties.
So, why it has V in the naming, and why it has property?
Views are only intended to be used in QML to interact with the C++ backend.

6:41 pm

Behrouz NematiPour

the 'on' prefix shall be used for the private slots only. seems like this is not the case here. A better naming would be notifyStatusUpdate().

the 'on' prefix shall be used for the private slots only.
seems like this is not the case here.
A better naming would be notifyStatusUpdate().

6:36 pm

Behrouz NematiPour

Please use macros for the connections, whenever possible.

Please use macros for the connections, whenever possible.

6:36 pm

Behrouz NematiPour

Please use macros for the connections, whenever possible.

Please use macros for the connections, whenever possible.

6:31 pm

Behrouz NematiPour

refer to the above comment about the MainTimer.

refer to the above comment about the MainTimer.

6:31 pm

Behrouz NematiPour

I remember I mentioned somewhere in the code to use the QObject internal timer and also mentioned MainTimer as an example. But I didn't mean to use the MainTimer. Please look at the MainTimer as an...

I remember I mentioned somewhere in the code to use the QObject internal timer and also mentioned MainTimer as an example.
But I didn't mean to use the MainTimer.
Please look at the MainTimer as an example of how to use the QObject internal timer and use it instead of the MainTimer itself.

6:26 pm

Behrouz NematiPour

RESOLVED

RESOLVED

6:26 pm

Behrouz NematiPour

RESOLVED

RESOLVED

6:26 pm

Behrouz NematiPour

RESOLVED

RESOLVED

6:26 pm

Behrouz NematiPour

RESOLVED

RESOLVED

6:25 pm

Behrouz NematiPour

RESOLVED

RESOLVED

6:25 pm

Behrouz NematiPour

RESOLVED

RESOLVED

6:25 pm

Behrouz NematiPour

RESOLVED

RESOLVED

6:07 pm

Behrouz NematiPour

How come a function has been added in the cpp but the header is not automatically added to the code review?

How come a function has been added in the cpp but the header is not automatically added to the code review?

6:00 pm

plucia  (deleted user)

I've moved the comment back so it's inside the if statement

I've moved the comment back so it's inside the if statement

5:55 pm

Peter Lucia <plucia@diality.com>

DEN-6359: Addressed code review comments

Options
    • -4
    • +4
    /sources/gui/qml/main.qml
5:49 pm

Behrouz NematiPour

This is my comment and it is specific to the exact line below the comment. Please revert it back to be able to identify which line in the code it refers to. "This code review includes so many unre...

This is my comment and it is specific to the exact line below the comment.
Please revert it back to be able to identify which line in the code it refers to.

"This code review includes so many unrelated branched to the code review subject"
look at the list of the commits and branches included in this page
http://dvm-linux02:8060/project/UI-DEN-6349?max=100&projectKey=UI-DEN-6349&view=fe