application

Clone Tools

Stats

Commits this week: 0
Total Committers: 14
Last Commit: 16 Dec
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 08 Apr 2021
5:43 pm

Peter Lucia <plucia@diality.com>

DEN-7054: Addressed code review comments

Options
    • -108
    • +106
    /sources/model/MWifiNetwork.h
    • -1
    • +1
    /sources/view/VNetworkModel.cpp
    • -21
    • +21
    /sources/wifi/WifiInterface.cpp
    • -2
    • +4
    /sources/wifi/WifiInterface.h
Wednesday 07 Apr 2021
4:37 pm

Behrouz NematiPour

RESOLVED

RESOLVED

4:36 pm

Behrouz NematiPour

RESOLVED

RESOLVED

4:36 pm

Behrouz NematiPour

RESOLVED

RESOLVED

4:36 pm

Behrouz NematiPour

RESOLVED

RESOLVED

4:32 pm

Behrouz NematiPour

Please move it to line 139

Please move it to line 139

4:30 pm

Behrouz NematiPour

Thanks for doing this. But that is not what I meant. Struct Data should only have basic data types which require to be sending between threads. What is implemented here is an immediate struct defin...

Thanks for doing this.
But that is not what I meant.
Struct Data should only have basic data types which require to be sending between threads.
What is implemented here is an immediate struct definition in a class which will be passed and is literally the same as a class and has the only overhead of a struct defined in the class.
Please use Data as the data and remove the functions from the struct Data.
I think the concept of having the struct Data is not clarified, let me know if I need to explain mor.

4:22 pm

Behrouz NematiPour

RESOLVED

RESOLVED

4:20 pm

Behrouz NematiPour

RESOLVED

RESOLVED

4:19 pm

Behrouz NematiPour

RESOLVED

RESOLVED

4:15 pm

Behrouz NematiPour

DEN-7147: Code Review 0

- DEN-7823: Meetings & Support - General Purpose - Kushen Pre-Treatment Images.

Options
    • -1
    • +1
    /denali.pro.user
    • -27
    • +29
    /resources/settings/instructions/instructions.conf
    • binary
    /resources/settings/instructions/slide1_filter_v2.png
    • binary
    /resources/settings/instructions/slide1_filter_v2b.png
    • binary
    /resources/settings/instructions/slide2_filter-connect_v1.png
    • -1
    • +5
    /sources/gui/qml/compounds/InstructionView.qml
    • -2
    • +2
    /sources/gui/qml/pages/pretreatment/PreTreatmentConsumablesStack.qml
    • -4
    • +4
    /sources/gui/qml/pages/pretreatment/PreTreatmentPrimeStack.qml
9:52 am

plucia  (deleted user)

RESOLVED

RESOLVED

9:50 am

plucia  (deleted user)

Thanks. Are we going to need to review your merge commits as well?

Thanks. Are we going to need to review your merge commits as well?

9:40 am

pmontazemi  (deleted user)

RESOLVED.

RESOLVED.

9:35 am

pmontazemi  (deleted user)

RESOLVED.

RESOLVED.

Tuesday 06 Apr 2021
1:34 pm

Behrouz NematiPour

it is an alias name for ISO/IEC_8859-1 character encoding standard. https://en.wikipedia.org/wiki/ISO/IEC_8859-1

it is an alias name for ISO/IEC_8859-1 character encoding standard.
https://en.wikipedia.org/wiki/ISO/IEC_8859-1

7:17 am

pmontazemi  (deleted user)

Why Latin1 and not Latin? Are there two or more Latins?

Why Latin1 and not Latin? Are there two or more Latins?

Monday 05 Apr 2021
1:27 pm

Peter Lucia <plucia@diality.com>

DEN-7521: Ensure static IP assignments display after reboot

Options
    • -0
    • +12
    /sources/wifi/WifiInterface.cpp
10:24 am

plucia  (deleted user)

Will '[' and ']' always be on the same line?

Will '[' and ']' always be on the same line?

10:22 am

plucia  (deleted user)

Can this be deleted?

Can this be deleted?

10:20 am

plucia  (deleted user)

Don't think prepend("/") is needed here since according to https://doc.qt.io/qt-5/qfileinfo.html#absolutePath, "On Unix the absolute path will always begin with the root, '/', directory."

Don't think prepend("/") is needed here since according to https://doc.qt.io/qt-5/qfileinfo.html#absolutePath, "On Unix the absolute path will always begin with the root, '/', directory."

10:16 am

plucia  (deleted user)

If '=' is the last character or first character in the line this won't work

If '=' is the last character or first character in the line this won't work

10:13 am

plucia  (deleted user)

This function only returns 0 so it can be void

This function only returns 0 so it can be void

10:13 am

plucia  (deleted user)

Is there protection in case the file is being written to while you are trying to read it? Doesn't QSettings do all of this for us already?

Is there protection in case the file is being written to while you are trying to read it? Doesn't QSettings do all of this for us already?

10:10 am

plucia  (deleted user)

Is this needed or can it be deleted?

Is this needed or can it be deleted?

10:07 am

plucia  (deleted user)

I see, could you update the comment to say "other than only just logging" so it's clearer? I was totally confused by it

I see, could you update the comment to say "other than only just logging" so it's clearer? I was totally confused by it

10:04 am

Behrouz NematiPour

These are test files for now. Later when we have a real file designed these will be replaced with some real names.

These are test files for now.
Later when we have a real file designed these will be replaced with some real names.

10:03 am

plucia  (deleted user)

Is this class really needed? QSettings is already thread-safe. What does this class do that QSettings doesn't already do?

Is this class really needed? QSettings is already thread-safe. What does this class do that QSettings doesn't already do?

10:01 am

plucia  (deleted user)

Docstrings are missing in this class

Docstrings are missing in this class

10:01 am

plucia  (deleted user)

vGroup is being used so I think you can remove Q_UNUSED

vGroup is being used so I think you can remove Q_UNUSED