application

Clone Tools

Stats

Commits this week: 0
Total Committers: 14
Last Commit: 16 Dec
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 22 Sep 2021
2:50 pm

Behrouz NematiPour

DEN-9639: Code Review 0

- Addressed code reviews

- Reoved LOG_DEBUG_UI since the DEBUG log is all about UI and adding a UI to it was useless.

- Removed the time stamp from the POST start/stop log since the log itself has timestamp.

- Added more documentation to the ApplicationPOST class.

- Renamed the FileSystem to ShaSum check in the ApplicationPOST.

- Updated the WiFi POST check funciton.

- Updated the initial Screen to pause the animation when the UI navigates out of that screen when we are in test (usual case should not happen since we fail or pass the POST and either stops the animation.)

- Updated the AlarmMapping to reflect the FILESYSTEM error change to SHASUM error.

Options
    • -1
    • +1
    /AlarmMapping.csv
    • -1
    • +1
    /denali.pro.user
    • -6
    • +6
    /scripts/run.sh
    • -4
    • +3
    /sources/ApplicationController.cpp
    • -36
    • +35
    /sources/ApplicationPost.cpp
    • -27
    • +61
    /sources/ApplicationPost.h
    • -1
    • +1
    /sources/MainTimer.cpp
    • -3
    • +2
    /sources/bluetooth/BluetoothInterface.cpp
    • -1
    • +1
    /sources/canbus/FrameInterface.cpp
    • -1
    • +1
    /sources/canbus/MessageAcknowModel.cpp
    • -1
    • +1
    /sources/canbus/MessageDispatcher.cpp
    • -2
    • +2
    /sources/canbus/MessageInterpreter.cpp
    • -1
    • +1
    /sources/device/DeviceController.cpp
    • -1
    • +1
    /sources/gui/GuiController.cpp
    • -1
    • +2
    /sources/gui/qml/components/WaitDone.qml
  16. … 5 more files in changeset.
10:07 am

Sean Nash

Remove blank line.

Remove blank line.

9:52 am

Sean Nash

In the header file, the Ethernet and sound tests are said to be not required (i.e. should not prevent system use). So this comment appears to be inconsistent with the header file.

In the header file, the Ethernet and sound tests are said to be not required (i.e. should not prevent system use).
So this comment appears to be inconsistent with the header file.

9:50 am

Sean Nash

"... and then, and them," - looks like something is wrong with this comment.

"... and then, and them," - looks like something is wrong with this comment.

Tuesday 21 Sep 2021
6:26 pm

Sean Nash

RESOLVED.

RESOLVED.

6:26 pm

Sean Nash

RESOLVED.

RESOLVED.

5:58 pm

Behrouz NematiPour

DEN-9826: Follow Up: UI_DEV: POST [ FS ]

- Added a shu256sum for the denali application.

Options
    • -1
    • +15
    /scripts/run.sh
    • -1
    • +1
    /sources/storage/TreatmentLog.cpp
5:55 pm

Behrouz NematiPour

In UI we have multiple types of TODOs. DEBUG, FIXME, WARNING, NOTE, TODO

In UI we have multiple types of TODOs.
DEBUG, FIXME, WARNING, NOTE, TODO

5:53 pm

Behrouz NematiPour

This was not a bug, It was a change request from Sarina to remove the Rinseback Aditional 5 min counter. I kept it in case we may need it later.

This was not a bug,
It was a change request from Sarina to remove the Rinseback Aditional 5 min counter.
I kept it in case we may need it later.

5:49 pm

Sean Nash

Does this mean commenting out these 2 lines fixed a bug? If so, why not just delete them?

Does this mean commenting out these 2 lines fixed a bug? If so, why not just delete them?

5:48 pm

Sean Nash

Temporary? Maybe add a // TODO or is // DEBUG something you'll know to search for later?

Temporary? Maybe add a // TODO or is // DEBUG something you'll know to search for later?

12:56 pm

Behrouz NematiPour

DEN-9928: Post Treatment Log Treatment Time in Hours instead of Minutes

- Changed the "Treatment Duration" and "Actual Treatment Duration" unit to minutes instead of hours.

DEN-10153: Treatment Log Comments Investigations

- Patient Name removed.

- Treatment Duration moved in [Treatment Prescription] section

- Actual Treatment Duration moved in [Treatment Parameters] section

Options
    • -5
    • +7
    /sources/storage/TreatmentLog.cpp
    • -2
    • +2
    /sources/storage/TreatmentLog.h
11:38 am

Behrouz NematiPour

updated.

updated.

11:38 am

Behrouz NematiPour

updated.

updated.

11:38 am

Behrouz NematiPour

updated.

updated.

11:38 am

Behrouz NematiPour

updated.

updated.

11:35 am

Behrouz NematiPour

DEN-9639: Code Review 0

Options
    • -4
    • +4
    /sources/bluetooth/BluetoothInterface.cpp
11:19 am

Behrouz NematiPour

8:39 am

Dara Navaei

Bamboo Commit: Updated MAlarmMapping.cpp

Options
    • -1
    • +1
    /sources/model/hd/alarm/MAlarmMapping.cpp
Monday 20 Sep 2021
10:31 pm

pmontazemi  (deleted user)

We either start with Capital letter everywhere or we don't.

We either start with Capital letter everywhere or we don't.

10:30 pm

pmontazemi  (deleted user)

We either start with Capital Letter everywhere or we don't.

We either start with Capital Letter everywhere or we don't.

10:29 pm

pmontazemi  (deleted user)

Remove extra spaces after vData.

Remove extra spaces after vData.

10:22 pm

pmontazemi  (deleted user)

it is (formal) instead of it's (informal)

it is (formal) instead of it's (informal)

9:46 pm

pmontazemi  (deleted user)

RESOLVED.

RESOLVED.

9:45 pm

pmontazemi  (deleted user)

RESOLVED.

RESOLVED.

9:11 pm

Behrouz NematiPour

DEN-9638: Code Analysis

Options
    • -10
    • +13
    /cppcheck.err
    • -188
    • +207
    /cppcheck.log
9:07 pm

Dara Navaei

Bamboo Commit: Updated MAlarmMapping.cpp

Options
    • -2
    • +2
    /sources/model/hd/alarm/MAlarmMapping.cpp
9:05 pm

Behrouz NematiPour

Fixed.

Fixed.

9:03 pm

Behrouz NematiPour

Code Review Comments

- QApplication typo

- Added a UI version of the Log Macros.

Options
    • -2
    • +2
    /sources/ApplicationController.cpp
    • -1
    • +1
    /sources/MainTimer.cpp
    • -3
    • +3
    /sources/bluetooth/BluetoothInterface.cpp
    • -1
    • +1
    /sources/canbus/CanInterface.cpp
    • -2
    • +2
    /sources/canbus/FrameInterface.cpp
    • -2
    • +2
    /sources/canbus/MessageAcknowModel.cpp
    • -2
    • +2
    /sources/canbus/MessageDispatcher.cpp
    • -4
    • +3
    /sources/canbus/MessageInterpreter.cpp
    • -2
    • +2
    /sources/gui/GuiController.cpp
    • -2
    • +2
    /sources/gui/qml/pages/settings/SettingsBluetoothCuff.qml
    • -4
    • +4
    /sources/storage/Logger.cpp
    • -2
    • +5
    /sources/storage/Logger.h
    • -4
    • +4
    /sources/view/hd/adjustment/common/VCommonAdjustmentVitals.cpp
    • -2
    • +2
    /sources/wifi/WifiInterface.cpp
8:47 pm

Behrouz NematiPour

1) This sleep helps the Bluetooth driver to load properly. 2) After many, many tests figured the Bluetooth device needs a power cycle after it is loaded and find out if giving it a 5-second delay b...

1) This sleep helps the Bluetooth driver to load properly.
2) After many, many tests figured the Bluetooth device needs a power cycle after it is loaded and find out if giving it a 5-second delay before setting the "hci" device to up, then it works fine and doesn't need the power cycle anymore. I timed the boot up and it's still under 30 seconds.
3) Yes it shouldn't break the loading of the other prototypes, since they may never even need it.