application

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Bamboo Commit: Updated MAlarmMapping.cpp

    • -1
    • +1
    /sources/model/hd/alarm/MAlarmMapping.cpp
Bamboo Commit: Updated MAlarmMapping.cpp

    • -2
    • +2
    /sources/model/hd/alarm/MAlarmMapping.cpp
Bamboo Commit: Updated MAlarmMapping.cpp

    • -1
    • +2
    /sources/model/hd/alarm/MAlarmMapping.cpp
Bamboo Commit: Updated MAlarmMapping.cpp

    • -31
    • +37
    /sources/model/hd/alarm/MAlarmMapping.cpp
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

    • -1
    • +1
    /sources/bluetooth/BluetoothInterface.cpp
    • -1
    • +1
    /sources/bluetooth/BluetoothInterface.h
    • -1
    • +1
    /sources/canbus/MessageAcknowModel.cpp
  1. … 145 more files in changeset.
Bamboo Commit: Updated MAlarmMapping.cpp

    • -2
    • +2
    /sources/model/hd/alarm/MAlarmMapping.cpp
Merge branch 'DEN-12258-UI-BN-S66' into staging

Merge branch 'DEN-12258-UI-BN-S66' into develop

Bamboo Commit: Updated MAlarmMapping.cpp

    • -1
    • +1
    /sources/model/hd/alarm/MAlarmMapping.cpp
RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

I don't usually remove these kinds of comments they are there for developers as a reminder to keep the indices match. This is like a code comment.

I don't usually remove these kinds of comments they are there for developers as a reminder to keep the indices match.
This is like a code comment.

So then when would we remove this line of code?

So then when would we remove this line of code?

RESOLVED.

RESOLVED.

Bamboo Commit: Updated MAlarmMapping.cpp

    • -6
    • +6
    /sources/model/hd/alarm/MAlarmMapping.cpp
Bamboo Commit: Updated MAlarmMapping.cpp

    • -2
    • +2
    /sources/model/hd/alarm/MAlarmMapping.cpp
Disabled the "coco end"s as well.

Disabled the "coco end"s as well.

DEN-12597 Code Review

http://dvm-linux02:8060/cru/UI-DEN-12258-1#c12773

Disabled the coco end as well, which caused the coco to log a lot of warnings.

    • -12
    • +12
    /sources/ApplicationController.cpp
    • -2
    • +2
    /sources/bluetooth/BluetoothInterface.cpp
    • -16
    • +16
    /sources/canbus/CanInterface.cpp
    • -2
    • +2
    /sources/canbus/MessageAcknowModel.cpp
    • -4
    • +4
    /sources/canbus/MessageInterpreter.cpp
    • -12
    • +12
    /sources/device/DeviceController.cpp
  1. … 66 more files in changeset.
To make sure it is intentional, and we didn't miss a parameter. also it helps with the copy pasts later.

To make sure it is intentional, and we didn't miss a parameter.
also it helps with the copy pasts later.

IT has been recently removed from the diagnostics screen. I'm not sure when it will be needed to get back again on that screen. Probably keeping it is a lot easier than reimplementing it.

IT has been recently removed from the diagnostics screen.
I'm not sure when it will be needed to get back again on that screen.
Probably keeping it is a lot easier than reimplementing it.

When will this get fixed (removed)?

When will this get fixed (removed)?

Why only comment out? Can't we just remove?

Why only comment out? Can't we just remove?

Bamboo Commit: Updated MAlarmMapping.cpp

    • -12
    • +12
    /sources/model/hd/alarm/MAlarmMapping.cpp
Bamboo Commit: Updated MAlarmMapping.cpp

    • -6
    • +6
    /sources/model/hd/alarm/MAlarmMapping.cpp
DEN-12517 Code Analysis

very good point Sean. Coco ignores it but logs each one which I think it more bothers us than coco. I am going to disable them too.

very good point Sean.
Coco ignores it but logs each one which I think it more bothers us than coco.
I am going to disable them too.

Merge branch 'DEN-12258-UI-BN-S66' into develop