application

Clone Tools

Stats

Commits this week: 0
Total Committers: 14
Last Commit: 16 Dec
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 25 Feb
4:14 pm

Dara Navaei

DEN-17157: Update_Denali_Application_for_Dry_Demo

- Addressed the code review comments.

Options
    • -6
    • +9
    /sources/gui/qml/pages/pretreatment/create/PreTreatmentCreate.qml
    • -1
    • +2
    /sources/gui/qml/pages/treatment/sections/TreatmentVitals.qml
4:09 pm

Dara Navaei

Done

Done

3:43 pm

Behrouz NematiPour

RESOLVED

RESOLVED

3:43 pm

Behrouz NematiPour

RESOLVED

RESOLVED

3:43 pm

Behrouz NematiPour

RESOLVED

RESOLVED

3:42 pm

Behrouz NematiPour

RESOLVED

RESOLVED

3:41 pm

Behrouz NematiPour

RESOLVED

RESOLVED

3:40 pm

Behrouz NematiPour

RESOLVED

RESOLVED

3:40 pm

Behrouz NematiPour

RESOLVED

RESOLVED

3:38 pm

Dara Navaei

DEN-17157: Update_Denali_Application_for_Dry_Demo

- Addressed the code review comments.

Options
    • -1
    • +1
    /main.cpp
    • -2
    • +2
    /sources/gui/qml/components/SliderCreateTreatment.qml
    • -1
    • +1
    /sources/gui/qml/main.qml
    • -0
    • +4
    /sources/gui/qml/pages/pretreatment/connection/PreTreatmentUltrafiltration.qml
    • -4
    • +7
    /sources/gui/qml/pages/pretreatment/create/PreTreatmentCreate.qml
    • -4
    • +7
    /sources/gui/qml/pages/treatment/sections/TreatmentVitals.qml
    • -1
    • +1
    /sources/view/confirm/VConfirm.cpp
    • -2
    • +2
    /sources/view/confirm/VConfirm.h
3:29 pm

Dara Navaei

Done

Done

3:29 pm

Dara Navaei

Done

Done

3:28 pm

Dara Navaei

Done

Done

3:27 pm

Dara Navaei

Done

Done

3:27 pm

Dara Navaei

Done

Done

3:26 pm

Dara Navaei

Done

Done

3:21 pm

Dara Navaei

Done

Done

3:01 pm

Dara Navaei

Done

Done

2:58 pm

Dara Navaei

Done

Done

2:57 pm

Dara Navaei

Done

Done

2:54 pm

Dara Navaei

Done

Done

2:49 pm

Behrouz NematiPour

please add //DEBUG: to comment this out.

please add //DEBUG: to comment this out.

2:48 pm

Behrouz NematiPour

please align arguments.

please align arguments.

2:47 pm

Behrouz NematiPour

please remove extra space before DRY_...

please remove extra space before DRY_...

2:46 pm

Behrouz NematiPour

I believe you should correct the other z-orders.

I believe you should correct the other z-orders.

2:45 pm

Behrouz NematiPour

same here as above. *same here as above.
  • same here as above.
  • same here as above.
2:44 pm

Behrouz NematiPour

is there a specific reason the notSetVariable function is not used and replaced with "__"?

is there a specific reason the notSetVariable function is not used and replaced with "__"?

2:42 pm

Behrouz NematiPour

please do the same as the comment in the following link: http://devapps.diality.us:8060/cru/UI-DEN-17157-1#c21568

please do the same as the comment in the following link:
http://devapps.diality.us:8060/cru/UI-DEN-17157-1#c21568

2:40 pm

Behrouz NematiPour

please align the " ,2"

please align the " ,2"

2:39 pm

Behrouz NematiPour

please define these numbers (on other lines as well) as a: readonly property <type of the value> <name of the propery> example: on top: readonly property int bloodFlowRateDef : 400 replace with: d...

please define these numbers (on other lines as well) as a:
readonly property <type of the value> <name of the propery>
example:
on top:

readonly property int bloodFlowRateDef : 400

replace with:

defaultValue: _GuiView.dryDemoMode ? _root.bloodFlowRateDef : vTreatmentRanges.bloodFlowRateDef