application

Clone Tools

Stats

Commits this week: 0
Total Committers: 14
Last Commit: 16 Dec
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 05 Jan 2021
5:16 pm

Peman Montazemi <pmontazemi@diality.com>

DEN-4964: Addressed code review comments.

Options
    • -6
    • +4
    /denali.pro
    • -2
    • +1
    /sources/gui/guiglobals.cpp
    • -8
    • +8
    /sources/model/hd/adjustment/MTreatmentAdjustHDVersionsResponse.h
    • -41
    • +0
    /sources/view/dg/adjustment/VTreatmentAdjustmentDGVersions.cpp
    • -68
    • +0
    /sources/view/dg/adjustment/VTreatmentAdjustmentDGVersions.h
    • -13
    • +32
    /sources/view/hd/adjustment/VTreatmentAdjustmentHDVersions.cpp
    • -68
    • +0
    /sources/view/hd/adjustment/VTreatmentAdjustmentHDVersions.h
    • -0
    • +78
    /sources/view/hd/adjustment/VTreatmentAdjustmentVersions.h
    • -2
    • +1
    /sources/view/vview.h
10:57 am

Peman Montazemi <pmontazemi@diality.com>

DEN-4964: Addressed code review comments.

Options
    • -3
    • +3
    /sources/model/dg/data/MDGAccelerometerData.h
Monday 04 Jan 2021
2:43 pm

Behrouz NematiPour

DEN-5836: Alarm:Code Coverage

- updated the alarm message table

- fixed the -q parameter

Options
    • -1
    • +1
    /denali.pro.user
    • -59
    • +111
    /sources/model/hd/alarm/MAlarmStatusData.cpp
    • -9
    • +8
    /sources/view/hd/alarm/VAlarmStatus.cpp
Sunday 03 Jan 2021
10:02 pm

Peman Montazemi <pmontazemi@diality.com>

DEN-4964: Addressed code review comments.

Options
    • -3
    • +3
    /sources/model/hd/adjustment/MTreatmentAdjustHDVersionsResponse.h
    • -3
    • +3
    /sources/model/hd/data/MHDAccelerometerData.h
10:00 pm

Peman Montazemi <pmontazemi@diality.com>

DEN-4964: Addressed code review comments.

Options
    • -1
    • +0
    /sources/canbus/messageinterpreter.cpp
    • -3
    • +3
    /sources/model/dg/adjustment/MTreatmentAdjustDGVersionsResponse.h
9:57 pm

Peman Montazemi <pmontazemi@diality.com>

DEN-4964: Addressed code review comments.

Options
    • -1
    • +1
    /sources/model/dg/data/MDGAccelerometerData.h
Wednesday 30 Dec 2020
3:49 pm

Peter Lucia <plucia@diality.com>

DEN-4866, DEN-4863, DEN-4862: Added class descriptions, fixed unit test, ran static code analysis

- Fixed tst_canbus issue likely introduced in f1e100d1368

Options
    • -18
    • +25
    /cppcheck.err
    • -94
    • +134
    /cppcheck.log
    • -0
    • +13
    /sources/bluetooth/BLEScanner.h
    • -0
    • +8
    /sources/view/VBluetooth.h
    • -0
    • +7
    /sources/view/VBluetoothDeviceInfo.h
    • -6
    • +1
    /unittests/tst_canbus.cpp
Tuesday 29 Dec 2020
4:36 pm

Peter Lucia <plucia@diality.com>

DEN-4863, DEN-4865: Code Coverage and Unit Tests

Options
    • -3
    • +3
    /denali.pro.user
    • -0
    • +1
    /sources/gui/qml/dialogs/NotificationDialog.qml
    • -0
    • +17
    /sources/gui/qml/pages/SettingsHome.qml
    • -0
    • +2
    /sources/storage/FileHandler.cpp
    • -1
    • +4
    /sources/storage/Logger.cpp
    • -1
    • +10
    /sources/view/VTreatmentBegin.cpp
    • -0
    • +2
    /sources/view/VTreatmentBegin.h
    • -1
    • +1
    /sources/view/hd/adjustment/VTreatmentAdjustmentUltrafiltrationInit.h
    • -0
    • +107
    /unittests/tst_models.cpp
    • -0
    • +9
    /unittests/tst_models.h
3:49 pm

Peman Montazemi <pmontazemi@diality.com>

DEN-4964: Addressed code review comments.

Options
    • -1
    • +0
    /sources/canbus/messageinterpreter.cpp
3:47 pm

Peman Montazemi <pmontazemi@diality.com>

DEN-4964: Addressed code review comments.

Options
    • -1
    • +1
    /sources/canbus/messageglobals.h
3:45 pm

Peman Montazemi <pmontazemi@diality.com>

DEN-4964: Addressed code review comments.

Options
    • -2
    • +2
    /sources/canbus/messageglobals.h
3:42 pm

Peman Montazemi <pmontazemi@diality.com>

DEN-4964: Addressed code review comments.

Options
    • -0
    • +13
    /sources/model/hd/adjustment/MTreatmentAdjustRequests.h
3:28 pm

Peman Montazemi <pmontazemi@diality.com>

DEN-4964: Addressed code review comments.

Options
    • -1
    • +1
    /sources/model/dg/data/MDGAccelerometerData.h
    • -1
    • +1
    /sources/model/hd/data/MHDAccelerometerData.h
3:23 pm

Peman Montazemi <pmontazemi@diality.com>

DEN-4964: Addressed code review comments.

Options
    • -1
    • +1
    /denali.pro.user
    • -1
    • +0
    /sources/model/dg/adjustment/MTreatmentAdjustDGVersionsResponse.cpp
    • -0
    • +30
    /sources/model/dg/adjustment/MTreatmentAdjustDGVersionsResponse.h
    • -1
    • +0
    /sources/model/hd/adjustment/MTreatmentAdjustHDVersionsResponse.cpp
    • -0
    • +30
    /sources/model/hd/adjustment/MTreatmentAdjustHDVersionsResponse.h
    • -0
    • +7
    /sources/view/dg/adjustment/VTreatmentAdjustmentDGVersions.h
    • -0
    • +7
    /sources/view/hd/adjustment/VTreatmentAdjustmentHDVersions.h
Wednesday 23 Dec 2020
5:28 pm

Peter Lucia <plucia@diality.com>

DEN-4863, DEN-4865: Updated unit tests and code coverage for bluetooth

Options
    • -0
    • +3
    /sources/bluetooth/BLEScanner.cpp
    • -0
    • +2
    /sources/view/VAlert.h
    • -0
    • +2
    /sources/view/VBluetooth.cpp
    • -1
    • +3
    /sources/view/VBluetoothDeviceInfo.cpp
    • -0
    • +7
    /sources/view/VBluetoothDeviceInfo.h
    • -4
    • +11
    /sources/view/VVitals.cpp
    • -0
    • +2
    /sources/view/VVitals.h
    • -0
    • +28
    /unittests/tst_views.cpp
    • -0
    • +2
    /unittests/tst_views.h
3:30 pm

Peter Lucia <plucia@diality.com>

DEN-4865, DEN-5642: Checking BLE connection before sending UF volume, fixed unit test errors and added object names to support squishqt tests

Options
    • -4
    • +4
    /denali.pro.user
    • -1
    • +4
    /sources/gui/qml/dialogs/Alert.qml
    • -0
    • +4
    /sources/gui/qml/dialogs/NotificationDialog.qml
    • -0
    • +2
    /sources/gui/qml/pages/treatment/TreatmentBegin.qml
    • -0
    • +4
    /sources/gui/qml/pages/treatment/TreatmentCreate.qml
    • -1
    • +7
    /sources/gui/qml/pages/treatment/TreatmentStack.qml
    • -1
    • +1
    /sources/model/hd/alarm/MAlarmStatusData.cpp
    • -7
    • +17
    /sources/view/VTreatmentBegin.cpp
    • -0
    • +2
    /sources/view/VTreatmentBegin.h
    • -15
    • +0
    /unittests/tst_messaging.cpp
    • -1
    • +0
    /unittests/tst_messaging.h
    • -8
    • +0
    /unittests/tst_models.cpp
    • -3
    • +0
    /unittests/tst_models.h
    • -1
    • +0
    /unittests/tst_views.cpp
Tuesday 22 Dec 2020
10:00 am

Behrouz NematiPour

Resolved merge issue

Options
    • -1
    • +0
    /sources/canbus/MessageInterpreter.cpp
9:53 am

Behrouz NematiPour

Merge branch 'DEN-5751_Pre-TreatmentUltrafiltration' into demo_test

Options
    • -4
    • +6
    /sources/gui/qml/globals/Variables.qml
9:48 am

Behrouz NematiPour

Merge branch 'DEN-5830_AlarmDesign' into demo_test

Options
    • -0
    • +2
    /denali.pro
    • -1
    • +9
    /sources/canbus/MessageInterpreter.cpp
9:28 am

Behrouz NematiPour

DEN-5833: Implementation

- Added a UI "AlarmGenerator" class to handle the HD_COMM_TIMEOUT and later the BLE Cuff alarm (PRS 395).

Options
    • -0
    • +2
    /denali.pro
    • -0
    • +75
    /sources/AlarmGenerator.cpp
    • -0
    • +55
    /sources/AlarmGenerator.h
    • -6
    • +2
    /sources/gui/GuiController.cpp
    • -8
    • +9
    /sources/view/hd/alarm/VAlarmStatus.cpp
Thursday 17 Dec 2020
4:19 pm

Behrouz NematiPour

DEN-5833: Implementation

- Cleaned up the unit tests

Options
    • -25
    • +3
    /unittests/tst_canbus.cpp
    • -1
    • +0
    /unittests/tst_canbus.h
    • -225
    • +0
    /unittests/tst_messaging.cpp
    • -16
    • +0
    /unittests/tst_messaging.h
    • -1
    • +1
    /unittests/tst_models.cpp
1:19 pm

Behrouz NematiPour

Merge branch 'DEN-5830_AlarmDesign' into 2020_EOY_DEMO

Options
1:19 pm

Behrouz NematiPour

DEN-5833: Implementation

- added a touch expanding area for the TouchArea so regardless of its visual size it can have expanded touchable area.

- the touch expanding for the mute button set to 25 so it can have a bigger touch area that its size which is little.

Options
    • -1
    • +1
    /sources/gui/qml/components/MuteButton.qml
    • -0
    • +1
    /sources/gui/qml/components/NotificationBar.qml
    • -1
    • +4
    /sources/gui/qml/components/TouchRect.qml
    • -0
    • +1
    /sources/gui/qml/dialogs/NotificationDialog.qml
Wednesday 16 Dec 2020
3:07 pm

Behrouz NematiPour

DEN-5754: Implementation

- cherry picked a fix from DEN-5830_AlarmDesign@51accb for the Treatment End message which has no payload.

- Also made the interpretMessage() for received messages to be more identical to the DEN-5830_AlarmDesign to hopefully help merging easier.

Options
    • -7
    • +20
    /sources/canbus/MessageInterpreter.cpp
2:55 pm

Behrouz NematiPour

DEN-6022: The ultrafiltration inconsistency

- Had a conversation with Syseng(Nic) and Fweng(Sean) and decided to have the fix somehow more understandable but there is no actual fix and if that happens it would be the FW bug.

- The modification is that the main progress bar will always has VTreatmentUltratiltration.minimum as minimum (current;y always zero) and VTreatmentUltratiltration.maximum as maximum.

- The UI always expects to get the vTreatmentRanges.treatmentRanges_Ultrafiltration_Volume_Min (adjustable min and slider min) greater than vTreatmentUltrafiltration.ultrafiltration_RefUFVol (current uf volume delivered and current value on the progress bar) and so close to eachother.

- Removed the precision from VTreatmentUltrafiltration and moved into the Variables.

Options
    • -4
    • +6
    /sources/gui/qml/globals/Variables.qml
    • -2
    • +2
    /sources/gui/qml/pages/treatment/TreatmentBegin.qml
    • -1
    • +1
    /sources/gui/qml/pages/treatment/adjustments/TreatmentAdjustmentUltrafiltrationConfirm.qml
    • -27
    • +17
    /sources/gui/qml/pages/treatment/adjustments/TreatmentAdjustmentUltrafiltrationEdit.qml
    • -2
    • +1
    /sources/gui/qml/pages/treatment/adjustments/TreatmentAdjustmentUltrafiltrationPaused.qml
    • -2
    • +1
    /sources/gui/qml/pages/treatment/adjustments/TreatmentAdjustmentUltrafiltrationStart.qml
    • -2
    • +1
    /sources/gui/qml/pages/treatment/sections/TreatmentUltrafiltration.qml
    • -6
    • +2
    /sources/view/hd/data/VTreatmentUltrafiltration.h
Tuesday 15 Dec 2020
10:12 pm

Behrouz NematiPour

Merge branch 'DEN-5830_AlarmDesign' into 2020_EOY_DEMO

Options
    • -11
    • +13
    /sources/canbus/MessageInterpreter.cpp
    • -6
    • +9
    /sources/view/hd/alarm/VAlarmStatus.cpp
9:45 pm

Behrouz NematiPour

DEN-5833: Implementation

- Added a MACRO for convenience of empty payload messages handling.

Options
    • -1
    • +9
    /sources/canbus/MessageInterpreter.cpp
9:12 pm

Behrouz NematiPour

DEN-5833: Implementation

- Fixed the bug that alarm ID zero which is the clear the alarm indication wasn't updating the properties, so caused to alarm_ID changed notification signal not to raise and GUI wasn't getting updated.

Options
    • -6
    • +6
    /sources/view/hd/alarm/VAlarmStatus.cpp
6:34 pm

Behrouz NematiPour

Merge branch 'DEN-5751_Pre-TreatmentUltrafiltration' into demo_test

Options
6:33 pm

Behrouz NematiPour

DEN-5754: Implementation

- Fixed a bug caused by a typo

Options
    • -1
    • +1
    /sources/gui/qml/pages/treatment/TreatmentStack.qml