TouchRect.qml

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 619 more files in changeset.
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 619 more files in changeset.
UI-DEN-SUNRISE
UI-DEN-SUNRISE
RESOLVED

RESOLVED

UI-DEN-16526-UI-BN-S109-3 [ application ]
UI-DEN-16526-UI-BN-S109-3 [ application ]
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 612 more files in changeset.
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 612 more files in changeset.
UI Release/p1_staging Unreviewed Commits
UI Release/p1_staging Unreviewed Commits
DENBUG-182: Phantom Alarm Screen Appears After Clearing Last Alarm

DENBUG-185: UI shows version without period in between (ECO-11648, ECO-11616)

DENBUG-182: Phantom Alarm Screen Appears After Clearing Last Alarm

Addressing Code Review comments

Addressing code review comments

compatibility needs the separator before the value

DENBUG-182: Phantom Alarm Screen Appears After Clearing Last Alarm

- the order of the QML PROPERTYs cannot exactly predicted therefore setting them if not needed has to be avoided.

- a new method _init has been added to the PROPERTY_BASE to reset the property value without triggering the changed method so the property will get updated on the next round if the same value as before has been sent. ( the issue could be if code return after the alarmID = 0 on next alarm if the same ID send since the value is the same the QML will not get any signal to update, by changing the private property the signal will be triggered.)

DENBUG-182: Phantom Alarm Screen Appears After Clearing Last Alarm

- the order of the QML PROPERTYs cannot exactly predicted therefore setting them if not needed has to be avoided.

- set the alarmID to 0 to trigger the next change since we skip the property updated if the alarmID is 0.

DENBUG-182: Phantom Alarm Screen Appears After Clearing Last Alarm

  1. … 3 more files in changeset.
RESOLVED in CODE WALKTHROUGH you're welcome.

RESOLVED in CODE WALKTHROUGH
you're welcome.

RESOLVED

RESOLVED

Oh, I see, I am missing an "n". Fixed

Oh, I see, I am missing an "n".
Fixed

Addressing code review comments

RESOLVE

RESOLVE

Yes, that's the other typo.

Yes, that's the other typo.

I fixed both, isn't it? that is what I see.

I fixed both,
isn't it?
that is what I see.

You're missing an n in the "clickDeboucing" same issue with the others

You're missing an n in the "clickDeboucing" same issue with the others

fixed, thanks for pointing that out.

fixed,
thanks for pointing that out.

Used your exact suggestion. thanks,

Used your exact suggestion.
thanks,

Addressing Code Review comments

  1. … 1 more file in changeset.
Suggestion (spell check): // When alarm status 0 is sent from HD to clear/hide the AlarmDialog, it comes with priority 0 // priority 0 has no clear definition; therefore, UI will set the coloring ...

Suggestion (spell check):

// When alarm status 0 is sent from HD to clear/hide the AlarmDialog, it comes with priority 0
// priority 0 has no clear definition; therefore, UI will set the coloring to the default system theme: blue.
// The blue color is confusing users, so we skip this coloring.

typo for debounce in the property name and also the timer's ID.

typo for debounce in the property name and also the timer's ID.