MTreatmentLogEventData.h

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
UI-DEN-SUNRISE
UI-DEN-SUNRISE
RESOLVED.

RESOLVED.

Thanks, Will update my comment.

Thanks,
Will update my comment.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

Your comment has ???. Trying to help.

Your comment has ???. Trying to help.

Fixed too.

Fixed too.

Great catch, Thank a lot Sean for catching that. It is fixed.

Great catch,
Thank a lot Sean for catching that.
It is fixed.

Not clear what you want me to do here?

Not clear what you want me to do here?

In post-treatment, there are a few states to work through to ensure reservoirs get drained: /* Post-Treatment drain reservoirs state machine. */ typedef enum Drain_States { DRAIN_DG_DEPRIME_STATE ...

In post-treatment, there are a few states to work through to ensure reservoirs get drained:

/* Post-Treatment drain reservoirs state machine. */
typedef enum Drain_States
{
DRAIN_DG_DEPRIME_STATE = 0, ///< Drain DG De-prime dialysate lines of excess fluid state.
DRAIN_RESERVOIR_SWITCH_STATE, ///< Switch reservoir state.
DRAIN_RESERVOIR_START_DRAIN_STATE, ///< Drain reservoir start drain state.
DRAIN_RESERVOIR_DRAIN_STATE, ///< Drain first reservoir state.
DRAIN_RESERVOIR_COMPLETE_STATE, ///< Drain complete state.
NUM_OF_DRAIN_STATES ///< Number of drain states.
} DRAIN_STATE_T;

Same ordering should apply here (even if order doesn't matter - prefer to match structure of message payload).

Same ordering should apply here (even if order doesn't matter - prefer to match structure of message payload).

I think the raw order should be cpi, cpo, cd1, cd2 (reverse of what's here). Same order issue with status below.

I think the raw order should be cpi, cpo, cd1, cd2 (reverse of what's here). Same order issue with status below.

UI-DEN-14936_UI BN S93
UI-DEN-14936_UI BN S93
UI-DEN-14936_UI BN S93
UI-DEN-14936_UI BN S93
RESOLVED

RESOLVED

From what I can tell the dg command is separated from the hd command which is good. Please let me know when your code is ready to be merged to staging and I will handle it. Also for the next featur...

From what I can tell the dg command is separated from the hd command which is good.
Please let me know when your code is ready to be merged to staging and I will handle it.
Also for the next feature you're working on please branch off of the latest staging.

I don't have dg_simulator. It would be a merge task later to merge this code into the staging, I think it's out of the code review scope.

I don't have dg_simulator.
It would be a merge task later to merge this code into the staging, I think it's out of the code review scope.

The dg simulator needs to be used for dg responses here still

The dg simulator needs to be used for dg responses here still

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED