Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
4246: Merge Newly added Squish API Messages into Dial-In

- Has not been merged yet but preparing for.

  1. … 15 more files in changeset.
FW Support for HD/DG Debug Text & HDOpMode.

- Added a newly added channel to the list of listened channels eChlid_DG_UI = 0x070

- The MessageBuilder::getActionId implementation has been improved.

- New Messages has been added and enum/length defined as well.

- Message interpreter code has been improved to be easily modifiable.

- Changed the message ID enum ID_PowerOffBroadcast to ID_ShuttingDown.

- Added HDOperationMode to the setting screen.

- Made the floating point rounding optional by a #define and disabled the rounding for now.

- Inherit the MPowerOff Model from MAbstract as a new design.

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -0
    • +44
    ./VHDOperationModeData.cpp
    • -0
    • +45
    ./VHDOperationModeData.h
  1. … 29 more files in changeset.
Updated the Copyright with the current year and replaced tabs with 4 spaces

    • -9
    • +10
    ./vtreatmentadjustmentresponsebase.cpp
    • -9
    • +10
    ./vtreatmentadjustmentresponsebase.h
    • -9
    • +10
    ./vtreatmentadjustmentultrafiltrationconfirm.cpp
  1. … 184 more files in changeset.
DEN-3880 : Implementation

- Added application name and version in the log.

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

  1. … 2 more files in changeset.
DEN-3874 : HW Support [Per Peman's Email]

- Reversed the ValvesState view order.

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -12
    • +12
    ./dg/data/VDGValvesStatesData.cpp
DEN-3874 : HW Support [Per Peman's Email]

- Just to keep the code. Needs clean up.

- Don't forget Logs (DG, HD is different)

- So many more.

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -0
    • +25
    ./dg/data/VDGDrainPumpData.cpp
    • -0
    • +36
    ./dg/data/VDGDrainPumpData.h
    • -0
    • +26
    ./dg/data/VDGHeatersData.cpp
    • -0
    • +37
    ./dg/data/VDGHeatersData.h
    • -0
    • +27
    ./dg/data/VDGLoadCellReadingsData.cpp
    • -0
    • +38
    ./dg/data/VDGLoadCellReadingsData.h
    • -0
    • +44
    ./dg/data/VDGOperationModeData.cpp
    • -0
    • +45
    ./dg/data/VDGOperationModeData.h
    • -0
    • +27
    ./dg/data/VDGPressuresData.cpp
    • -0
    • +38
    ./dg/data/VDGPressuresData.h
    • -0
    • +26
    ./dg/data/VDGROPumpData.cpp
    • -0
    • +37
    ./dg/data/VDGROPumpData.h
    • -0
    • +26
    ./dg/data/VDGReservoirData.cpp
    • -0
    • +37
    ./dg/data/VDGReservoirData.h
    • -0
    • +35
    ./dg/data/VDGTemperaturesData.cpp
  1. … 127 more files in changeset.
DEN-3880 : Implementation

- Added Alarm Triggered Model

- Added Alarm Cleared Model

- Added Treatment State Model

- "UI," as Event Source to the Initialized and Some Other Event Messages for better logging

- Updated Ack messages and made them nicer for logging.

- Added DGCheckIn as a message to be logged.

- Stored Unit texts as a read only property in Variables qml file which had multiple definition multiple places.

- Changed the toString of models to use comma instead of parenthesis to be easily used in Excel as a CSV file format.

- Found a bug in TreatmentAdjustmentUltrafiltrationConfirm Screen slot which had volume defined as int that actually is a float value and causes the float to be truncated also the volume should be traslated int the VTreatmentAdjustmentUltrafiltratinConfirm to mL from Liter. Although HD wasn't using that value and was not complaining about it.

- Changed the current pew-set Volume value in the TreatmentAdjustmentUltrafiltrationEdit screen to be the current max value which is actually going to be changed by user.

- Changed to use the reference Volume to be used as the current collected volume in the Ultrafiltration section of the main treatment screen and the other Ultrafiltration adjustment screen that using it (Start. Paused, Edit).

- Added toString to the request models to be used for logging.

- Refactored the Message Interpreter response methods to be unique like the other improved latest methods (get<Method>s removed) [Reordered, Document cleanup, and so].

- Updated the manual in the MModel header for creating a model in regards to refactoring above.

- Updated Response Models in regards to the refactoring above.

- Made each byte space separator in Flags class in Types class for cleaner logging (will be used empty string in Alarm Status for logging).

- Changed the logging folder to be log folder (not event, error) and changed the log file extension for events/data to be .log and for errors to be .err.

- log file format modified to be CSV.

- Removed a not used fromByteArrayState method of mtreatmentadjustmentultrafiltrationconfirmresponse , mtreatmentadjustmentultrafiltrationeditresponse.

________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -2
    • +2
    ./vtreatmentadjustmentultrafiltrationconfirm.cpp
  1. … 61 more files in changeset.
Added explanations to coco begin validated clauses

  1. … 1 more file in changeset.
Improved code coverage to 99.967%

  1. … 6 more files in changeset.
Changed -q flag to disable hd communication timeout only, squishqt, code coverage changes

  1. … 4 more files in changeset.
Updates to support unit testing

  1. … 10 more files in changeset.
DEN-3157 : Code Coverage

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -12
    • +6
    ./vtreatmentadjustmentultrafiltrationstate.cpp
  1. … 3 more files in changeset.
Updated valarmstatus.cpp

DEN-3157 : Code Coverage

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -3
    • +7
    ./vtreatmentadjustmentultrafiltrationstate.cpp
  1. … 13 more files in changeset.
DEN-3156 Integration Testing

- 90.849% (1916/2109)

________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -1
    • +4
    ./vtreatmentadjustmentultrafiltrationconfirm.h
  1. … 3 more files in changeset.
DEN-3155 : Unit Testing

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -1
    • +5
    ./vtreatmentadjustmentresponsebase.cpp
  1. … 2 more files in changeset.
DEN-3628 : EMC Test Support

- Adding Temperature sensors values on the settings diagnostic page.

- Applied Code Review comments.

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -0
    • +35
    ./vtemperaturesensors.cpp
    • -0
    • +46
    ./vtemperaturesensors.h
  1. … 19 more files in changeset.
DEN-3628 : EMC Test Support

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -0
    • +27
    ./vloadcellreadings.cpp
    • -0
    • +38
    ./vloadcellreadings.h
  1. … 13 more files in changeset.
Alarm UI improvements

  1. … 2 more files in changeset.
Moved request silence connection to initConnections() When pressing OK, the alarm bar will flash instead of the alarm window.

  1. … 3 more files in changeset.
Raising alarm when HD communication times out Added Settings base page with Sound and Diagnostic pages. Alarm design updates

  1. … 21 more files in changeset.
DEN-3149 : Treatment Ultrafiltration Adjustment

- The third Code Review by myself

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -46
    • +0
    ./vtreatmentadjustmentultrafiltration.cpp
    • -56
    • +0
    ./vtreatmentadjustmentultrafiltration.h
    • -0
    • +52
    ./vtreatmentadjustmentultrafiltrationconfirm.cpp
    • -0
    • +54
    ./vtreatmentadjustmentultrafiltrationconfirm.h
    • -0
    • +46
    ./vtreatmentadjustmentultrafiltrationedit.cpp
    • -0
    • +56
    ./vtreatmentadjustmentultrafiltrationedit.h
    • -0
    • +78
    ./vtreatmentadjustmentultrafiltrationstate.cpp
    • -0
    • +54
    ./vtreatmentadjustmentultrafiltrationstate.h
    • -52
    • +0
    ./vtreatmentultrafiltrationconfirm.cpp
    • -54
    • +0
    ./vtreatmentultrafiltrationconfirm.h
    • -78
    • +0
    ./vtreatmentultrafiltrationstate.cpp
  1. … 11 more files in changeset.
DEN-3149 : Treatment Ultrafiltration Adjustment

- The second Code Review by myself

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -5
    • +2
    ./vtreatmentadjustmentultrafiltration.cpp
    • -5
    • +2
    ./vtreatmentultrafiltrationconfirm.cpp
  1. … 9 more files in changeset.
DEN-3149 : Treatment Ultrafiltration Adjustment

- The first my myself.

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -0
    • +52
    ./vtreatmentadjustmentresponsebase.cpp
    • -0
    • +56
    ./vtreatmentadjustmentresponsebase.h
    • -52
    • +0
    ./vtreatmentadjustmentsresponse.cpp
    • -2
    • +2
    ./vtreatmentadjustmentultrafiltration.h
  1. … 20 more files in changeset.
Continuation of alarms.

  1. … 9 more files in changeset.
DEN-3149 : Treatment Ultrafiltration Adjustment

- Revert back the Ultrafiltration rate to the mL.

- Added a QT_DEBUG define for the Ultrafiltration volume because usually we are not connected to the pump and measVol would return 0 but RefVol is the calculated vol and should always have a value.

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

  1. … 2 more files in changeset.
DEN-3149 : Treatment Ultrafiltration Adjustment

- Adding the last Ultrafiltration message transaction to confirm the values.

- Added the modification of the Ultrafiltration Volume unit change.

- Modified the components to support real/float variables to support Ultrafiltration volume with Liter as unit and 3 digit precision.

- So much refactoring

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -6
    • +11
    ./vtreatmentadjustmentultrafiltration.cpp
    • -7
    • +4
    ./vtreatmentadjustmentultrafiltration.h
    • -14
    • +14
    ./vtreatmentultrafiltrationconfirm.cpp
  1. … 34 more files in changeset.
Added Notification Dialog for Alarms and support for alarm dismiss actions by the user.

  1. … 10 more files in changeset.
DEN-3154 : Implementation [ Messaging ]

- Added the Ultrafiltration Adjustment Confirm Request

- Improved the MVC and some twicks in qml.

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -0
    • +55
    ./vtreatmentultrafiltrationconfirm.cpp
    • -0
    • +54
    ./vtreatmentultrafiltrationconfirm.h
  1. … 19 more files in changeset.
DEN-3149 : Treatment Ultrafiltration Adjustment

- Updated the MVC/Messaging with the updated Ultrafiltration Adjustment message.

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -1
    • +1
    ./vtreatmentadjustmentultrafiltration.cpp
    • -2
    • +2
    ./vtreatmentadjustmentultrafiltration.h
  1. … 5 more files in changeset.