sources

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Already checked with Behrous

Already checked with Behrous

Previous lines are removed

Previous lines are removed

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

removed

removed

thank for catching that, it has been fixed.

thank for catching that,
it has been fixed.

this will automatically get corrected when the file name is changed in the file explorer of the QtCreator.

this will automatically get corrected when the file name is changed in the file explorer of the QtCreator.

the file and the actual Class name does not necessary should be the same. to make sure these are not dependent, I use alias in the qrc. so although the name was not correct this still works.

the file and the actual Class name does not necessary should be the same.
to make sure these are not dependent, I use alias in the qrc.
so although the name was not correct this still works.

Correct, that is for clarification since in each of the child(ish) classes in stack back and confirm have different meaning.

Correct, that is for clarification since in each of the child(ish) classes in stack back and confirm have different meaning.

We should check with Behrouz, but I think we should comment out the entire item instead of just the text property because the Text item still takes up space. For this case, we didn't define a fixed...

We should check with Behrouz, but I think we should comment out the entire item instead of just the text property because the Text item still takes up space. For this case, we didn't define a fixed width, but if we did, there will be a gap.

Do we need to do this? The previous text binding had the "pairedAddr" in it.

Do we need to do this? The previous text binding had the "pairedAddr" in it.

If the file is indeed incorrectly named, please also correct here

If the file is indeed incorrectly named, please also correct here

This should not have worked considering the QML file is misnamed. Please re-check

This should not have worked considering the QML file is misnamed. Please re-check

Please remove empty space.

Please remove empty space.

"compeleted" => "completed"

"compeleted" => "completed"

I am assuming you are purposely adding "treatmentBackClicked" signal for clarity here? The back signal from the base (EndTreatmentBase) can be detected as part of the EndTreatmentRinseBackConnect I...

I am assuming you are purposely adding "treatmentBackClicked" signal for clarity here? The back signal from the base (EndTreatmentBase) can be detected as part of the EndTreatmentRinseBackConnect Item.

The file name is missing "ck" for the back. I don't believe you did that on purpose ?

The file name is missing "ck" for the back. I don't believe you did that on purpose ?

UI-DEN-15905-UI-BN-S102 [ Ready ]
UI-DEN-15905-UI-BN-S102 [ Ready ]
UI-DEN-15896_UI MS S102
UI-DEN-15896_UI MS S102
Code Reviews are done: Application: http://devapps.diality.us:8060/cru/UI-DEN-15279-1 Scripts: http://devapps.diality.us:8060/cru/UI-DEN-15279-5 ClousSync: http://devapps.diality.us:8060/cru/CLO...

Code Reviews are done:

Application: http://devapps.diality.us:8060/cru/UI-DEN-15279-1

Scripts: http://devapps.diality.us:8060/cru/UI-DEN-15279-5

ClousSync: http://devapps.diality.us:8060/cru/CLOUDSYNC-DEN-15279-1
The related build is in:

X:\Engineering\Denali\18-Software_Releases\DEN_UI\v0.6_P-BETA_V3\staging\2023-07-18T035448.785-0700_Release_v0.6.2-162-Passed