common

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-5963 updated the alarm table

Instead of "if the flag is TRUE", comment should say something like "if disinfect temperature has been reached".

Instead of "if the flag is TRUE", comment should say something like "if disinfect temperature has been reached".

fabs will indicate a leak even if the volume goes up. Is that what you want here?

fabs will indicate a leak even if the volume goes up. Is that what you want here?

Add else for s/w fault. Or maybe load cell driver or Reservoirs module should have a generic get weight function for a given reservoir.

Add else for s/w fault. Or maybe load cell driver or Reservoirs module should have a generic get weight function for a given reservoir.

Change to resEmpty.

Change to resEmpty.

Not a great name. Should be resFull or something like that.

Not a great name. Should be resFull or something like that.

Should be an else (or default if you turn this into a switch) that triggers a s/w fault (bad reservoir param).

Should be an else (or default if you turn this into a switch) that triggers a s/w fault (bad reservoir param).

There should already be an enum for reservoirs somewhere. Use that one.

There should already be an enum for reservoirs somewhere. Use that one.

Should drain pump be turned off?

Should drain pump be turned off?

Is ppiPressure being checked here or in global check I saw at top of exec? Since VPi is closed for much of this mode, the global check is probably not right.

Is ppiPressure being checked here or in global check I saw at top of exec? Since VPi is closed for much of this mode, the global check is probably not right.

Function name is confusing. Change to something like failHeatDisinfection(). Also, this state handler will return DG_HEAT_DISINFECT_STATE_DRAIN_R1 - overriding the complete state being set in your ...

Function name is confusing. Change to something like failHeatDisinfection(). Also, this state handler will return DG_HEAT_DISINFECT_STATE_DRAIN_R1 - overriding the complete state being set in your function.

Should return boolean. Should return FALSE and not request standby if we are not in heat disinfect mode.

Should return boolean. Should return FALSE and not request standby if we are not in heat disinfect mode.

Didn't Sunny say we need at least 25 PSI at inlet?

Didn't Sunny say we need at least 25 PSI at inlet?

I don't see that you're using this status type. Why not just remove it now?

I don't see that you're using this status type. Why not just remove it now?

I would avoid the \ and new line here. If comment won't align, put comment on line above with ///.

I would avoid the \ and new line here. If comment won't align, put comment on line above with ///.

Should this return a boolean? What if we're not in heat disinfect mode when this function is called? Should return FALSE then.

Should this return a boolean? What if we're not in heat disinfect mode when this function is called? Should return FALSE then.

Shouldn't these functions return a boolean? Then assign result to return value instead of always TRUE.

Shouldn't these functions return a boolean? Then assign result to return value instead of always TRUE.

A lot of these #includes are already in SystemCommMessages.h and so should probably be removed from this area as they are redundant.

A lot of these #includes are already in SystemCommMessages.h and so should probably be removed from this area as they are redundant.

Can you go ahead and move the rest of these to their respective module .h files and delete this header file from project?

Can you go ahead and move the rest of these to their respective module .h files and delete this header file from project?

Add TODO on this to restore condition later.

Add TODO on this to restore condition later.

We're making all comments start with a capital letter globally. I did HD. This is probably the branch that we should do same for DG.

We're making all comments start with a capital letter globally. I did HD. This is probably the branch that we should do same for DG.

In HD, AlarmDefs.h is always included via common.h which includes AlarmMgmt.h which includes AlarmDefs.h. DG should be same way so you shouldn't need to include it here.

In HD, AlarmDefs.h is always included via common.h which includes AlarmMgmt.h which includes AlarmDefs.h. DG should be same way so you shouldn't need to include it here.

This arrangement looks odd. Should be desired time / interval. You have double desired time / double interval. Why?

This arrangement looks odd. Should be desired time / interval. You have double desired time / double interval. Why?

DEN-5963 added cancellation path states for heat disinfect mode

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.