common

Clone Tools

Stats

Commits this week: 0
Total Committers: 18
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 22 Mar 2021
10:47 am

Quang Nguyen <qnguyen@diality.com>

DEN-7091: Added sample water complete state and removed test message

Options
    • -2
    • +3
    /HDDefs.h
    • -3
    • +0
    /MsgDefs.h
10:37 am

Sean Nash

If returning a result, should return type be something other than boolean? Maybe SELF_TEST_STATUS_T from Common.h?

If returning a result, should return type be something other than boolean? Maybe SELF_TEST_STATUS_T from Common.h?

10:34 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:33 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:33 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:33 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:32 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:32 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:32 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:30 am

qnguyen  (deleted user)

Done.

Done.

10:30 am

qnguyen  (deleted user)

Done.

Done.

10:30 am

qnguyen  (deleted user)

Done.

Done.

10:29 am

qnguyen  (deleted user)

Moved handlers to pre-treatment mode.

Moved handlers to pre-treatment mode.

10:29 am

qnguyen  (deleted user)

Moved handle to pre-treatment mode. Go to standby mode when sample water test failed.

Moved handle to pre-treatment mode. Go to standby mode when sample water test failed.

10:29 am

qnguyen  (deleted user)

Done.

Done.

10:20 am

Sean Nash

If DG somehow gets ahead of HD here, I worry we will get stuck. Consider second condition with "getDGSubMode() >= DG_FILL_MODE_STATE_BICARB_PUMP_CHECK". Same for states below.

If DG somehow gets ahead of HD here, I worry we will get stuck. Consider second condition with "getDGSubMode() >= DG_FILL_MODE_STATE_BICARB_PUMP_CHECK". Same for states below.

10:11 am

Sean Nash

When using build switches, convention is to put the normal code first. So use #ifndef and swap the statements below.

When using build switches, convention is to put the normal code first. So use #ifndef and swap the statements below.

10:09 am

qnguyen  (deleted user)

When the sample water result entered by the user, HD will command DG to end water sampling mode and go back to standby idle state.

When the sample water result entered by the user, HD will command DG to end water sampling mode and go back to standby idle state.

10:08 am

Dara Navaei

10:08 am

Dara Navaei

10:07 am

Sean Nash

Why is bad sample result handled here and good sample result handled in pre-treatment mode?

Why is bad sample result handled here and good sample result handled in pre-treatment mode?

10:05 am

Sean Nash

How will DG standby get back to idle state from flush idle state? Where does that happen?

How will DG standby get back to idle state from flush idle state? Where does that happen?

10:04 am

Sean Nash

Use set dialysate temp from treatment parameters for trimmer heater target temp. Add 2 degrees for primary heater target temp.

Use set dialysate temp from treatment parameters for trimmer heater target temp. Add 2 degrees for primary heater target temp.

9:58 am

Sean Nash

Add fault.

Add fault.

9:57 am

Sean Nash

Consider renaming this to sampleWaterResultEntered to clarify its purpose.

Consider renaming this to sampleWaterResultEntered to clarify its purpose.

Sunday 21 Mar 2021
7:40 pm

qnguyen  (deleted user)

Should we check here if calibration data is valid?

Should we check here if calibration data is valid?

5:18 pm

Dara Navaei

As a common practice, I use #pragma around the structs. Does that matter?

As a common practice, I use #pragma around the structs. Does that matter?

5:10 pm

Dara Navaei

I will use the older message IDs for other programs.

I will use the older message IDs for other programs.

5:10 pm

Dara Navaei

Because I used a different debugger and it updated the launch file. I think we should add this .gitignore.

Because I used a different debugger and it updated the launch file. I think we should add this .gitignore.

5:08 pm

Dara Navaei

Uncommented the code.

Uncommented the code.