common

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
There is only one state in this override message. It can be status or state (depending on message ID), but not both. Whichever it is, you are passing it to a function twice as if it is two differen...

There is only one state in this override message. It can be status or state (depending on message ID), but not both. Whichever it is, you are passing it to a function twice as if it is two different things. You need to revert back to having two override messages and two message handlers - one for status and one for state.

So you combined the published data into one message in the publish function above which is correct. But these overrides must be separate. You should only override one thing at a time, so overrides ...

So you combined the published data into one message in the publish function above which is correct. But these overrides must be separate. You should only override one thing at a time, so overrides were ok as it was before.

Need to add call to this function from task priority.

Need to add call to this function from task priority.

Addressed.

Addressed.

Addressed.

Addressed.

Comments shall start with capital letter.

Comments shall start with capital letter.

Replace a with a more meaningful variable name.

Replace a with a more meaningful variable name.

Align comment.

Align comment.

Align comment.

Align comment.

Add TODO or delete.

Add TODO or delete.

Replace logic with a temp parameter (call it whatever you like) and then use that parameter in the function call. This will make the code a lot more legible.

Replace logic with a temp parameter (call it whatever you like) and then use that parameter in the function call. This will make the code a lot more legible.

Why not using a union? Much more optimized for memory-limited devices.

Why not using a union? Much more optimized for memory-limited devices.

Where did these go?

Where did these go?

Remove "for" at end of @param sentence.

Remove "for" at end of @param sentence.

Remove "for" at end of @param sentence.

Remove "for" at end of @param sentence.

Why using structs instead of enums?

Why using structs instead of enums?

...operating temperatures between 5 degrees C and 95 degrees C.

...operating temperatures between 5 degrees C and 95 degrees C.

...operating temperatures between 5 degrees C and 95 degrees C.

...operating temperatures between 5 degrees C and 95 degrees C.

Why commented out?

Why commented out?

If both of these functions are using the same constant, why do we have two functions? Use just one (unless it is planned for them to inherit different constants down the road).

If both of these functions are using the same constant, why do we have two functions? Use just one (unless it is planned for them to inherit different constants down the road).

Why commented out?

Why commented out?

Spell out P in variable name (or use "Press" at least).

Spell out P in variable name (or use "Press" at least).

Did we want to mention "set" in the two variables' name?

Did we want to mention "set" in the two variables' name?

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Need to add state machine in this function. Call state handler functions from a switch statement.

Need to add state machine in this function. Call state handler functions from a switch statement.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Preferred architecture is to just set flag here and then let your state machine see the flag and change the state and command the fpga when it next executes.

Preferred architecture is to just set flag here and then let your state machine see the flag and change the state and command the fpga when it next executes.

Preferred architecture is to just set a request flag here and then let your state machine see the flag and change the state and command the FPGA action the next time it executes.

Preferred architecture is to just set a request flag here and then let your state machine see the flag and change the state and command the FPGA action the next time it executes.

getCurrentOperationMode() returns the current operation mode (standby, pre-treatment, treatment, post-treatment, etc.), not the sub-mode.

getCurrentOperationMode() returns the current operation mode (standby, pre-treatment, treatment, post-treatment, etc.), not the sub-mode.