common

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Merge branch 'staging' into develop

DEN-7605: Added sub-modes to HD standby mode.

Done.

Done.

This is just to check that everything above minimum we are about to start the heat disifnect mode. I added the max limit too.

This is just to check that everything above minimum we are about to start the heat disifnect mode. I added the max limit too.

I removed 2. If faster publish time is needed, it should be overridden via Dialin.

I removed 2. If faster publish time is needed, it should be overridden via Dialin.

Done.

Done.

Done.

Done.

This section has been uncommented.

This section has been uncommented.

Done.

Done.

I changed the functions.

I changed the functions.

Done.

Done.

This enum has been deleted.

This enum has been deleted.

This enum has been deleted.

This enum has been deleted.

That is tested in the start state.

That is tested in the start state.

Done.

Done.

I renamed the function. This part has been changed and the current state will not be overridden.

I renamed the function. This part has been changed and the current state will not be overridden.

The global check has been removed. PPi is checked here.

The global check has been removed. PPi is checked here.

It depends on where it is going. If it is the last drain, it turns off the drain pump.

It depends on where it is going. If it is the last drain, it turns off the drain pump.

This enum has been deleted.

This enum has been deleted.

This variable has been deleted.

This variable has been deleted.

This variable has been deleted.

This variable has been deleted.

Yes, the purpose is to check whether the level changes, either going up or down.

Yes, the purpose is to check whether the level changes, either going up or down.

Done.

Done.

DG-DEN-7568_DG Mode Flush
DG-DEN-7568_DG Mode Flush
DEN-7605: Updated clear immediate alarm properties for some alarms.

Dara Navaei Please refactor the name to cp1CurrentSetSpeed and cp2CurrentSetSpeed. Thank you!

Dara Navaei Please refactor the name to cp1CurrentSetSpeed and cp2CurrentSetSpeed. Thank you!

Union is not applicable in this case. Every field of this struct has a different value to be stored.

Union is not applicable in this case. Every field of this struct has a different value to be stored.

Both false and true cases are needed (for clear and trigger alarm). Recommend turning the if statement into a variable and pass in as parameter.

Both false and true cases are needed (for clear and trigger alarm). Recommend turning the if statement into a variable and pass in as parameter.

Updated clear immediate property on some alarms. Will add to staging.

Nice catch. Done.

Nice catch. Done.