common

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Need to remove this comment.

Need to remove this comment.

Need to remove this comment.

Need to remove this comment.

Same as comment from DialinFlow.c

Same as comment from DialinFlow.c

We can't have 3 calls to isPersistentAlarmTriggered() on same alarm. If the first call starts the timer and the second or third call is good, it will reset the timer to 0 again. Suggest creating a ...

We can't have 3 calls to isPersistentAlarmTriggered() on same alarm. If the first call starts the timer and the second or third call is good, it will reset the timer to 0 again.
Suggest creating a BOOL variable to have all three conditions or with each other and call isPersistentAlarmTriggered() only once.

initBloodPrime() is called every time we transition to blood prime sub-mode.

initBloodPrime() is called every time we transition to blood prime sub-mode.

Blood prime last motor count does not seem to get updated except in initBloodPrime(). Should it be updated continuously somewhere?

Blood prime last motor count does not seem to get updated except in initBloodPrime(). Should it be updated continuously somewhere?

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Fixed.

Fixed.

Fixed.

Fixed.

Copy and paste error. Fixed.

Copy and paste error. Fixed.

Same as above.

Same as above.

Why do we need to subtract from MAX_ALARM_VOLUME_LEVEL?

Why do we need to subtract from MAX_ALARM_VOLUME_LEVEL?

These functions need doxygen description.

These functions need doxygen description.

I agree, but sometimes feel it helps readability.

I agree, but sometimes feel it helps readability.

Yes, you are right. I will use fwcommon code.

Yes, you are right. I will use fwcommon code.

Fixed.

Fixed.

What declaration?

What declaration?

Dara to refactor the POST test for RTC vs. processor timer so that we expect 1000 ms of processor time after RTC second changes. He and I have discussed this needed change.

Dara to refactor the POST test for RTC vs. processor timer so that we expect 1000 ms of processor time after RTC second changes. He and I have discussed this needed change.

13 was temporary change for full travel test with Mike. I put it back to 11 for now.

13 was temporary change for full travel test with Mike. I put it back to 11 for now.

I don't have anything I can do in POST so I removed. There are some checks being done at all times and many checks happening in certain states.

I don't have anything I can do in POST so I removed. There are some checks being done at all times and many checks happening in certain states.

I think it is safer as is. TRUE = 1. If any other value, will be viewed as FALSE and check fails.

I think it is safer as is. TRUE = 1. If any other value, will be viewed as FALSE and check fails.