common

Clone Tools

Stats

Commits this week: 0
Total Committers: 18
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 29 Jul 2021
11:09 am

Sean Nash

Merge branch 'staging' into develop

Options
    • -5
    • +11
    /AlarmDefs.h
9:07 am

Dara Navaei

Done.

Done.

Wednesday 28 Jul 2021
8:54 pm

Dara Navaei

This is fixed in the latest commit.

This is fixed in the latest commit.

8:46 pm

Dara Navaei

Done.

Done.

8:45 pm

Dara Navaei

The default pump control mode is none.

The default pump control mode is none.

8:44 pm

Dara Navaei

Done.

Done.

8:09 pm

Dara Navaei

Done.

Done.

8:07 pm

Dara Navaei

Done.

Done.

8:06 pm

Dara Navaei

Done.

Done.

8:04 pm

Dara Navaei

8:04 pm

Dara Navaei

This structure was transferred DGDefs.h

This structure was transferred DGDefs.h

2:38 pm

Sean Nash

DEN-8886: Added msg to request DG POST result.

Options
    • -2
    • +2
    /MsgDefs.h
1:36 pm

Sean Nash

DEN-8886: Added messages to request UI version info.

Options
    • -1
    • +5
    /MsgDefs.h
11:55 am

Sean Nash

Merge branch 'staging' of ssh://dvm-linux02:7999/comm/common into staging

Options
    • -1
    • +1
    /AlarmDefs.h
11:54 am

Sean Nash

DEN-8886: Made all HD POST tests have HD fault property.

Options
    • -4
    • +4
    /AlarmDefs.h
10:36 am

Dara Navaei

DEN-9054 updated the alarm ID name

Options
    • -1
    • +1
    /AlarmDefs.h
Tuesday 27 Jul 2021
5:50 pm

Sean Nash

Where did this go?

Where did this go?

5:15 pm

Sean Nash

So these & operators are going to yield a zero or a non-zero number that will be different for each switch (not a boolean). I think your intent is for these switch data to be an enum. So, for examp...

So these & operators are going to yield a zero or a non-zero number that will be different for each switch (not a boolean). I think your intent is for these switch data to be an enum. So, for example, this one should be "... = ( ( fpgaRegister & CONCENTRATE_CAP_SWITCH_BIT_MASK ) != 0 ? OPEN : CLOSED );

5:13 pm

Sean Nash

Put test functions at bottom of module (after usual banner).

Put test functions at bottom of module (after usual banner).

5:04 pm

Sean Nash

I don't see this being initialized in init function.

I don't see this being initialized in init function.

4:16 pm

Sean Nash

I like to add a comment to right of system library includes explaining why they are needed (i.e. which math functions are you using in this module).

I like to add a comment to right of system library includes explaining why they are needed (i.e. which math functions are you using in this module).

3:53 pm

Sean Nash

First sizeof() should have U32 (same as above).

First sizeof() should have U32 (same as above).

3:53 pm

Sean Nash

The first sizeof() has ALARM_ID_T. You converted that param to a U32 (which is appropriate) and so you should have U32 in that sizeof().

The first sizeof() has ALARM_ID_T. You converted that param to a U32 (which is appropriate) and so you should have U32 in that sizeof().

3:48 pm

Sean Nash

I think the data are floats, so 0 should be 0.0.

I think the data are floats, so 0 should be 0.0.

1:43 pm

Quang Nguyen <qnguyen@diality.com>

DEN-8679: Added override message for battery remaining percent

Options
    • -0
    • +1
    /MsgDefs.h
11:11 am

qnguyen  (deleted user)

Sent events only for changed settings.

Sent events only for changed settings.

11:04 am

qnguyen  (deleted user)

Set UF volume initially to 0 and removed this variable and related function.

Set UF volume initially to 0 and removed this variable and related function.

11:01 am

qnguyen  (deleted user)

It is part of background task in the battery monitor exec function. The initial value is 0, we will wait here till we get status.

It is part of background task in the battery monitor exec function. The initial value is 0, we will wait here till we get status.

10:54 am

qnguyen  (deleted user)

Done. I prefer generally output description, so refactor is easier. Normally, a refactor will often make these variables in the doxygen comment obsolete (variable name change).

Done. I prefer generally output description, so refactor is easier. Normally, a refactor will often make these variables in the doxygen comment obsolete (variable name change).

10:49 am

qnguyen  (deleted user)

Dara Navaei Please take a look.

Dara Navaei Please take a look.