common

Clone Tools

Stats

Commits this week: 0
Total Committers: 18
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 04 Oct 2022
10:16 am

Dara Navaei

DEN-13834 added FPGA persistent alarms

Options
    • -3
    • +3
    /AlarmDefs.h
8:27 am

Michael Garthwaite and Tiffany Mejia

Monday 03 Oct 2022
4:14 pm

Sean Nash

I think battery pack status, battery pack remaining capacity and charger status would be in a separate message sent by a separate "publish" function, but the timing would just be whenever any of th...

I think battery pack status, battery pack remaining capacity and charger status would be in a separate message sent by a separate "publish" function, but the timing would just be whenever any of the 3 registers (or the 3rd of the 3 if they are always next to each other in enum in same order) has been read (call publish function from the cases where we read one of the 3 registers). If you publish after reading any of the 3, you could sometimes get broadcast 250ms apart. If you publish after reading the last of the 3 in a group (i.e. the status_1, remaining_capacity_1, charger_status_1), the spacing of the broadcast will depend on how many enums are between them.

3:19 pm

Dara Navaei

DEN-13834 pulled the latest remote changes

Options
    • -7
    • +7
    /AlarmDefs.h
2:07 pm

Dara Navaei

DEN-13834 removed the unused arterial/occlusion/venous pressure sensors

Options
    • -18
    • +18
    /AlarmDefs.h
2:04 pm

jishii  (deleted user)

10:58 am

wbracken  (deleted user)

BatteryStatusData is an input.

BatteryStatusData is an input.

10:48 am

wbracken  (deleted user)

fpgaPersistentAlarmGroup is an input.

fpgaPersistentAlarmGroup is an input.

10:44 am

wbracken  (deleted user)

Are all available ALARM_IDs being removed?

Are all available ALARM_IDs being removed?

10:26 am

Steve Jarpe

OK, I see what you wanted. I have a couple of questions: Is logging of the 3 values (remaining charge, battery status, charger status) in a separate message every 750 ms correct? If so, could that ...

OK, I see what you wanted. I have a couple of questions:
Is logging of the 3 values (remaining charge, battery status, charger status) in a separate message every 750 ms correct?
If so, could that be done by calling the publishBatteryStatusData function when the 3rd value (charger status) is read?

8:56 am

Behrouz NematiPour

Merge branch 'DEN-13965-UI-BN-S80' into develop

Options
    • -0
    • +36
    /HDDefs.h
8:52 am

Behrouz NematiPour

DEN-13939: IMP: Implementation of the the message [0xBA00]

- The message command parameter enum def.

Options
    • -4
    • +5
    /HDDefs.h
Sunday 02 Oct 2022
6:59 pm

Dara Navaei

DEN-13834 added HD FPGA persistent alarms

Options
    • -13
    • +13
    /AlarmDefs.h
Friday 30 Sep 2022
4:38 pm

Sean Nash

Restore alarm when done.

Restore alarm when done.

4:27 pm

Sean Nash

I think we should just be calling one function to do a single read at a time. If you try to read multiple times back-to-back, the bus reports busy and the read fails. I would keep call to getBatter...

I think we should just be calling one function to do a single read at a time. If you try to read multiple times back-to-back, the bus reports busy and the read fails. I would keep call to getBatteryManagementData() function with the large switch statement as it was with everything there and remove getBatteryStatusData() function altogether.

4:24 pm

Sean Nash

Keep multiple reads of remaining capacity and status in the switch as before.

Keep multiple reads of remaining capacity and status in the switch as before.

4:23 pm

Sean Nash

Keep read for battery charger status here before end of list.

Keep read for battery charger status here before end of list.

4:22 pm

Sean Nash

Dong fixed this.

Dong fixed this.

4:22 pm

Sean Nash

Need to save data to dataPtr so calling function gets the data.

Need to save data to dataPtr so calling function gets the data.

4:21 pm

Sean Nash

I think the enum from commit fbb6603 was fine as it was. I still think we should be doing only 1 read per 250ms interval and I think the one function with the large switch statement based on these ...

I think the enum from commit fbb6603 was fine as it was. I still think we should be doing only 1 read per 250ms interval and I think the one function with the large switch statement based on these enums was the way to achieve that - with the multiple status1..5 and remaining capacity1..5 enums spaced out to get them read more frequently.
And I think the individual cases for the higher frequency registers could just call the high frequency broadcast function whenever a new value is read for those registers. And so the slower broadcast could stay at end of list in that switch statement.

3:43 pm

Dara Navaei

DEN-13834 added conductivity sensors' persistent FPGA alarms

Options
    • -7
    • +7
    /AlarmDefs.h
3:27 pm

Darren Cox <darren_m@cox.net>

DEN-14000 merge to develop.

Options
    • -2
    • +2
    /AlarmDefs.h
    • -1
    • +1
    /HDDefs.h
    • -0
    • +4
    /MsgDefs.h
2:38 pm

wbracken  (deleted user)

Update function header.

Update function header.

2:10 pm

Dara Navaei

DEN-13834 updated the alarms table

Options
    • -3
    • +3
    /AlarmDefs.h
11:02 am

Steve Jarpe <sjarpe@diality.com>

DEN-14001-hd-battery-driver-update. added new message for battery status logging

Options
    • -0
    • +1
    /MsgDefs.h
9:00 am

Michael Garthwaite

Do we want this checked into staging?

Do we want this checked into staging?

Thursday 29 Sep 2022
5:17 pm

Sean Nash

These are defined in the Code Composer project for DG and HD firmware respectively. You can only have one defined and you must have one defined.

These are defined in the Code Composer project for DG and HD firmware respectively. You can only have one defined and you must have one defined.

5:06 pm

Sean Nash

What is the purpose of this "no event" event?

What is the purpose of this "no event" event?

5:06 pm

Sean Nash

What is the purpose of this "no event" event?

What is the purpose of this "no event" event?

5:04 pm

Sean Nash

No stop property for a high priority alarm? PRS 754 says dialysate temperature alarms are low priority. Temp too low = rank 902. Temp too high = rank 901.

No stop property for a high priority alarm?
PRS 754 says dialysate temperature alarms are low priority. Temp too low = rank 902. Temp too high = rank 901.