common

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Merged DEN-13834

BatteryStatusData is also an input

BatteryStatusData is also an input

DEN-13834 added alarms

Add 2 blank lines before test support banner.

Add 2 blank lines before test support banner.

Remove extra blank lines. Should only be 1 here.

Remove extra blank lines. Should only be 1 here.

Cases should be pulled back one indent (4 spaces) to align with others.

Cases should be pulled back one indent (4 spaces) to align with others.

Add blank line after declaration.

Add blank line after declaration.

Sort of. You will get something between the ms specified and 1 ms less because you don't know where you are in a given ms when you get your start time. Recommend changing this to 2 ms timeout.

Sort of. You will get something between the ms specified and 1 ms less because you don't know where you are in a given ms when you get your start time.
Recommend changing this to 2 ms timeout.

Why not checking payload length?

Why not checking payload length?

Keep blank line.

Keep blank line.

These FPGA registers are obsolete - h/w is no longer in our design. Need to continue to maintain register space since registers after these have not moved. You can think of these obsolete registers...

These FPGA registers are obsolete - h/w is no longer in our design. Need to continue to maintain register space since registers after these have not moved. You can think of these obsolete registers as "reserved" for future purpose.
Dara, I do think we could rename these register fields to something like Reserved1, Reserved2, ...

Monitor execs should be before operation modes exec.

Monitor execs should be before operation modes exec.

Why was blank line removed?

Why was blank line removed?

Align "=".

Align "=".

Add another blank line here.

Add another blank line here.

Idea is to re-purpose these (instead of adding new alarms to bottom of enum). We prefer not to collapse the table when an alarm ID goes obsolete so other alarm IDs do not change.

Idea is to re-purpose these (instead of adding new alarms to bottom of enum). We prefer not to collapse the table when an alarm ID goes obsolete so other alarm IDs do not change.

DEN-14001: Update battery driver.

Merge branch 'DEN-14001-hd-battery-driver-update' of ssh://dvm-linux02:7999/comm/common into DEN-14001-hd-battery-driver-update

DEN-14001: Update MsDefs.h

Does didTimeout support a 1ms timeout?

Does didTimeout support a 1ms timeout?

Merge branch 'DEN-13965-UI-BN-S80' into staging

What is the significance of (OBSOLETE)? Applies to several blocks.

What is the significance of (OBSOLETE)? Applies to several blocks.

DEN-13834 added FPGA persistent alarms

I think battery pack status, battery pack remaining capacity and charger status would be in a separate message sent by a separate "publish" function, but the timing would just be whenever any of th...

I think battery pack status, battery pack remaining capacity and charger status would be in a separate message sent by a separate "publish" function, but the timing would just be whenever any of the 3 registers (or the 3rd of the 3 if they are always next to each other in enum in same order) has been read (call publish function from the cases where we read one of the 3 registers). If you publish after reading any of the 3, you could sometimes get broadcast 250ms apart. If you publish after reading the last of the 3 in a group (i.e. the status_1, remaining_capacity_1, charger_status_1), the spacing of the broadcast will depend on how many enums are between them.

DEN-13834 pulled the latest remote changes

DEN-13834 removed the unused arterial/occlusion/venous pressure sensors

BatteryStatusData is an input.

BatteryStatusData is an input.