Activity common/

2:04 pm

jtaylor (deleted user) and Sean Nash

More
HD-DEN-14252-1
finished reviewing

1:43 pm

jtaylor (deleted user)

More
Re: HD-DEN-14252-1
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH.

4:38 pm

Sean Nash

More
Re: HD-DEN-14252-1
replied to jtaylor (deleted user)

Created a #define for magic number. Because running pumps in open loop mode (because we're priming and not necessarily any fluid in line to measure flow with) and pumps have different methods of de...

Created a #define for magic number.
Because running pumps in open loop mode (because we're priming and not necessarily any fluid in line to measure flow with) and pumps have different methods of determining PWM duty cycle from a given flow rate, DPo pumps target flow rate needed to be set lower to match the duty cycle with DPi pump.

10:55 am

Dara Navaei

More
Re: HD-DEN-14344-3
commented on review

Please add comment.

9:37 am

jtaylor (deleted user)

More
Re: HD-DEN-14252-1
commented on review

It seems strange to add a magic number here, from a defined constant. I'd assume (guess) the relation between 300->225 is maintaining a delta P along the flow path (or across the membrane?), but it...

It seems strange to add a magic number here, from a defined constant.
I'd assume (guess) the relation between 300->225 is maintaining a delta P along the flow path (or across the membrane?), but it might be worth spelling out, at the top with the defines, or as a macro function of the input flow rate.

3:18 pm

wbracken (deleted user)

More
Re: DG-DEN-14316-1
commented on review

Alignment

3:13 pm

wbracken (deleted user)

More
Re: DG-DEN-14316-1
commented on review

Remove

3:10 pm

wbracken (deleted user)

More
Re: DG-DEN-14316-1
commented on review

Remove.

3:10 pm

wbracken (deleted user)

More
Re: DG-DEN-14316-1
commented on review

Think the deleted def is correct.

3:09 pm

wbracken (deleted user)

More
Re: DG-DEN-14316-1
commented on review

Alignment

3:08 pm

wbracken (deleted user)

More
Re: DG-DEN-14316-1
commented on review

Remove.

3:08 pm

wbracken (deleted user)

More
Re: DG-DEN-14316-1
commented on review

Alignment

2:55 pm

wbracken (deleted user)

More
Re: DG-DEN-14316-1
commented on review

Alignment

2:53 pm

wbracken (deleted user)

More
Re: DG-DEN-14316-1
commented on review

Remove.

2:50 pm

wbracken (deleted user)

More
Re: DG-DEN-14316-1
commented on review

Remove blank lines and commented out ode.

10:31 am

jtaylor (deleted user)

More
HD-DEN-14307-1
resumed reviewing

4:17 pm

wbracken (deleted user)

More
Re: HD-DEN-14344-3
commented on review

Alignment throughout the file. However, this file is auto-generated by HalCoGen.

4:05 pm

wbracken (deleted user)

RESOLVED IN CODE WALKTHROUGH.

2:02 pm

Michael Garthwaite

More
Re: HD-DEN-14344-3
replied to wbracken (deleted user)

HalCoGen is currently editing het.h, het.c, sys_link.cmd, HD.dil, and sys_selftest.c in this branch. Any and all the changes within those files are autogenerated from HaloCoGen.

1:53 pm