common

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Created a #define for magic number. Because running pumps in open loop mode (because we're priming and not necessarily any fluid in line to measure flow with) and pumps have different methods of de...

Created a #define for magic number.
Because running pumps in open loop mode (because we're priming and not necessarily any fluid in line to measure flow with) and pumps have different methods of determining PWM duty cycle from a given flow rate, DPo pumps target flow rate needed to be set lower to match the duty cycle with DPi pump.

Please add comment.

Please add comment.

It seems strange to add a magic number here, from a defined constant. I'd assume (guess) the relation between 300->225 is maintaining a delta P along the flow path (or across the membrane?), but it...

It seems strange to add a magic number here, from a defined constant.
I'd assume (guess) the relation between 300->225 is maintaining a delta P along the flow path (or across the membrane?), but it might be worth spelling out, at the top with the defines, or as a macro function of the input flow rate.

Alignment

Alignment

Remove

Remove

Remove.

Remove.

Think the deleted def is correct.

Think the deleted def is correct.

Alignment

Alignment

Remove.

Remove.

Alignment

Alignment

Alignment

Alignment

Remove.

Remove.

Remove blank lines and commented out ode.

Remove blank lines and commented out ode.

Alignment throughout the file. However, this file is auto-generated by HalCoGen.

Alignment throughout the file. However, this file is auto-generated by HalCoGen.

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

HalCoGen is currently editing het.h, het.c, sys_link.cmd, HD.dil, and sys_selftest.c in this branch. Any and all the changes within those files are autogenerated from HaloCoGen.

HalCoGen is currently editing het.h, het.c, sys_link.cmd, HD.dil, and sys_selftest.c in this branch. Any and all the changes within those files are autogenerated from HaloCoGen.

Is this an output file from HalCoGen? If so seems like one shouldn't need to modify this file directly.

Is this an output file from HalCoGen? If so seems like one shouldn't need to modify this file directly.

AirPump.h should be before AirTrap.h.

AirPump.h should be before AirTrap.h.

Function removed. Thanks!

Function removed. Thanks!

Function Removed. Thanks!

Function Removed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Function removed. Thanks!

Function removed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!