common

AlarmDefs.h

Clone Tools

Stats

Commits this week: 0
Total Committers: 14
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 17 Mar 2021
2:48 pm

qnguyen  (deleted user)

Why is UF off state goes back to UF running state right away? Should we remove this state then?

Why is UF off state goes back to UF running state right away? Should we remove this state then?

2:45 pm

qnguyen  (deleted user)

Suggest combining into one line.

Suggest combining into one line.

2:44 pm

qnguyen  (deleted user)

Need doxygen description for new functions.

Need doxygen description for new functions.

10:14 am

qnguyen  (deleted user)

Renamed to consumableInstallConfirmed for less confusing.

Renamed to consumableInstallConfirmed for less confusing.

Monday 15 Mar 2021
9:29 am

qnguyen  (deleted user)

It was used to calculated how much to fill the first reservoir in mode pretreatment module, but not anymore. Removed.

It was used to calculated how much to fill the first reservoir in mode pretreatment module, but not anymore.
Removed.

9:26 am

qnguyen  (deleted user)

Since the UI follows HD states and not DG, HD has to follow these next 3 states of DG. This allows UI to tick off the checklist.

Since the UI follows HD states and not DG, HD has to follow these next 3 states of DG. This allows UI to tick off the checklist.

9:22 am

qnguyen  (deleted user)

Fixed.

Fixed.

9:20 am

qnguyen  (deleted user)

It is called from task general.

It is called from task general.

Sunday 14 Mar 2021
8:09 pm

Sean Nash

Shouldn't there be a few of these disinfect times? R1, R2, etc...

Shouldn't there be a few of these disinfect times? R1, R2, etc...

7:51 pm

Sean Nash

Delete blank line.

Delete blank line.

7:51 pm

Sean Nash

Delete blank line.

Delete blank line.

7:50 pm

Sean Nash

If we don't need this check anymore, just delete it.

If we don't need this check anymore, just delete it.

7:49 pm

Sean Nash

If we're not doing all of this commented out monitoring, just delete it.

If we're not doing all of this commented out monitoring, just delete it.

7:45 pm

Sean Nash

Why commented out here? If you don't want this disabled, comment the build switch out in DGCommon.h.

Why commented out here? If you don't want this disabled, comment the build switch out in DGCommon.h.

7:43 pm

Sean Nash

Why banner deleted?

Why banner deleted?

7:43 pm

Sean Nash

Why is this banner deleted?

Why is this banner deleted?

7:42 pm

Sean Nash

Why commented out?

Why commented out?

7:41 pm

Sean Nash

Why remove this check?

Why remove this check?

7:41 pm

Sean Nash

What is the purpose of this? If there is a problem, shouldn't there be an alarm/fault? Seems like current mode may not be aware that the drain pump has been stopped here.

What is the purpose of this? If there is a problem, shouldn't there be an alarm/fault? Seems like current mode may not be aware that the drain pump has been stopped here.

7:38 pm

Sean Nash

Not sure what's happening here. Restore this as it was.

Not sure what's happening here. Restore this as it was.

7:37 pm

Sean Nash

Why is this check commented out? Even if our RPM conversion is not great, we still need to be able to distinguish between off and on. Set a threshold and keep this check.

Why is this check commented out? Even if our RPM conversion is not great, we still need to be able to distinguish between off and on. Set a threshold and keep this check.

7:35 pm

Sean Nash

Why is all of this commented out? Just build switch the checks that aren't working and leave everything else alone.

Why is all of this commented out? Just build switch the checks that aren't working and leave everything else alone.

7:34 pm

Sean Nash

If this check isn't working, make a build switch to exclude them. What is the plan for this check? Can we even do it? If not, remove.

If this check isn't working, make a build switch to exclude them. What is the plan for this check? Can we even do it? If not, remove.

7:19 pm

Sean Nash

Where is this used? Does it need to be public?

Where is this used? Does it need to be public?

7:17 pm

Sean Nash

Does HD have to follow these next 3 states of DG? Or could it just wait for DG to get to the dialysate productions state?

Does HD have to follow these next 3 states of DG? Or could it just wait for DG to get to the dialysate productions state?

7:16 pm

Sean Nash

Does this flag indicate install requested or install confirmed?

Does this flag indicate install requested or install confirmed?

7:09 pm

Sean Nash

From where is this function called?

From where is this function called?

6:58 pm

Sean Nash

First condition should be in parenthesis too.

First condition should be in parenthesis too.

Saturday 13 Mar 2021
9:25 pm

qnguyen  (deleted user)

Fixed.

Fixed.

9:25 pm

qnguyen  (deleted user)

Fixed.

Fixed.