common

AlarmDefs.h

Clone Tools

Stats

Commits this week: 0
Total Committers: 14
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 18 May 2021
10:42 am

qnguyen  (deleted user)

This will be addressed in DEN-8103.

This will be addressed in DEN-8103.

10:40 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:40 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:39 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:09 am

qnguyen  (deleted user)

HD-DEN-8103_DG HD Dev Alarm Design
HD-DEN-8103_DG HD Dev Alarm Design
Tuesday 11 May 2021
2:54 pm

Sean Nash

Agreed. This is for me to add a check for this error. Will remove comment when I'm done.

Agreed. This is for me to add a check for this error. Will remove comment when I'm done.

2:54 pm

Sean Nash

Is this still an issue?

Is this still an issue?

2:53 pm

Sean Nash

Agreed. This is for me to add a check for this error. I'll remove comment when I'm done.

Agreed. This is for me to add a check for this error. I'll remove comment when I'm done.

2:53 pm

Sean Nash

Is this still an issue?

Is this still an issue?

Friday 07 May 2021
12:07 am

qnguyen  (deleted user)

Need to remove this comment.

Need to remove this comment.

12:07 am

qnguyen  (deleted user)

Need to remove this comment.

Need to remove this comment.

12:06 am

qnguyen  (deleted user)

Same as comment from DialinFlow.c

Same as comment from DialinFlow.c

12:06 am

qnguyen  (deleted user)

We can't have 3 calls to isPersistentAlarmTriggered() on same alarm. If the first call starts the timer and the second or third call is good, it will reset the timer to 0 again. Suggest creating a ...

We can't have 3 calls to isPersistentAlarmTriggered() on same alarm. If the first call starts the timer and the second or third call is good, it will reset the timer to 0 again.
Suggest creating a BOOL variable to have all three conditions or with each other and call isPersistentAlarmTriggered() only once.

Thursday 06 May 2021
10:27 am

Sean Nash

initBloodPrime() is called every time we transition to blood prime sub-mode.

initBloodPrime() is called every time we transition to blood prime sub-mode.

Wednesday 05 May 2021
7:57 pm

qnguyen  (deleted user)

Blood prime last motor count does not seem to get updated except in initBloodPrime(). Should it be updated continuously somewhere?

Blood prime last motor count does not seem to get updated except in initBloodPrime(). Should it be updated continuously somewhere?

Tuesday 04 May 2021
10:38 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:37 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:37 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:37 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:36 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:36 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:32 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:32 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:32 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:31 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Monday 03 May 2021
11:40 am

Sean Nash

Fixed.

Fixed.

11:38 am

Sean Nash

Fixed.

Fixed.

11:37 am

Sean Nash

Copy and paste error. Fixed.

Copy and paste error. Fixed.

10:47 am

qnguyen  (deleted user)

Same as above.

Same as above.

10:46 am

qnguyen  (deleted user)

Why do we need to subtract from MAX_ALARM_VOLUME_LEVEL?

Why do we need to subtract from MAX_ALARM_VOLUME_LEVEL?