common

AlarmDefs.h

Clone Tools

Stats

Commits this week: 0
Total Committers: 14
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 30 Dec 2021
10:00 am

Dara Navaei

Done.

Done.

9:55 am

Sean Nash

Recommend moving this rate to be with the others above.

Recommend moving this rate to be with the others above.

9:52 am

Sean Nash

STEADY_VOLUME_COUNT_SEC is a number of seconds of stability indicating volume is steady. This only works because sampling time above is once per second. If somebody changes the sampling time, this ...

STEADY_VOLUME_COUNT_SEC is a number of seconds of stability indicating volume is steady. This only works because sampling time above is once per second. If somebody changes the sampling time, this condition will not be right.

9:49 am

Sean Nash

Make 0.5 a #define.

Make 0.5 a #define.

9:43 am

Sean Nash

Can we please use available alarm IDs above before adding a new one?

Can we please use available alarm IDs above before adding a new one?

Monday 13 Dec 2021
6:19 pm

hnguyen  (deleted user)

Yes, we could use a single variable as the start time in all the pre-treatment states

Yes, we could use a single variable as the start time in all the pre-treatment states

5:31 pm

hnguyen  (deleted user)

Replaced "loadcellSteadyVolumeStartTime" with "steadyVolumeSamplingStartTime"

Replaced "loadcellSteadyVolumeStartTime" with "steadyVolumeSamplingStartTime"

5:13 pm

hnguyen  (deleted user)

Done

Done

5:09 pm

hnguyen  (deleted user)

Done

Done

5:08 pm

hnguyen  (deleted user)

No, loadcellSteadyVolumeStartTime was last set when the primeDialysateDialyzerTimeLimit has just expired.

No, loadcellSteadyVolumeStartTime was last set when the primeDialysateDialyzerTimeLimit has just expired.

4:52 pm

hnguyen  (deleted user)

Done

Done

4:47 pm

hnguyen  (deleted user)

Done

Done

4:47 pm

hnguyen  (deleted user)

Done.

Done.

4:13 pm

Sean Nash

This start time probably needs a new name to better describe what it's doing.

This start time probably needs a new name to better describe what it's doing.

4:10 pm

Sean Nash

Recommend just setting up pumps and valves in this function rather than calling another function.

Recommend just setting up pumps and valves in this function rather than calling another function.

4:01 pm

Sean Nash

Add blank line between declarations and code.

Add blank line between declarations and code.

3:00 pm

Sean Nash

This start time was last set in setup function - quite some time ago. So this will have immediately timed out the first time we get here. I think this still works though.

This start time was last set in setup function - quite some time ago. So this will have immediately timed out the first time we get here. I think this still works though.

2:56 pm

Sean Nash

If skipping priming, would we even get here?

If skipping priming, would we even get here?

2:54 pm

Sean Nash

Please put declarations at top of scope (i.e. just below the '{' above).

Please put declarations at top of scope (i.e. just below the '{' above).

1:50 pm

hnguyen  (deleted user)

Fixed.

Fixed.

1:49 pm

hnguyen  (deleted user)

Replaced by primeDialysateDialyzerTimeLimit because this variable is dynamic and based on the type of dialyzer.

Replaced by primeDialysateDialyzerTimeLimit because this variable is dynamic and based on the type of dialyzer.

11:33 am

Sean Nash

Add blank line between these two lines.

Add blank line between these two lines.

11:32 am

Sean Nash

Add blank line between these lines.

Add blank line between these lines.

11:29 am

Sean Nash

Do we need separate start time variables? These are not used at same time - consider consolidating into a single variable.

Do we need separate start time variables? These are not used at same time - consider consolidating into a single variable.

11:24 am

Sean Nash

Should be 120 mL divided by 300 mL/min times 60 sec/min = 24 seconds.

Should be 120 mL divided by 300 mL/min times 60 sec/min = 24 seconds.

11:16 am

Sean Nash

Why is this commented out?

Why is this commented out?

Thursday 02 Dec 2021
10:44 am

hnguyen  (deleted user)

Updated this comment to "Currently, we use 50.0 mL for testing. Remove this comment and replace 50.0 with 10.0 before merge to develop branch"

Updated this comment to
"Currently, we use 50.0 mL for testing. Remove this comment and replace 50.0 with 10.0 before merge to develop branch"

10:38 am

hnguyen  (deleted user)

Fixed.

Fixed.

10:32 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:32 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.