common

HDDefs.h

Clone Tools

Stats

Commits this week: 0
Total Committers: 13
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 11 Oct 2022
3:49 pm

Darren Cox <darren_m@cox.net>

DEN-14000 Moved Confirm Request defines to HDDefs.

Options
    • -1
    • +12
    /HDDefs.h
Monday 10 Oct 2022
1:13 pm

Behrouz NematiPour

12:54 pm

Darren Cox <darren_m@cox.net>

DEN-14000 Fix merge issue of doubled enum definitions.

Options
    • -36
    • +0
    /HDDefs.h
12:49 pm

Darren Cox <darren_m@cox.net>

Merge branch 'DEN-14000-sw_dev_sprint_80_darren' into develop

Options
    • -0
    • +29
    /HDDefs.h
  2. … 1 more file in changeset.
12:43 pm

Darren Cox

Updated to define, added comment.

Updated to define, added comment.

12:41 pm

Darren Cox

Updated.

Updated.

12:40 pm

Darren Cox

This enum is HD to UI only. Updated comments.

This enum is HD to UI only. Updated comments.

12:40 pm

Darren Cox <darren_m@cox.net>

DEN-14000 Code review comments updates.

Options
    • -2
    • +2
    /HDDefs.h
  2. … 1 more file in changeset.
11:00 am

Darren Cox

Rotor and motor turn in opposite directions. This ensures true check of motor and rotor speed, regardless of direction. Also, measMotorSpeed is absolute value in this function. Direction check is d...

Rotor and motor turn in opposite directions. This ensures true check of motor and rotor speed, regardless of direction. Also, measMotorSpeed is absolute value in this function. Direction check is done in a different function.

10:59 am

Darren Cox

Rotor and motor turn in opposite directions. This ensures true check of motor and rotor speed, regardless of direction. Also, measMotorSpeed is absolute value in this function. Direction check is d...

Rotor and motor turn in opposite directions. This ensures true check of motor and rotor speed, regardless of direction. Also, measMotorSpeed is absolute value in this function. Direction check is done in a different function.

10:59 am

Darren Cox

Rotor and motor turn in opposite directions. This ensures true check of motor and rotor speed, regardless of direction. Also, measMotorSpeed is absolute value in this function. Direction check is d...

Rotor and motor turn in opposite directions. This ensures true check of motor and rotor speed, regardless of direction. Also, measMotorSpeed is absolute value in this function. Direction check is done in a different function.

10:37 am

Darren Cox

Updated.

Updated.

10:36 am

Darren Cox

Updated.

Updated.

10:36 am

Darren Cox

Done.

Done.

10:36 am

Darren Cox

Updated.

Updated.

10:35 am

Darren Cox

Comment removed, Ack kept.

Comment removed, Ack kept.

10:35 am

Darren Cox

done.

done.

10:34 am

Darren Cox

updated to use pointer.

updated to use pointer.

Friday 07 Oct 2022
10:50 am

Sean Nash

Convention is to put spaces around operators like = and <.

Convention is to put spaces around operators like = and <.

10:50 am

Sean Nash

Convention is to put spaces around operators like = and <.

Convention is to put spaces around operators like = and <.

10:48 am

Sean Nash

request_id is an enum, not a U32. Copy enum to a local U32, then memcpy the local U32. Probably same for other params below - please check.

request_id is an enum, not a U32. Copy enum to a local U32, then memcpy the local U32. Probably same for other params below - please check.

10:35 am

Sean Nash

I think getting here would maybe indicate flush/disinfect ended naturally or faulted out while waiting for confirmation. I think appropriate thing to do is to send a reject back to UI? No alarm.

I think getting here would maybe indicate flush/disinfect ended naturally or faulted out while waiting for confirmation. I think appropriate thing to do is to send a reject back to UI? No alarm.

10:29 am

Sean Nash

Should add a break from loop here.

Should add a break from loop here.

10:25 am

Sean Nash

Convention is to ack when receiving one-shot (not broadcast) messages like this.

Convention is to ack when receiving one-shot (not broadcast) messages like this.

10:21 am

Sean Nash

Should break out of loop here I think.

Should break out of loop here I think.

10:19 am

Sean Nash

This works, but convention has been to use a local byte ptr and increment between param memcpy calls (see other message handlers).

This works, but convention has been to use a local byte ptr and increment between param memcpy calls (see other message handlers).

10:12 am

Sean Nash

Somewhere around line 450 there is a separator between normal and Dialin test support functions. These new functions are normal so should be above that separator. Looks like there's a few more norm...

Somewhere around line 450 there is a separator between normal and Dialin test support functions. These new functions are normal so should be above that separator. Looks like there's a few more normal functions down here too that should be moved.

10:04 am

Sean Nash

Change to "0 == disinfectCancelReqID"

Change to "0 == disinfectCancelReqID"

10:02 am

Sean Nash

Why absolute value?

Why absolute value?

9:59 am

Sean Nash

Why absolute? If can't handle negative speeds, maybe should floor at zero instead?

Why absolute? If can't handle negative speeds, maybe should floor at zero instead?