dd-firmware / firmware / App

Controllers

Clone Tools

Stats

Commits this week: 20
Total Committers: 12
Last Commit: 15:31
Commits this week: 20

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
50 mins ago

Vinayakam Mani

Done.

Done.

50 mins ago

Vinayakam Mani

Done

Done

51 mins ago

Vinayakam Mani

Since trimmer heater is enabled, no need of temp compensation. only for testing purposes, temp compensation is needed. Hence by default, temp compensation is disabled.

Since trimmer heater is enabled, no need of temp compensation. only for testing purposes, temp compensation is needed. Hence by default, temp compensation is disabled.

52 mins ago

Vinayakam Mani

For spent chamber fill, we don't know how low the liquid level is ( in Chamber H) and hence decided not to turn on the trimmer heater for safety reasons. For bicarb fill, the dry bicart code should...

For spent chamber fill, we don't know how low the liquid level is ( in Chamber H) and hence decided not to turn on the trimmer heater for safety reasons. For bicarb fill, the dry bicart code should cover the actuators status. the current bicarb chamber fill code here should be updated with the newly implemented dry bi cart code changes.

58 mins ago

Vinayakam Mani

LDT-1473 code review comments

Options
    • -14
    • +14
    ./BalancingChamber.c
    • -1
    • +1
    ./BalancingChamber.h
    • -12
    • +1
    ./ConcentratePumps.c
4 hrs ago

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./PermeateTank.c
    • -2
    • +2
    ./RinsePump.c
    • -2
    • +2
    ./Valves.c
    • -1
    • +1
    ./Valves.h
  5. … 5 more files in changeset.
4 hrs ago

Raghu Kallala

4 hrs ago

Sean Nash , Vinayakam Mani and Michael Garthwaite

6 hrs ago

Vendor - TEL - Sameer Poyil

Fixed it

Fixed it

6 hrs ago

Raghu Kallala

LDT-3343 added condition for DD to wait for FP to start preGen

Options
    • -2
    • +2
    ./RinsePump.c
  2. … 1 more file in changeset.
10 hrs ago

Raghu Kallala

LDT-3343 updated function header

Options
    • -2
    • +1
    ./Valves.c
10 hrs ago

Raghu Kallala

Updated

Updated

10 hrs ago

Raghu Kallala

Fixed

Fixed

Tuesday 03 Feb
5:23 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

5:17 pm

Sean Nash

It is your comment, so please resolve it.

It is your comment, so please resolve it.

5:02 pm

Vendor - TEL - Sameer Poyil

This function also not using u32ArrayOverride()

This function also not using u32ArrayOverride()

5:01 pm

Vendor - TEL - Sameer Poyil

is it possible to use the function u32ArrayOverride() here ?

is it possible to use the function u32ArrayOverride() here ?

4:48 pm

Sean Nash

Are we sure about the reversing of states here? If we had this backward, I would think the Systems team would have had a much bigger complaint. The description of their issue suggests that the 8 BC...

Are we sure about the reversing of states here? If we had this backward, I would think the Systems team would have had a much bigger complaint.
The description of their issue suggests that the 8 BC valves were correctly commanded to requested state except for the one they separately commanded earlier.
If we had this backward, I would think they would have said that all 8 valves did the wrong thing.

4:41 pm

Sean Nash

I don't think mask or pos require initialization either.

I don't think mask or pos require initialization either.

4:38 pm

Sean Nash

I don't think valve needs to be initialized here. The for loop initializes it.

I don't think valve needs to be initialized here. The for loop initializes it.

3:48 pm

Vendor - TEL - Jashwant Gantyada

Merged LDT-2030 and resolved the conflicts

Options
    • -8
    • +8
    ./BalancingChamber.c
    • -3
    • +4
    ./Valves.c
  3. … 5 more files in changeset.
3:12 pm

Vendor - TEL - Sameer Poyil

It is replied by Vinay , there is no need to maintain two different rpm. so we can close this.

It is replied by Vinay , there is no need to maintain two different rpm. so we can close this.

3:09 pm

Vendor - TEL - Sameer Poyil

LDT-2004-4 drybicart updates

Options
    • -5
    • +15
    ./DryBiCart.c
  2. … 1 more file in changeset.
3:00 pm

Sean Nash

For these functions that set specific valves, we should specify which (e.g. recovery valves or balancing chamber valves, or ...).

For these functions that set specific valves, we should specify which (e.g. recovery valves or balancing chamber valves, or ...).

2:59 pm

Sean Nash

Remove blank line.

Remove blank line.

2:21 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3222_Command to override all balancing chamber valves states should be the same priority as setting individual valve state overrides
LEAHI-DD-FIRMWARE-LDT-3222_Command to override all balancing chamber valves states should be the same priority as setting individual valve state overrides
2:19 pm

Vendor - TEL - Arpita Srivastava

LDT-3222: Updated variable initialization for the function testBCValveStatesOverride

Options
    • -5
    • +8
    ./Valves.c
2:11 pm

Vendor - TEL - Sameer Poyil

LDT-2004-3 dry bicart feature update

Options
    • -9
    • +8
    ./DryBiCart.c
2:04 pm

Vendor - TEL - Sameer Poyil

It will be fixed in Balancing chamber re-implementation

It will be fixed in Balancing chamber re-implementation

2:00 pm

Vendor - TEL - Arpita Srivastava

LDT-3222: Updated function testBCValveStatesOverride to update override data

Options
    • -5
    • +22
    ./Valves.c
    • -0
    • +1
    ./Valves.h