Activity dd-firmware/firmware/App/Services

10:29 am

Dara Navaei

More
7d963ca
changed 3 files
LDT-2977-iofp-update, LDT-2998-update-dialin-to-support-any-b1 and 2 more

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -2
- +2
./FpgaDD.c
- History
- Source
- Diff
./FpgaDD.c
- -2
- +2
./FpgaDD.h
- History
- Source
- Diff
./FpgaDD.h
… 1 more file in changeset.

10:19 am

Vendor - TEL - Sameer Poyil

marking it as resolved since it is temporary driver

11:51 am

Vendor - TEL - Sameer Poyil

As per Sean's comment mark it as resolved

11:48 am

Vendor - TEL - Sameer Poyil

marking it as resolved since this is a temporary driver

11:48 am

Vendor - TEL - Sameer Poyil

I am marking it as resolved since it is temporary driver

11:45 am

Its like we need to compile the safe library and include it. But if we are using only memcpy and memset, memcmp and static code analyzer check the destination buffer size , I am marking it as resolved

2:27 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-2004-3
commented on review

This function has an output.

2:26 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-2004-3
commented on review

Remove extra blank line.

1:45 pm

Vinayakam Mani

More
b4040c8
changed 4 files
develop

LDT-2004 fixing merge issues

- -0
- +3
./Messaging.c
- History
- Source
- Diff
./Messaging.c
… 3 more files in changeset.

11:11 am

Sean Nash

More
LEAHI-DD-FIRMWARE-LDT-1773-1
finished reviewing

11:02 am

Vinayakam Mani

More
43332b2
changed 5 files
develop

LDT-2004 merge into develop

- -0
- +5
./Messaging.c
- History
- Source
- Diff
./Messaging.c
… 4 more files in changeset.

10:40 am

Raghu Kallala

More
f4a8565
changed 34 files
develop

Merged latest staging into develop

- -11
- +28
./FpgaDD.c
- History
- Source
- Diff
./FpgaDD.c
- -3
- +2
./FpgaDD.h
- History
- Source
- Diff
./FpgaDD.h
- -6
- +6
./Messaging.c
- History
- Source
- Diff
./Messaging.c
- -38
- +171
./TDInterface.c
- History
- Source
- Diff
./TDInterface.c
- -2
- +4
./TDInterface.h
- History
- Source
- Diff
./TDInterface.h
… 29 more files in changeset.

9:22 am

Vendor - TEL - Sameer Poyil and Sean Nash

More
LEAHI-DD-FIRMWARE-LDT-2030-2
finished reviewing

9:22 am

Michael Garthwaite

More
39db733
changed 2 files
LDT-1773-dd-valve-pwm

LDT-1773: code review comments

- -1
- +0
./FpgaDD.h
- History
- Source
- Diff
./FpgaDD.h
… 1 more file in changeset.

9:17 am

Michael Garthwaite

More
a85769a
changed 2 files
LDT-1773-dd-valve-pwm

Merge branch 'staging_alpha' into LDT-1773-dd-valve-pwm

- -10
- +63
./FpgaDD.c
- History
- Source
- Diff
./FpgaDD.c
- -0
- +2
./FpgaDD.h
- History
- Source
- Diff
./FpgaDD.h

9:15 am

Michael Garthwaite

fixed. thanks!

9:15 am

Michael Garthwaite

fixed. thanks!

8:23 am

Dara Navaei

More
LEAHI-DD-FIRMWARE-LDT-618-3
finished reviewing

5:41 pm

Varshini Nagabooshanam <ven.vnagabooshanam@diality.com>

More
b83b525
changed 10 files
develop

Merge LDT-618-dd-add-ability-to-override-fixes

- -6
- +6
./Messaging.c
- History
- Source
- Diff
./Messaging.c
… 9 more files in changeset.

2:00 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-2004-3
commented on review

Is this temporary? If so, put a TODO to remove later.

1:59 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-2004-3
commented on review

Remove extra spaces between { and msg name.

1:58 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-2004-3
commented on review

Is this always needed or is it only needed in one or more specific modes (i.e. gen dialysate mode)? If only needed in specific modes, I think this should be called from those modes (similar to BC e...

Is this always needed or is it only needed in one or more specific modes (i.e. gen dialysate mode)? If only needed in specific modes, I think this should be called from those modes (similar to BC exec).

1:56 pm