dd-firmware / firmware

App

Clone Tools

Stats

Commits this week: 41
Total Committers: 14
Last Commit: 20:06
Commits this week: 41

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
40 mins ago

Vendor - TEL - Sameer Poyil

LDT-2004-3 Limits execution to one active dry bicart state machine at any given time

Options
    • -15
    • +148
    ./Controllers/DryBiCart.c
5 hrs ago

Vinayakam Mani

Done.

Done.

5 hrs ago

Vinayakam Mani

Done

Done

5 hrs ago

Vinayakam Mani

Since trimmer heater is enabled, no need of temp compensation. only for testing purposes, temp compensation is needed. Hence by default, temp compensation is disabled.

Since trimmer heater is enabled, no need of temp compensation. only for testing purposes, temp compensation is needed. Hence by default, temp compensation is disabled.

5 hrs ago

Vinayakam Mani

For spent chamber fill, we don't know how low the liquid level is ( in Chamber H) and hence decided not to turn on the trimmer heater for safety reasons. For bicarb fill, the dry bicart code should...

For spent chamber fill, we don't know how low the liquid level is ( in Chamber H) and hence decided not to turn on the trimmer heater for safety reasons. For bicarb fill, the dry bicart code should cover the actuators status. the current bicarb chamber fill code here should be updated with the newly implemented dry bi cart code changes.

5 hrs ago

Vinayakam Mani

LDT-1473 code review comments

Options
    • -14
    • +14
    ./Controllers/BalancingChamber.c
    • -1
    • +1
    ./Controllers/BalancingChamber.h
    • -12
    • +1
    ./Controllers/ConcentratePumps.c
7 hrs ago

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./DDCommon.h
9 hrs ago

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./DDCommon.h
9 hrs ago

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./Controllers/PermeateTank.c
    • -2
    • +2
    ./Controllers/RinsePump.c
    • -2
    • +2
    ./Controllers/Valves.c
    • -1
    • +1
    ./Controllers/Valves.h
    • -2
    • +2
    ./Modes/FPModes/ModePreGenPermeate.c
    • -2
    • +2
    ./Modes/ModeStandby.c
    • -2
    • +2
    ./Modes/ModeStandby.h
    • -2
    • +2
    ./Services/AlarmMgmtSWFaults.h
    • -2
    • +2
    ./Services/TDInterface.c
9 hrs ago

Raghu Kallala

9 hrs ago

Sean Nash , Vinayakam Mani and Michael Garthwaite

9 hrs ago

Vendor - TEL - Jashwant Gantyada

LDT-2030 removed static variables to update the values used by monitor and driver

Options
    • -7
    • +9
    ./Drivers/BloodLeakDriver.c
    • -1
    • +1
    ./Drivers/BloodLeakDriver.h
    • -44
    • +1
    ./Monitors/BloodLeak.c
10 hrs ago

Vendor - TEL - Sameer Poyil

Fixed it

Fixed it

10 hrs ago

Vendor - TEL - Sameer Poyil

LDT-2004-3 removing blank line

Options
    • -1
    • +0
    ./Monitors/Level.c
10 hrs ago

Raghu Kallala

LDT-3343 added condition for DD to wait for FP to start preGen

Options
    • -2
    • +2
    ./Controllers/RinsePump.c
    • -4
    • +12
    ./Modes/ModeStandby.c
14 hrs ago

Raghu Kallala

LDT-3343 updated function header

Options
    • -2
    • +1
    ./Controllers/Valves.c
14 hrs ago

Raghu Kallala

Updated

Updated

14 hrs ago

Raghu Kallala

Fixed

Fixed

Tuesday 03 Feb
5:32 pm

Sean Nash

I think cal data and count should be retrieved by same function and possibly needs some interrupt protection to ensure data and count stick together. If these functions are called from general task...

I think cal data and count should be retrieved by same function and possibly needs some interrupt protection to ensure data and count stick together. If these functions are called from general task, we could have situation where data is retrieved, then priority task updates fpga, and then counter is retrieved with wrong (incremented) counter.
If these two functions are being called from a driver that is executed in priority task, then we don't need to worry about this situation, but still ought to add a constraint/warning comment in function headers noting that these functions should only be called from priority task.

5:23 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

5:17 pm

Sean Nash

It is your comment, so please resolve it.

It is your comment, so please resolve it.

5:16 pm

Sean Nash

I think Dialin will need get (or UI proxy) commands to have us send cal, s/n, and versions.

I think Dialin will need get (or UI proxy) commands to have us send cal, s/n, and versions.

5:15 pm

Sean Nash

Do FP sensors have to be treated separately? I realize there needs to be separate messages as they will be coming from different Dialin classes, but can't we handle both messages with same function...

Do FP sensors have to be treated separately? I realize there needs to be separate messages as they will be coming from different Dialin classes, but can't we handle both messages with same function (assuming shared enum to index)?

5:14 pm

Sean Nash

General Dialin question - does it make sense to override temperatures at driver level where they are spread out over several drivers? I would think overriding at monitor level would be simpler wher...

General Dialin question - does it make sense to override temperatures at driver level where they are spread out over several drivers? I would think overriding at monitor level would be simpler where they are all in one place and could be indexed by enum with single command.

5:09 pm

Sean Nash

Do we need to say Value?

Do we need to say Value?

5:08 pm

Sean Nash

Add a blank line after public defs banner. Add a dox comment to the right. I believe they reserve space for 12 bytes, not 10. Not really for calibration - it's for s/n and versions.

Add a blank line after public defs banner.
Add a dox comment to the right.
I believe they reserve space for 12 bytes, not 10.
Not really for calibration - it's for s/n and versions.

5:06 pm

Sean Nash

Are these really going to be different types? I assumed they would all be floats.

Are these really going to be different types? I assumed they would all be floats.

5:05 pm

Sean Nash

Structures need a top level dox comment.

Structures need a top level dox comment.

5:05 pm

Sean Nash

enums need a top level dox comment.

enums need a top level dox comment.

5:02 pm

Vendor - TEL - Sameer Poyil

This function also not using u32ArrayOverride()

This function also not using u32ArrayOverride()