dgfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Saturday 06 Mar 2021
9:54 am

Dara Navaei

DEN-5963 added other inlet and outlet fans RPM

Options
    • -5
    • +5
    /firmware/App/Controllers/ROPump.h
    • -6
    • +6
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -8
    • +14
    /firmware/App/Services/FPGA.c
Friday 05 Mar 2021
2:02 pm

Dara Navaei

DEN-5963 tested heat disinfect

Options
    • -2
    • +3
    /firmware/App/Controllers/DrainPump.c
    • -2
    • +2
    /firmware/App/Modes/ModeDrain.c
    • -102
    • +229
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -1
    • +2
    /firmware/App/Modes/ModeHeatDisinfect.h
    • -1
    • +1
    /firmware/App/Services/Reservoirs.c
    • -1
    • +1
    /firmware/App/Services/Reservoirs.h
    • -3
    • +21
    /firmware/App/Services/WatchdogMgmt.c
Thursday 04 Mar 2021
1:17 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7091: Added acid and bicarb tests

Options
    • -14
    • +14
    /firmware/App/Controllers/ConcentratePumps.c
    • -2
    • +2
    /firmware/App/Controllers/ConcentratePumps.h
    • -35
    • +63
    /firmware/App/Controllers/ConductivitySensors.c
    • -1
    • +4
    /firmware/App/Controllers/ConductivitySensors.h
    • -1
    • +1
    /firmware/App/Controllers/TemperatureSensors.c
    • -0
    • +1
    /firmware/App/DGCommon.h
    • -41
    • +158
    /firmware/App/Modes/ModeFill.c
    • -1
    • +0
    /firmware/App/Modes/ModeFill.h
    • -2
    • +6
    /firmware/App/Modes/ModeRecirculate.c
    • -2
    • +2
    /firmware/App/Modes/ModeStandby.c
Tuesday 02 Mar 2021
9:35 pm

Dara Navaei

DEN-5963 worked on the heat disinfect states

Options
    • -23
    • +23
    /firmware/App/Controllers/DrainPump.c
    • -8
    • +8
    /firmware/App/Controllers/Heaters.c
    • -3
    • +3
    /firmware/App/Controllers/Heaters.h
    • -79
    • +121
    /firmware/App/Modes/ModeHeatDisinfect.c
4:26 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7091: Fixed FPGA revision

Options
    • -5
    • +5
    /firmware/App/Services/FPGA.c
11:57 am

Quang Nguyen <qnguyen@diality.com>

DEN-7091: Fixed drain pump conversion error when pump is off

Options
    • -2
    • +13
    /firmware/App/Controllers/DrainPump.c
11:23 am

Quang Nguyen <qnguyen@diality.com>

DEN-7091: Expanded fill command to accept start/stop flag

Options
    • -0
    • +7
    /firmware/App/Services/Reservoirs.h
    • -4
    • +12
    /firmware/App/Services/SystemCommMessages.c
Monday 01 Mar 2021
10:39 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:35 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:25 am

qnguyen  (deleted user)

Removed.

Removed.

10:22 am

Quang Nguyen <qnguyen@diality.com>

DEN-7091: Addressed code review

Options
    • -1
    • +0
    /firmware/App/Services/Reservoirs.c
9:53 am

Sean Nash

I think setActiveReservoirCMD() sets activeReservoir.data for you. Redundant.

I think setActiveReservoirCMD() sets activeReservoir.data for you. Redundant.

8:51 am

qnguyen  (deleted user)

Due to changes from non-volatile data management, this message is no longer available. Need to remove to fix build.

Due to changes from non-volatile data management, this message is no longer available.
Need to remove to fix build.

Sunday 28 Feb 2021
10:11 pm

pmontazemi  (deleted user)

Why removed?

Why removed?

5:13 pm

qnguyen  (deleted user)

Saturday 27 Feb 2021
11:09 am

Dara Navaei

DEN-5963 added Ilimit to the PIControllers.c, added feedback temperature sensor to the heaters.c, worked on heat disinfect mode

Options
    • -2
    • +2
    /firmware/App/Controllers/DrainPump.c
    • -33
    • +57
    /firmware/App/Controllers/Heaters.c
    • -17
    • +22
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -0
    • +1
    /firmware/App/Modes/ModeHeatDisinfect.h
    • -6
    • +6
    /firmware/App/Services/PIControllers.c
Friday 26 Feb 2021
12:34 pm

Dara Navaei

DEN-5963 worked on RO pump and the pre heat disinfect states

Options
    • -90
    • +136
    /firmware/App/Controllers/ROPump.c
    • -44
    • +47
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -5
    • +5
    /firmware/App/Modes/ModeHeatDisinfect.h
    • -1
    • +1
    /firmware/App/Modes/ModeRecirculate.c
    • -0
    • +1
    /firmware/App/Services/PIControllers.c
    • -1
    • +2
    /firmware/App/Services/PIControllers.h
    • -0
    • +12
    /firmware/App/Services/Reservoirs.c
    • -1
    • +3
    /firmware/App/Services/Reservoirs.h
Wednesday 24 Feb 2021
8:08 pm

Dara Navaei

DEN-5963 merged staging. Worked on RO pump

Options
    • -19
    • +17
    /firmware/App/Controllers/DrainPump.c
    • -11
    • +3
    /firmware/App/Controllers/Fans.c
    • -7
    • +48
    /firmware/App/Controllers/Heaters.c
    • -6
    • +22
    /firmware/App/Controllers/Heaters.h
    • -2
    • +2
    /firmware/App/Controllers/ROPump.c
    • -6
    • +3
    /firmware/App/Controllers/Thermistors.c
    • -26
    • +19
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -3
    • +7
    /firmware/App/Modes/ModeRecirculate.c
    • -2
    • +2
    /firmware/App/Modes/ModeStandby.c
    • -3
    • +7
    /firmware/App/Services/AlarmMgmt.h
    • -7
    • +0
    /firmware/App/Services/MessagePayloads.h
    • -20
    • +42
    /firmware/App/Services/PIControllers.c
    • -107
    • +182
    /firmware/App/Services/Reservoirs.c
    • -0
    • +4
    /firmware/App/Services/SystemComm.c
    • -17
    • +88
    /firmware/App/Services/SystemCommMessages.c
    • -4
    • +17
    /firmware/App/Services/SystemCommMessages.h
3:25 pm

Dara Navaei

DEN-5963 worked on RO pump and the drain states of heat disinfect

Options
    • -1
    • +1
    /firmware/App/Controllers/LoadCell.c
    • -124
    • +6
    /firmware/App/Controllers/ROPump.c
    • -3
    • +4
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -1
    • +1
    /firmware/App/Modes/ModeRecirculate.c
    • -1
    • +1
    /firmware/App/Modes/OperationModes.c
    • -1
    • +0
    /firmware/App/Services/PIControllers.h
    • -6
    • +2
    /firmware/App/Services/Reservoirs.c
12:54 pm

qnguyen  (deleted user)

DG-DEN-7091_Pre Treatment Mode
DG-DEN-7091_Pre Treatment Mode
10:37 am

Quang Nguyen <qnguyen@diality.com>

DEN-7091: Changed startup active reservoir to 1

Options
    • -4
    • +4
    /firmware/App/Modes/ModeStandby.c
    • -5
    • +3
    /firmware/App/Services/Reservoirs.c
Tuesday 23 Feb 2021
2:26 pm

Dara Navaei

DEN-5963 changed the RO pump control scheme from pressure control to flow control

Options
    • -0
    • +8
    /firmware/.cproject
    • -1
    • +2
    /firmware/.launches/DG.launch
    • -6
    • +6
    /firmware/App/Controllers/LoadCell.c
    • -10
    • +1
    /firmware/App/Controllers/LoadCell.h
    • -91
    • +161
    /firmware/App/Controllers/ROPump.c
    • -0
    • +1
    /firmware/App/Controllers/ROPump.h
    • -11
    • +11
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -1
    • +1
    /firmware/App/Modes/ModeRecirculate.c
    • -1
    • +0
    /firmware/App/Services/PIControllers.c
    • -4
    • +4
    /firmware/App/Services/Reservoirs.c
    • -4
    • +0
    /firmware/App/Services/SystemComm.c
Monday 22 Feb 2021
6:39 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7091: Added filter flush progress data broadcast

Options
    • -3
    • +16
    /firmware/App/Modes/ModeStandby.c
    • -0
    • +30
    /firmware/App/Services/SystemCommMessages.c
    • -0
    • +3
    /firmware/App/Services/SystemCommMessages.h
1:33 pm

Quang Nguyen <qnguyen@diality.com>

Merge branch 'DEN-6402-hd_dev-pre-treatment-self-tests' into staging

Options
1:32 pm

qnguyen  (deleted user)

1:27 pm

Dara Navaei and Sean Nash

9:54 am

Sean Nash

Do these structures require packing? Separate those that do from those that do not and pack only those that do.

Do these structures require packing? Separate those that do from those that do not and pack only those that do.

9:48 am

Sean Nash

Why is this commented out?

Why is this commented out?

9:47 am

Sean Nash

You can remove the else - no longer needed.

You can remove the else - no longer needed.

9:46 am

Sean Nash

These cases should be in same order as enum. POST tests for drivers/controllers/monitors will need NV Data Mgmt to have already read and validated NV Data so they can get/apply calibration. So shou...

These cases should be in same order as enum.
POST tests for drivers/controllers/monitors will need NV Data Mgmt to have already read and validated NV Data so they can get/apply calibration. So should this POST be executed earlier?