Activity dgfirmware/

11:20 am

Quang Nguyen <qnguyen@diality.com>

More
c76b192
changed 1 file
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 209 more DG-DEN-7802-1

DEN-7802: Addressed code review

- -2
- +2
/firmware/App/Controllers/ConcentratePumps.c
- History
- Source
- Diff
/firmware/App/.../ConcentratePumps.c

10:47 am

pmontazemi (deleted user)

More
Re: DG-DEN-7802-1
commented on review

The if should be < and the else if should be >= otherwise there is double-dipping in case the value equals.

10:01 am

Dara Navaei

More
DG-DEN-7568-1
Closed

9:59 am

Dara Navaei

More
ca4f934
changed 0 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 214 more

Merge branch 'DEN-7568-dg-hd_dev-dg-mode-flush' into staging

5:43 pm

Dara Navaei

More
8b8b9bb
changed 1 file
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 215 more DG-DEN-7568-1 DG-DEN-7605-1

DEN-7568 added reservoir check to heat disinfect

- -49
- +43
/firmware/App/Modes/ModeHeatDisinfect.c
- History
- Source
- Diff
/firmware/App/Modes/ModeHeatDisinfect.c

4:33 pm

Dara Navaei

More
e86af65
changed 5 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 215 more DG-DEN-7568-1 DG-DEN-7605-1

DEN-7568 tested mode flush

- -1
- +1
/firmware/.launches/DG.launch
- History
- Source
- Diff
/firmware/.launches/DG.launch
- -3
- +7
/firmware/App/Modes/ModeFlush.c
- History
- Source
- Diff
/firmware/App/Modes/ModeFlush.c
- -0
- +3
/firmware/App/Modes/ModeHeatDisinfect.c
- History
- Source
- Diff
/firmware/App/Modes/ModeHeatDisinfect.c
- -0
- +14
/firmware/App/Services/Reservoirs.c
- History
- Source
- Diff
/firmware/App/Services/Reservoirs.c
- -0
- +1
/firmware/App/Services/Reservoirs.h
- History
- Source
- Diff
/firmware/App/Services/Reservoirs.h

3:28 pm

Quang Nguyen <qnguyen@diality.com>

More
80a15f5
changed 0 files
develop_1-24

Merge branch 'DEN-7802-dg_dev-dialysate-generation' into develop

3:19 pm

Quang Nguyen <qnguyen@diality.com>

More
145a82b
changed 1 file
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 209 more DG-DEN-7802-1

DEN-7802: Change flush line RO pump rate to 0.6

- -1
- +1
/firmware/App/Modes/ModeRecirculate.c
- History
- Source
- Diff
/firmware/App/Modes/ModeRecirculate.c

11:05 am

qnguyen (deleted user)

More
DG-DEN-7802-1
started review

DG-DEN-7802_DG-DEV Dialysate Generation

10:33 am

Sean Nash

More
Re: DG-DEN-7568-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

10:32 am

qnguyen (deleted user)

More
Re: DG-DEN-7568-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

10:17 am

Dara Navaei

More
34ed52c
changed 4 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 215 more DG-DEN-7568-1 DG-DEN-7605-1

DEN-7568 addressed code review comments

- -5
- +12
/firmware/App/Controllers/Heaters.c
- History
- Source
- Diff
/firmware/App/Controllers/Heaters.c
- -14
- +39
/firmware/App/Controllers/TemperatureSensors.c
- History
- Source
- Diff
/firmware/App/.../TemperatureSensors.c
- -24
- +24
/firmware/App/Controllers/TemperatureSensors.h
- History
- Source
- Diff
/firmware/App/.../TemperatureSensors.h
- -18
- +22
/firmware/App/Modes/ModeFlush.c
- History
- Source
- Diff
/firmware/App/Modes/ModeFlush.c

10:16 am

Dara Navaei

More
Re: DG-DEN-7568-1
replied to qnguyen (deleted user)

Done.

10:36 pm

qnguyen (deleted user)

More
Re: DG-DEN-7568-1
commented on review

This struct needs doxygen comment on individual member.

9:00 am

Dara Navaei

More
1a7b3fd
changed 3 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 215 more DG-DEN-7568-1 DG-DEN-7605-1

DEN-7568 added more states to flush mode

- -1
- +1
/firmware/App/Controllers/ROPump.c
- History
- Source
- Diff
/firmware/App/Controllers/ROPump.c
- -1
- +1
/firmware/App/DGCommon.h
- History
- Source
- Diff
/firmware/App/DGCommon.h
- -81
- +134
/firmware/App/Modes/ModeFlush.c
- History
- Source
- Diff
/firmware/App/Modes/ModeFlush.c

11:04 am

Dara Navaei

More
Re: DG-DEN-7568-1
replied to Sean Nash

Moved this function to the FaultMode.c.

11:04 am

Dara Navaei

More
d792668
changed 6 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 215 more DG-DEN-7568-1 DG-DEN-7605-1

DEN-7568 added more states to DG flush mode

- -0
- +1
/firmware/App/Controllers/Heaters.c
- History
- Source
- Diff
/firmware/App/Controllers/Heaters.c
- -1
- +40
/firmware/App/Modes/ModeFault.c
- History
- Source
- Diff
/firmware/App/Modes/ModeFault.c
- -0
- +2
/firmware/App/Modes/ModeFault.h
- History
- Source
- Diff
/firmware/App/Modes/ModeFault.h
- -80
- +121
/firmware/App/Modes/ModeFlush.c
- History
- Source
- Diff
/firmware/App/Modes/ModeFlush.c
- -0
- +1
/firmware/App/Modes/ModeFlush.h
- History
- Source
- Diff
/firmware/App/Modes/ModeFlush.h
- -1
- +0
/firmware/App/Modes/ModeRecirculate.c
- History
- Source
- Diff
/firmware/App/Modes/ModeRecirculate.c

3:59 pm

Quang Nguyen <qnguyen@diality.com>

More
25a1a0d
changed 2 files
develop_1-24

Merge branch 'DEN-7802-dg_dev-dialysate-generation' into develop

- -3
- +3
/firmware/App/Controllers/Heaters.c
- History
- Source
- Diff
/firmware/App/Controllers/Heaters.c
- -1
- +2
/firmware/App/Controllers/TemperatureSensors.c
- History
- Source
- Diff
/firmware/App/.../TemperatureSensors.c

3:58 pm

Quang Nguyen <qnguyen@diality.com>

More
24b77e3
changed 0 files
develop_1-24

Merge branch 'DEN-7568-dg-hd_dev-dg-mode-flush' into develop

3:53 pm

Quang Nguyen <qnguyen@diality.com>

More
79970a6
changed 1 file
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 209 more DG-DEN-7802-1

DEN-7802: Fixed heater running during off state

- -3
- +3
/firmware/App/Controllers/Heaters.c
- History
- Source
- Diff
/firmware/App/Controllers/Heaters.c

11:41 am

Sean Nash

More
4255fcb
changed 1 file
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 214 more DG-DEN-7605-1

DEN-7605: Removed heater start from recirculate mode.

- -1
- +0
/firmware/App/Modes/ModeRecirculate.c
- History
- Source
- Diff
/firmware/App/Modes/ModeRecirculate.c

10:49 am

Quang Nguyen <qnguyen@diality.com>

More
5a55992
changed 0 files
develop_1-24

Merge branch 'DEN-7802-dg_dev-dialysate-generation' into develop

10:36 am

qnguyen (deleted user)

More
Re: DG-DEN-7568-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

10:35 am

qnguyen (deleted user)

More
Re: DG-DEN-7568-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

10:35 am

qnguyen (deleted user)

More
Re: DG-DEN-7568-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

10:34 am

qnguyen (deleted user)

More
Re: DG-DEN-7568-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

10:34 am

Dara Navaei

More
eb6220e
changed 1 file
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 215 more DG-DEN-7568-1

DEN-7568 addressed a code review comment

- -1
- +0
/firmware/App/Modes/ModeFlush.c
- History
- Source
- Diff
/firmware/App/Modes/ModeFlush.c

10:34 am

qnguyen (deleted user)

More
Re: DG-DEN-7568-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

10:34 am

qnguyen (deleted user)

More
Re: DG-DEN-7568-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

10:33 am

qnguyen (deleted user)

More
Re: DG-DEN-7568-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

dgfirmware

Stats

Commits this week: 0

Commit Activity

52 week commits volume

Commits by day

Commits by hour

Commit calendar

Most active committers (90 days)

Quang Nguyen <qnguyen@diality.com>

pmontazemi (deleted user)

Dara Navaei

Dara Navaei

Dara Navaei

Dara Navaei

Quang Nguyen <qnguyen@diality.com>

Quang Nguyen <qnguyen@diality.com>

qnguyen (deleted user)

Sean Nash

qnguyen (deleted user)

Dara Navaei

Dara Navaei

qnguyen (deleted user)

Dara Navaei

Dara Navaei

Dara Navaei

Quang Nguyen <qnguyen@diality.com>

Quang Nguyen <qnguyen@diality.com>

Quang Nguyen <qnguyen@diality.com>

Sean Nash

Quang Nguyen <qnguyen@diality.com>

qnguyen (deleted user)

qnguyen (deleted user)

qnguyen (deleted user)

qnguyen (deleted user)

Dara Navaei

qnguyen (deleted user)

qnguyen (deleted user)

qnguyen (deleted user)