dgfirmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-8030 added a more code to the cooling stage of the RO filter in heat disinfect

    • -183
    • +15
    /firmware/App/Controllers/Heaters.c
    • -69
    • +130
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -2
    • +2
    /firmware/App/Modes/ModeHeatDisinfect.h
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

DEN-7605: Local merge w/ staging.

    • -12
    • +891
    /firmware/App/Modes/ModeFlush.c
    • -14
    • +43
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -252
    • +254
    /firmware/App/Services/Reservoirs.c
    • -16
    • +15
    /firmware/App/Services/Reservoirs.h
DEN-7802: Fixed conductivity fault condition

I think we should not stop RO pump or heater. Just go to drain like production state (but no mixing).

I think we should not stop RO pump or heater. Just go to drain like production state (but no mixing).

Call checkDialysateConductivity() once at top of function. Then use return value for the two if conditions. Also, this second if should be an else if to ensure you don't do both.

Call checkDialysateConductivity() once at top of function. Then use return value for the two if conditions.
Also, this second if should be an else if to ensure you don't do both.

DEN-7605: Re-ordered DG POST tests. Fixed comments.

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

V3 build.

DEN-7802: Fixed water sample

DEN-8030 updated the drain pump RPM conversion

    • -4
    • +9
    /firmware/App/Modes/ModeHeatDisinfect.c
DEN-8103: Transition to fault mode if alarm is a DG fault alarm

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Merge branch 'develop' of ssh://dvm-linux02:7999/dg/dgfirmware into develop

Fixed launch file to not erase whole flash.

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Fixed merge conflicts.

DEN-7605: Removed obsolete code.

DEN-7605: Minor fixes.

DEN-8030 added UI states to heat disinfect. Changed the heaters control.

    • -3
    • +10
    /firmware/App/Controllers/DrainPump.c
    • -19
    • +48
    /firmware/App/Controllers/Heaters.c
    • -6
    • +33
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -0
    • +2
    /firmware/App/Modes/ModeHeatDisinfect.h
Change order of comparison.

Change order of comparison.

Blank line after declaration.

Blank line after declaration.

I think we should add the new THd temperature sensor now. I know it's currently using TRo connection (and so we don't have a TRo), but we should handle that with build switch (THd reads from TRo ch...

I think we should add the new THd temperature sensor now. I know it's currently using TRo connection (and so we don't have a TRo), but we should handle that with build switch (THd reads from TRo channel and TRo can just be a copy of TDi for now if THD_USING_TRO_CONNECTOR build switch enabled, actual future code where both sensors exist on their own connectors if build switch is disabled).

DEN-8103: Added alarm table size check

Is this needed. Should we just let Standby mode set actuators as it wants on entry?

Is this needed. Should we just let Standby mode set actuators as it wants on entry?

I think we should at least say that the mode variables are reset to re-start the mode or something.

I think we should at least say that the mode variables are reset to re-start the mode or something.

Why are some values aligned at left and others at right? I think all values should align at left.

Why are some values aligned at left and others at right? I think all values should align at left.