dgfirmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-7802: Added range check for pressure sensor

    • -7
    • +16
    /firmware/App/Controllers/Pressures.c
Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Please remove dead code.

Please remove dead code.

Should this be F64 as well?

Should this be F64 as well?

Remove dead code.

Remove dead code.

Yes, please remove. HD should set the target temp. I assume this was for dialysate heating tests.

Yes, please remove. HD should set the target temp. I assume this was for dialysate heating tests.

Not quite what I had in mind. I meant that, regardless of whether sharing a connector, you would always "get" the new heat disinfect temperature. Inside TempSensors, you would have the build switch...

Not quite what I had in mind.
I meant that, regardless of whether sharing a connector, you would always "get" the new heat disinfect temperature.
Inside TempSensors, you would have the build switch. If using TRO connector for new sensor, fill THd from TRo temp sensor and fill TRo from TDi temp sensor (both TDi and TRo share TDi sensor). If THd has its own connector (DVT system?), then fill THd from THd sensor and TRo from TRo sensor as you would normally expect.

DEN-8030 addressed code review comments

    • -4
    • +17
    /firmware/App/Modes/ModeChemicalDisinfect.c
DEN-8030 addressed code review comments

    • -4
    • +24
    /firmware/App/Modes/ModeHeatDisinfect.c
Done

Done

Done.

Done.

Done.

Done.

This was for testing. It is uncommented.

This was for testing. It is uncommented.

Done.

Done.

I removed it.

I removed it.

Done

Done

I removed the function.

I removed the function.

Done.

Done.

Done.

Done.

DEN-8030 merged staging

    • -4
    • +109
    /firmware/App/Controllers/DrainPump.c
    • -15
    • +76
    /firmware/App/Controllers/Valves.c
    • -2
    • +143
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -1
    • +1
    /firmware/App/Modes/ModeHeatDisinfect.h
    • -13
    • +44
    /firmware/App/Modes/ModeInitPOST.c
    • -0
    • +14
    /firmware/App/Modes/OperationModes.c
  1. … 7 more files in changeset.
DEN-8030 added a more code to the cooling stage of the RO filter in heat disinfect

    • -183
    • +15
    /firmware/App/Controllers/Heaters.c
    • -69
    • +130
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -2
    • +2
    /firmware/App/Modes/ModeHeatDisinfect.h
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.