dgfirmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Reset corrupted HalCOGen source files.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

DEN-8030 addressed code review comments

    • -12
    • +12
    /firmware/App/Modes/ModeHeatDisinfect.c
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Merge branch 'DEN-8103-dg-hd_dev-alarm-design' into develop

    • -49
    • +21
    /firmware/App/Controllers/Heaters.c
    • -13
    • +13
    /firmware/App/Controllers/LoadCell.c
    • -3
    • +3
    /firmware/App/Controllers/UVReactors.c
    • -3
    • +3
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -0
    • +133
    /firmware/App/Services/AlarmMgmtSWFaults.h
  1. … 4 more files in changeset.
DEN-8030 addressed code review comments

    • -17
    • +18
    /firmware/App/Modes/ModeChemicalDisinfect.c
    • -13
    • +27
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -12
    • +0
    /firmware/App/Modes/ModeHeatDisinfect.h
CONC_PUMPS_REVERSE_SPEED_ML_PER_MIN = -30.0 to indicate that the direction is in reverse.

CONC_PUMPS_REVERSE_SPEED_ML_PER_MIN = -30.0 to indicate that the direction is in reverse.

Done.

Done.

Good catch, thanks. I changed it.

Good catch, thanks. I changed it.

I check in the inlet pressure only at the states that are needed. There are times that I am not even pulling water from the inlet line.

I check in the inlet pressure only at the states that are needed. There are times that I am not even pulling water from the inlet line.

It is no longer needed.

It is no longer needed.

2000 uS/cm is a safe value to determine if the acid is inserted in. Due to sensor to sensor variations, we decided to keep it a little lower than its conductivity value is.

2000 uS/cm is a safe value to determine if the acid is inserted in. Due to sensor to sensor variations, we decided to keep it a little lower than its conductivity value is.

Done.

Done.

We should keep this for now in case we wanted to lower the heaters duty cycle to previous limits.

We should keep this for now in case we wanted to lower the heaters duty cycle to previous limits.

These functions are automatically generated once a HET driver is enabled in HALCoGen.

These functions are automatically generated once a HET driver is enabled in HALCoGen.

DEN-8103: Added init for integrity module

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.