dgfirmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Merge branch 'DEN-8886-hd_dg_dev-self-tests-2-of-2' into develop

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

DEN-7802: Used test support get override value

    • -22
    • +1
    /firmware/App/Controllers/DrainPump.c
    • -22
    • +1
    /firmware/App/Controllers/FluidLeak.c
    • -21
    • +1
    /firmware/App/Controllers/Heaters.c
    • -21
    • +1
    /firmware/App/Controllers/LoadCell.c
    • -31
    • +3
    /firmware/App/Controllers/Pressures.c
    • -22
    • +1
    /firmware/App/Controllers/Switches.c
    • -22
    • +1
    /firmware/App/Controllers/Thermistors.c
    • -30
    • +2
    /firmware/App/Controllers/UVReactors.c
    • -28
    • +2
    /firmware/App/Controllers/Voltages.c
  1. … 3 more files in changeset.
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done.

Done.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done.

Done.

DEN-7802: Addressed code review comments

    • -4
    • +4
    /firmware/App/Modes/ModeHeatDisinfect.c
Done.

Done.

Done.

Done.

Done.

Done.

I would prefer we return a TRUE or FALSE explicitly (like function below).

I would prefer we return a TRUE or FALSE explicitly (like function below).

Removed.

Removed.

DEN-7802: Removed concentrate pump voltage broadcast data

Start comments w/ capital letter.

Start comments w/ capital letter.

I know bicarb pump "on" request above does not immediately turn the pump on, but I still think we should set target speed before we request pump on.

I know bicarb pump "on" request above does not immediately turn the pump on, but I still think we should set target speed before we request pump on.

I know acid pump "on" request above does not immediately turn the pump on, but I still think we should set target speed before we request pump on.

I know acid pump "on" request above does not immediately turn the pump on, but I still think we should set target speed before we request pump on.

Changes "Pumps" to "Pump". Request is for single pump.

Changes "Pumps" to "Pump". Request is for single pump.

So we are not monitoring these, but we are publishing them?

So we are not monitoring these, but we are publishing them?

DEN-7802: Removed concentrate pumps voltage monitor and fixed pressure checks

    • -19
    • +17
    /firmware/App/Controllers/Voltages.h