dgfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 20 Aug 2021
2:20 pm

Quang Nguyen <qnguyen@diality.com>

Merge branch 'DEN-8886-hd_dg_dev-self-tests-2-of-2' into develop

Options
Thursday 19 Aug 2021
3:23 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/DGCommon.h
2:04 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/DGCommon.h
2:02 pm

Sean Nash

2:01 pm

qnguyen  (deleted user) and Dara Navaei

1:17 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7802: Used test support get override value

Options
    • -22
    • +1
    /firmware/App/Controllers/ConcentratePumps.c
    • -30
    • +2
    /firmware/App/Controllers/ConductivitySensors.c
    • -22
    • +1
    /firmware/App/Controllers/DrainPump.c
    • -21
    • +1
    /firmware/App/Controllers/Fans.c
    • -22
    • +1
    /firmware/App/Controllers/FluidLeak.c
    • -21
    • +1
    /firmware/App/Controllers/Heaters.c
    • -21
    • +1
    /firmware/App/Controllers/LoadCell.c
    • -31
    • +3
    /firmware/App/Controllers/Pressures.c
    • -30
    • +2
    /firmware/App/Controllers/ROPump.c
    • -22
    • +1
    /firmware/App/Controllers/Switches.c
    • -22
    • +1
    /firmware/App/Controllers/TemperatureSensors.c
    • -22
    • +1
    /firmware/App/Controllers/Thermistors.c
    • -30
    • +2
    /firmware/App/Controllers/UVReactors.c
    • -30
    • +3
    /firmware/App/Controllers/Valves.c
    • -28
    • +2
    /firmware/App/Controllers/Voltages.c
  16. … 3 more files in changeset.
10:41 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:41 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:40 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:40 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:40 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:39 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:39 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:39 am

qnguyen  (deleted user)

Done.

Done.

10:37 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:29 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:13 am

qnguyen  (deleted user)

Done.

Done.

10:13 am

Quang Nguyen <qnguyen@diality.com>

DEN-7802: Addressed code review comments

Options
    • -4
    • +4
    /firmware/App/Controllers/ConcentratePumps.c
    • -2
    • +2
    /firmware/App/Controllers/ConcentratePumps.h
    • -4
    • +4
    /firmware/App/Modes/ModeChemicalDisinfect.c
    • -2
    • +2
    /firmware/App/Modes/ModeFault.c
    • -58
    • +19
    /firmware/App/Modes/ModeFill.c
    • -4
    • +4
    /firmware/App/Modes/ModeFlush.c
    • -2
    • +2
    /firmware/App/Modes/ModeGenIdle.c
    • -4
    • +4
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -2
    • +2
    /firmware/App/Services/SystemCommMessages.c
10:10 am

qnguyen  (deleted user)

Done.

Done.

10:10 am

qnguyen  (deleted user)

Done.

Done.

10:08 am

qnguyen  (deleted user)

Done.

Done.

9:26 am

Sean Nash

I would prefer we return a TRUE or FALSE explicitly (like function below).

I would prefer we return a TRUE or FALSE explicitly (like function below).

9:26 am

qnguyen  (deleted user)

Removed.

Removed.

9:26 am

Quang Nguyen <qnguyen@diality.com>

DEN-7802: Removed concentrate pump voltage broadcast data

Options
    • -2
    • +0
    /firmware/App/Controllers/Voltages.h
9:25 am

Sean Nash

Start comments w/ capital letter.

Start comments w/ capital letter.

9:23 am

Sean Nash

I know bicarb pump "on" request above does not immediately turn the pump on, but I still think we should set target speed before we request pump on.

I know bicarb pump "on" request above does not immediately turn the pump on, but I still think we should set target speed before we request pump on.

9:22 am

Sean Nash

I know acid pump "on" request above does not immediately turn the pump on, but I still think we should set target speed before we request pump on.

I know acid pump "on" request above does not immediately turn the pump on, but I still think we should set target speed before we request pump on.

9:20 am

Sean Nash

Changes "Pumps" to "Pump". Request is for single pump.

Changes "Pumps" to "Pump". Request is for single pump.

9:15 am

Sean Nash

So we are not monitoring these, but we are publishing them?

So we are not monitoring these, but we are publishing them?

Wednesday 18 Aug 2021
4:55 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7802: Removed concentrate pumps voltage monitor and fixed pressure checks

Options
    • -1
    • +1
    /firmware/App/Controllers/Pressures.c
    • -6
    • +0
    /firmware/App/Controllers/Voltages.c
    • -19
    • +17
    /firmware/App/Controllers/Voltages.h
    • -1
    • +1
    /firmware/App/DGCommon.h
    • -0
    • +5
    /firmware/App/Modes/ModeInitPOST.c