dgfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 23 Feb 2022
10:52 am

Dara Navaei

Merge branch 'DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up' into develop

Options
    • -1
    • +1
    /firmware/App/Controllers/ConcentratePumps.c
    • -1
    • +1
    /firmware/App/Controllers/Heaters.c
    • -7
    • +11
    /firmware/App/Controllers/ROPump.c
    • -1
    • +1
    /firmware/App/DGCommon.h
10:39 am

Dara Navaei

DEN-11750 updated the code

Options
    • -1
    • +1
    /firmware/App/Controllers/Fans.c
    • -1
    • +1
    /firmware/App/Controllers/Heaters.c
    • -7
    • +11
    /firmware/App/Controllers/ROPump.c
    • -1
    • +2
    /firmware/App/Controllers/ROPump.h
    • -1
    • +1
    /firmware/App/DGCommon.h
    • -1
    • +2
    /firmware/App/Services/Reservoirs.c
10:14 am

Hung Nguyen <hnguyen@diality.com>

DEN-11928 Implemented conductivity updates

Options
    • -1
    • +1
    /firmware/App/Controllers/ConcentratePumps.h
    • -9
    • +4
    /firmware/App/Controllers/ConductivitySensors.h
    • -116
    • +242
    /firmware/App/Modes/ModeFill.c
Tuesday 22 Feb 2022
5:16 pm

Michael Garthwaite

Could we move these fields outside of the for loop? They dont need to be initialized NUM_OF_FANS_NAMES times.

Could we move these fields outside of the for loop? They dont need to be initialized NUM_OF_FANS_NAMES times.

5:13 pm

Michael Garthwaite

If the DG is broadcasting these raw values, shouldn't Dialin be sync'd as well to handle these new fields?

If the DG is broadcasting these raw values, shouldn't Dialin be sync'd as well to handle these new fields?

5:07 pm

Michael Garthwaite

All the new timer counters no longer are initialized to 0. I understand that they get set in their respective init()'s to the timer counter, but was this intentional?

All the new timer counters no longer are initialized to 0. I understand that they get set in their respective init()'s to the timer counter, but was this intentional?

5:05 pm

Michael Garthwaite

We should probably keep the = 0;

We should probably keep the = 0;

5:02 pm

Sean Nash

Merge branch 'DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up' of ssh://dvm-linux02:7999/dg/dgfirmware into DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up

Options
    • -0
    • +2
    /firmware/App/Controllers/ConcentratePumps.c
5:02 pm

Sean Nash

DEN-11750: Fixed casting error in ConcentratePumps.c.

Options
    • -1
    • +1
    /firmware/App/Controllers/ConcentratePumps.c
4:29 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/DGCommon.h
4:18 pm

Dara Navaei

Merged DEN-11750 and resolved the coflicts

Options
    • -0
    • +2
    /firmware/App/Controllers/ConcentratePumps.c
    • -3
    • +3
    /firmware/App/Controllers/ConductivitySensors.c
    • -106
    • +11
    /firmware/App/Controllers/Heaters.c
    • -22
    • +11
    /firmware/App/Controllers/ROPump.c
    • -3
    • +2
    /firmware/App/Controllers/Switches.c
    • -1
    • +2
    /firmware/App/DGCommon.h
    • -1
    • +2
    /firmware/App/Services/SystemComm.c
    • -4
    • +4
    /firmware/App/Services/SystemCommMessages.c
4:01 pm

Dara Navaei

Most of the files are VectorCAST that has been brought back from Code Clinic. Look at the files but they are auto generated so they are mostly passing through.

Most of the files are VectorCAST that has been brought back from Code Clinic. Look at the files but they are auto generated so they are mostly passing through.

3:57 pm

Michael Garthwaite

Notices the 170 files that need to be reviewed https://c.tenor.com/RXMxqsRKEn0AAAAC/this-is-fine.gif

Notices the 170 files that need to be reviewed

https://c.tenor.com/RXMxqsRKEn0AAAAC/this-is-fine.gif

3:48 pm

Dara Navaei

DEN-11750 addressed the bugs that Code Clinic reported

Options
    • -5
    • +4
    /firmware/App/Controllers/Fans.c
    • -1
    • +1
    /firmware/App/Controllers/Fans.h
    • -1
    • +1
    /firmware/App/Controllers/Heaters.c
    • -3
    • +2
    /firmware/App/Controllers/Switches.c
    • -1
    • +1
    /firmware/App/Modes/ModeChemicalDisinfect.c
    • -1
    • +2
    /firmware/App/Services/SystemComm.c
    • -4
    • +4
    /firmware/App/Services/SystemCommMessages.c
3:47 pm

Dara Navaei

DG-DEN-11750_DG Dev Dialysate Temperature Control Tune Up
DG-DEN-11750_DG Dev Dialysate Temperature Control Tune Up
3:47 pm

Michael Garthwaite

DEN-12121: Implementation of DIAL-147, HD Communication Status Override.

Options
    • -4
    • +50
    /firmware/App/Services/SystemComm.c
    • -1
    • +2
    /firmware/App/Services/SystemComm.h
    • -0
    • +31
    /firmware/App/Services/SystemCommMessages.c
    • -0
    • +3
    /firmware/App/Services/SystemCommMessages.h
12:57 pm

Dara Navaei

DEN-11750 added more comments

Options
    • -15
    • +8
    /firmware/App/Controllers/ROPump.c
10:59 am

Dara Navaei

DEN-11750 worked on the RO pump duty cycle feedback

Options
    • -0
    • +2
    /firmware/App/Controllers/ConcentratePumps.c
    • -105
    • +10
    /firmware/App/Controllers/Heaters.c
    • -13
    • +9
    /firmware/App/Controllers/ROPump.c
    • -0
    • +1
    /firmware/App/DGCommon.h
    • -1
    • +1
    /firmware/App/Drivers/InternalADC.c
Sunday 20 Feb 2022
5:37 pm

Dara Navaei

Merge branch 'cc-vectorcast2' into DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up

Options
5:37 pm

Dara Navaei

DEM-11750 updated the code

Options
    • -1
    • +1
    /firmware/App/Controllers/Heaters.c
    • -1
    • +1
    /firmware/App/DGCommon.h
Thursday 17 Feb 2022
3:26 pm

Darren Cox <darren_m@cox.net>

DEN-12215 Fix linker overrides or HalCoGen generated files so CRC information persists.

Options
    • -3
    • +33
    /firmware/source/sys_link.cmd
Tuesday 15 Feb 2022
9:01 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/DGCommon.h
Monday 14 Feb 2022
1:54 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/DGCommon.h
1:35 pm

Dara Navaei

Merged DEN-11750 and resolved the merge conflicts

Options
    • -28
    • +26
    /firmware/App/DGCommon.h
    • -1
    • +1
    /firmware/App/Services/SystemComm.c
    • -2
    • +2
    /firmware/App/Services/SystemCommMessages.c
11:07 am

Sean Nash

DEN-11750: Fixed drain pump RPM out of range alarm.

Options
    • -4
    • +6
    /firmware/App/Controllers/DrainPump.c
10:40 am

Sean Nash

Merge branch 'DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up' of ssh://dvm-linux02:7999/dg/dgfirmware into DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up

Options
10:17 am

Dara Navaei

Merge branch 'DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up' of ssh://dvm-linux02:7999/dg/dgfirmware into DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up

Options
10:17 am

Dara Navaei

DEN-11750 updated the drain pump

Options
    • -1
    • +1
    /firmware/App/Controllers/DrainPump.c
    • -26
    • +26
    /firmware/App/DGCommon.h
Thursday 10 Feb 2022
10:58 am

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/DGCommon.h
10:57 am

Dara Navaei

Merged DEN-11750

Options
    • -1
    • +1
    /firmware/App/DGCommon.h