dgfirmware

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Probably a good idea for consistency, but not necessary. Where we need to add the 'F' suffix to floating point literals is when the literal will not be typed. Here, we are assigning 0.0 to an F32 t...

Probably a good idea for consistency, but not necessary. Where we need to add the 'F' suffix to floating point literals is when the literal will not be typed. Here, we are assigning 0.0 to an F32 typed variable so it will be typed properly. A #define may or may not be typed depending on how it's used. If it's used in a mathematical expression, the compiler will make it max precision (double) if we don't explicitly add the 'F' suffix and that can cause some problems with the precision in the math.

Remove blank line.

Remove blank line.

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTRHOUGH

RESOLVED IN CODE WALKTRHOUGH

Use 0.0F

Use 0.0F

Sensor misspelled (Sesnor). Change name to execFlowSensorMonitor.

Sensor misspelled (Sesnor). Change name to execFlowSensorMonitor.

This block of code is being flagged as a change into my branch but it is not reflected on either commit listed above. Header will be updated in DEN-13801 branch.

This block of code is being flagged as a change into my branch but it is not reflected on either commit listed above. Header will be updated in DEN-13801 branch.

Header needs to be updated

Header needs to be updated

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Line 1902 is the same check but reverses the order.

Line 1902 is the same check but reverses the order.

This code is un-commented.

This code is un-commented.

Done.

Done.

In in DEN-13834.

In in DEN-13834.

Done.

Done.

Added TODO to un-comment this line of code.

Added TODO to un-comment this line of code.

"FAPI_CHECK_FSM_READY_BUSY" is a macro.

"FAPI_CHECK_FSM_READY_BUSY" is a macro.