dgfirmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-14657 removed code to not check the error bit of a temperature sensor and let the temperature out of range alarm trigger the alarm

Done

Done

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Merge branch 'DEN-15367-hd_dg_test_configuration_setup' into develop

DEN-15571 changed the chemical disinfect temperature timeout from 1 minute to 5 minutes

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Merge branch 'DEN-15367-hd_dg_test_configuration_setup' into develop

DEN-15367 removed the payload from the message that informs HD that DG is ready to dispense more fluid in DG. DEN-15571 fixed the chemical disinfect state machine to transition to cancel water path once the target temperature was not reached within the specified time

    • -6
    • +11
    /firmware/App/Modes/ModeChemicalDisinfect.c
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Still has a payload. Should remove it.

Still has a payload. Should remove it.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

DEN-15367 addressed a code review comment

Removed the check to make sure the target speed is > 0. The current speed is always >= 0.0 mL/min.

Removed the check to make sure the target speed is > 0. The current speed is always >= 0.0 mL/min.

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

DEN-15367 addressed the code review comments

    • -3
    • +14
    /firmware/App/Modes/ModeROPermeateSample.c
Done

Done

Remove "handle" from this function name. It should start with "send". And why does this message have a payload. Message itself infers ready.

Remove "handle" from this function name. It should start with "send". And why does this message have a payload. Message itself infers ready.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

This function will be overhauled.

This function will be overhauled.

Done

Done

Done

Done

Done

Done

Done

Done

Done

Done