dgfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 26 Aug 2020
11:43 am

Quang Nguyen <qnguyen@diality.com>

DEN-4322: Addressed code review

Options
    • -1
    • +2
    /firmware/App/Controllers/ConductivitySensors.c
    • -2
    • +4
    /firmware/App/Controllers/TemperatureSensors.c
    • -0
    • +1
    /firmware/App/Services/AlarmMgmt.c
    • -1
    • +1
    /firmware/App/Services/CommBuffers.c
    • -9
    • +1
    /firmware/App/Services/FPGA.c
    • -2
    • +2
    /firmware/App/Services/SystemComm.c
10:08 am

Quang Nguyen <qnguyen@diality.com>

DEN-4322: Added more description to tasks

Options
    • -4
    • +4
    /firmware/App/Controllers/Heaters.c
    • -2
    • +2
    /firmware/App/Services/SystemCommMessages.c
    • -1
    • +1
    /firmware/App/Tasks/TaskBG.h
    • -1
    • +2
    /firmware/App/Tasks/TaskGeneral.h
    • -1
    • +2
    /firmware/App/Tasks/TaskPriority.h
    • -1
    • +1
    /firmware/App/Tasks/TaskTimer.h
12:30 am

Quang Nguyen <qnguyen@diality.com>

DEN-4322: Addressed code reviews

Options
    • -0
    • +1
    /firmware/App/Controllers/ConductivitySensors.c
    • -2
    • +0
    /firmware/App/Controllers/DrainPump.c
    • -0
    • +2
    /firmware/App/Controllers/Heaters.c
    • -0
    • +1
    /firmware/App/Controllers/LoadCell.c
    • -5
    • +2
    /firmware/App/Controllers/Pressures.c
    • -0
    • +1
    /firmware/App/Controllers/ROPump.c
    • -0
    • +2
    /firmware/App/Controllers/TemperatureSensors.c
    • -0
    • +2
    /firmware/App/Controllers/Valves.c
    • -0
    • +4
    /firmware/App/Drivers/InternalADC.h
    • -0
    • +2
    /firmware/App/Services/AlarmMgmt.c
    • -4
    • +1
    /firmware/App/Services/MessagePayloads.h
    • -0
    • +1
    /firmware/App/Services/Reservoirs.c
    • -0
    • +1
    /firmware/App/Services/SystemCommMessages.c
    • -0
    • +1
    /firmware/App/Services/WatchdogMgmt.c
Tuesday 25 Aug 2020
4:21 pm

Quang Nguyen <qnguyen@diality.com>

Merge branch 'DEN-4534-fw-doxygen-support' into DEN-4322-dg-water-ro-rejection

Options
3:50 pm

Quang Nguyen <qnguyen@diality.com>

DEN-4534: Removed extra space for function call

Options
    • -3
    • +2
    /firmware/App/Controllers/Pressures.c
    • -1
    • +1
    /firmware/App/Controllers/TemperatureSensors.c
11:53 am

Quang Nguyen <qnguyen@diality.com>

DEN-4534: Expand override macros

Options
    • -6
    • +24
    /firmware/App/Services/AlarmMgmt.c
    • -3
    • +3
    /firmware/App/Services/Reservoirs.h
    • -27
    • +485
    /firmware/App/Services/SystemCommMessages.c
    • -8
    • +69
    /firmware/App/Services/WatchdogMgmt.c
10:41 am

Quang Nguyen <qnguyen@diality.com>

DEN-4534: Removed function name from @brief

Options
    • -3
    • +4
    /firmware/App/Controllers/ConductivitySensors.c
    • -2
    • +0
    /firmware/App/Controllers/ConductivitySensors.h
    • -3
    • +3
    /firmware/App/Controllers/DrainPump.c
    • -1
    • +1
    /firmware/App/Controllers/DrainPump.h
    • -2
    • +2
    /firmware/App/Controllers/Heaters.c
    • -1
    • +1
    /firmware/App/Controllers/Pressures.c
    • -1
    • +1
    /firmware/App/Controllers/Pressures.h
    • -3
    • +3
    /firmware/App/Controllers/ROPump.c
    • -3
    • +3
    /firmware/App/Controllers/ROPump.h
    • -2
    • +2
    /firmware/App/Controllers/TemperatureSensors.c
    • -1
    • +1
    /firmware/App/Controllers/TemperatureSensors.h
    • -2
    • +2
    /firmware/App/Controllers/Valves.c
    • -1
    • +1
    /firmware/App/Controllers/Valves.h
    • -6
    • +6
    /firmware/App/Drivers/CPLD.c
    • -17
    • +17
    /firmware/App/Drivers/Comm.c
  16. … 6 more files in changeset.
9:47 am

Quang Nguyen <qnguyen@diality.com>

DEN-4534: Updated doxygen for App/Tasks

Options
    • -6
    • +12
    /firmware/App/Tasks/TaskBG.c
    • -3
    • +13
    /firmware/App/Tasks/TaskBG.h
    • -8
    • +14
    /firmware/App/Tasks/TaskGeneral.c
    • -4
    • +14
    /firmware/App/Tasks/TaskGeneral.h
    • -7
    • +12
    /firmware/App/Tasks/TaskPriority.c
    • -3
    • +13
    /firmware/App/Tasks/TaskPriority.h
    • -4
    • +11
    /firmware/App/Tasks/TaskTimer.c
    • -3
    • +13
    /firmware/App/Tasks/TaskTimer.h
Monday 24 Aug 2020
7:44 pm

Quang Nguyen <qnguyen@diality.com>

DEN-4534: Updated doxygen for App/Services

Options
    • -51
    • +43
    /firmware/App/Services/AlarmMgmt.c
    • -21
    • +18
    /firmware/App/Services/AlarmMgmt.h
    • -59
    • +58
    /firmware/App/Services/CommBuffers.c
    • -18
    • +30
    /firmware/App/Services/CommBuffers.h
    • -195
    • +193
    /firmware/App/Services/FPGA.c
    • -1
    • +11
    /firmware/App/Services/FPGA.h
    • -18
    • +19
    /firmware/App/Services/Interrupts.c
    • -50
    • +65
    /firmware/App/Services/MessagePayloads.h
    • -25
    • +31
    /firmware/App/Services/MsgQueues.c
    • -15
    • +30
    /firmware/App/Services/MsgQueues.h
    • -20
    • +19
    /firmware/App/Services/PIControllers.c
    • -17
    • +16
    /firmware/App/Services/PIControllers.h
    • -40
    • +31
    /firmware/App/Services/Reservoirs.c
    • -5
    • +4
    /firmware/App/Services/Reservoirs.h
    • -63
    • +58
    /firmware/App/Services/SystemComm.c
  16. … 5 more files in changeset.
4:53 pm

Quang Nguyen <qnguyen@diality.com>

DEN-4534: Corrected comment for public function prototypes

Options
    • -1
    • +1
    /firmware/App/Modes/ModeFault.h
    • -1
    • +1
    /firmware/App/Modes/ModeFill.h
    • -1
    • +1
    /firmware/App/Modes/ModeFlush.h
    • -1
    • +1
    /firmware/App/Modes/ModeHeatDisinfect.h
    • -1
    • +1
    /firmware/App/Modes/ModeInitPOST.h
    • -1
    • +1
    /firmware/App/Modes/ModeRecirculate.h
    • -1
    • +1
    /firmware/App/Modes/ModeService.h
    • -1
    • +1
    /firmware/App/Modes/ModeSolo.h
    • -1
    • +1
    /firmware/App/Modes/ModeStandby.h
4:47 pm

Quang Nguyen <qnguyen@diality.com>

DEN-4534: Updated doxygen for App/Modes

Options
    • -7
    • +7
    /firmware/App/Modes/ModeChemicalDisinfect.c
    • -3
    • +2
    /firmware/App/Modes/ModeChemicalDisinfect.h
    • -7
    • +4
    /firmware/App/Modes/ModeDrain.c
    • -3
    • +2
    /firmware/App/Modes/ModeDrain.h
    • -8
    • +7
    /firmware/App/Modes/ModeFault.c
    • -2
    • +1
    /firmware/App/Modes/ModeFault.h
    • -12
    • +7
    /firmware/App/Modes/ModeFill.c
    • -2
    • +1
    /firmware/App/Modes/ModeFill.h
    • -11
    • +9
    /firmware/App/Modes/ModeFlush.c
    • -2
    • +1
    /firmware/App/Modes/ModeFlush.h
    • -7
    • +7
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -2
    • +1
    /firmware/App/Modes/ModeHeatDisinfect.h
    • -16
    • +15
    /firmware/App/Modes/ModeInitPOST.c
    • -2
    • +1
    /firmware/App/Modes/ModeInitPOST.h
    • -11
    • +10
    /firmware/App/Modes/ModeRecirculate.c
  16. … 9 more files in changeset.
12:15 pm

Quang Nguyen <qnguyen@diality.com>

DEN-4633: Remove test attribute and import error

Options
    • -1
    • +0
    /firmware/App/Controllers/ConductivitySensors.c
    • -2
    • +1
    /results/Build_Status_Report.csv
    • -1706
    • +3073
    /results/VectorCAST.log
    • -2
    • +0
    /results/cppcheckError.csv
Friday 21 Aug 2020
5:25 pm

Quang Nguyen <qnguyen@diality.com>

DEN-4534: Updated doxygen comment for App/Drivers

Options
    • -43
    • +42
    /firmware/App/Drivers/CPLD.c
    • -0
    • +10
    /firmware/App/Drivers/CPLD.h
    • -60
    • +59
    /firmware/App/Drivers/Comm.c
    • -5
    • +10
    /firmware/App/Drivers/Comm.h
    • -15
    • +10
    /firmware/App/Drivers/InternalADC.c
    • -26
    • +22
    /firmware/App/Drivers/InternalADC.h
    • -13
    • +11
    /firmware/App/Drivers/SafetyShutdown.c
    • -2
    • +1
    /firmware/App/Drivers/SafetyShutdown.h
10:57 am

Quang Nguyen <qnguyen@diality.com>

DEN-4534: Updated doxygen comment for App/Controllers

Options
    • -47
    • +47
    /firmware/App/Controllers/ConductivitySensors.c
    • -8
    • +7
    /firmware/App/Controllers/ConductivitySensors.h
    • -59
    • +56
    /firmware/App/Controllers/DrainPump.c
    • -202
    • +176
    /firmware/App/Controllers/Heaters.c
    • -16
    • +16
    /firmware/App/Controllers/Heaters.h
    • -27
    • +25
    /firmware/App/Controllers/LoadCell.c
    • -8
    • +7
    /firmware/App/Controllers/LoadCell.h
    • -54
    • +51
    /firmware/App/Controllers/Pressures.c
    • -5
    • +5
    /firmware/App/Controllers/Pressures.h
    • -65
    • +59
    /firmware/App/Controllers/ROPump.c
    • -1
    • +1
    /firmware/App/Controllers/ROPump.h
    • -216
    • +200
    /firmware/App/Controllers/TemperatureSensors.c
    • -11
    • +10
    /firmware/App/Controllers/TemperatureSensors.h
    • -31
    • +26
    /firmware/App/Controllers/Valves.c
    • -9
    • +8
    /firmware/App/Controllers/Valves.h
Thursday 20 Aug 2020
5:50 pm

Quang Nguyen <qnguyen@diality.com>

Update latest build result

Options
    • -1
    • +1
    /results/Build_Status_Report.csv
    • -5659
    • +1608
    /results/VectorCAST.log
    • -46
    • +51
    /results/cppcheck.log
    • -6
    • +5
    /results/cppcheckError.csv
5:37 pm

Quang Nguyen <qnguyen@diality.com>

DEN-4322: Implement RO Rejection Ratio checking

Options
    • -47
    • +166
    /firmware/App/Controllers/ConductivitySensors.c
    • -1
    • +5
    /firmware/App/Controllers/ConductivitySensors.h
    • -11
    • +12
    /firmware/App/Modes/ModeDrain.c
    • -12
    • +13
    /firmware/App/Modes/ModeFill.c
    • -17
    • +18
    /firmware/App/Modes/ModeRecirculate.c
    • -0
    • +1
    /firmware/App/Services/MessagePayloads.h
    • -3
    • +5
    /firmware/App/Services/SystemCommMessages.c
    • -1
    • +1
    /firmware/App/Services/SystemCommMessages.h
Wednesday 19 Aug 2020
5:26 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/DGCommon.h
5:19 pm

Quang Nguyen <qnguyen@diality.com>

Fixed accelerometer integration test

Options
    • -2
    • +2
    /results/Build_Status_Report.csv
    • -2403
    • +6609
    /results/VectorCAST.log
    • -4
    • +3
    /results/cppcheckError.csv
4:34 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/DGCommon.h
4:33 pm

Quang Nguyen <qnguyen@diality.com>

Added missing handle for accelerometer test status

Options
    • -0
    • +1
    /firmware/App/Modes/ModeInitPOST.c
4:06 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/DGCommon.h
4:06 pm

Dara Navaei

Bamboo Commit: Updated the Copyright with the current year and replaced tabs with 4 spaces

Options
    • -1
    • +1
    /firmware/App/Modes/ModeInitPOST.c
4:05 pm

Quang Nguyen <qnguyen@diality.com>

Added missing break

Options
    • -0
    • +1
    /firmware/App/Modes/ModeInitPOST.c
2:56 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/DGCommon.h
2:56 pm

Dara Navaei

Bamboo Commit: Updated the Copyright with the current year and replaced tabs with 4 spaces

Options
    • -2
    • +2
    /firmware/App/Controllers/DrainPump.c
    • -2
    • +2
    /firmware/App/Controllers/Heaters.c
    • -2
    • +2
    /firmware/App/Controllers/LoadCell.c
    • -2
    • +2
    /firmware/App/Controllers/Pressures.c
    • -2
    • +2
    /firmware/App/Controllers/ROPump.c
    • -2
    • +2
    /firmware/App/Controllers/TemperatureSensors.c
    • -2
    • +2
    /firmware/App/Controllers/Valves.c
    • -1
    • +1
    /firmware/App/DGCommon.h
    • -2
    • +2
    /firmware/App/Drivers/CPLD.c
    • -2
    • +2
    /firmware/App/Drivers/Comm.c
    • -2
    • +2
    /firmware/App/Drivers/InternalADC.c
    • -1
    • +1
    /firmware/App/Drivers/SafetyShutdown.c
    • -2
    • +2
    /firmware/App/Modes/ModeDrain.c
    • -2
    • +2
    /firmware/App/Modes/ModeFill.c
    • -2
    • +2
    /firmware/App/Modes/ModeInitPOST.c
  16. … 24 more files in changeset.
2:55 pm

Sean Nash

Re-ran local test script.

Options
    • -1
    • +1
    /results/Build_Status_Report.csv
    • -257
    • +257
    /results/VectorCAST.log
2:41 pm

Sean Nash

DEN-4217: Fixed merge conflicts and Vectorcast issues.

Options
    • -2
    • +2
    /firmware/App/Controllers/DrainPump.c
    • -15
    • +16
    /firmware/App/Controllers/Heaters.c
    • -2
    • +2
    /firmware/App/Controllers/LoadCell.c
    • -53
    • +121
    /firmware/App/Controllers/Pressures.c
    • -2
    • +2
    /firmware/App/Controllers/ROPump.c
    • -286
    • +297
    /firmware/App/Controllers/TemperatureSensors.c
    • -2
    • +2
    /firmware/App/Controllers/Valves.c
    • -2
    • +2
    /firmware/App/Drivers/InternalADC.c
    • -2
    • +10
    /firmware/App/Modes/ModeDrain.c
    • -4
    • +11
    /firmware/App/Modes/ModeFill.c
    • -2
    • +6
    /firmware/App/Modes/ModeInitPOST.c
    • -5
    • +14
    /firmware/App/Modes/ModeRecirculate.c
    • -2
    • +2
    /firmware/App/Modes/ModeStandby.c
    • -2
    • +2
    /firmware/App/Modes/OperationModes.c
    • -2
    • +2
    /firmware/App/Services/AlarmMgmt.c
  16. … 17 more files in changeset.
11:31 am

Sean Nash

Updated build status from local test script.

Options
    • -1
    • +1
    /results/Build_Status_Report.csv
    • -265
    • +261
    /results/VectorCAST.log
Tuesday 18 Aug 2020
1:53 pm

Sean Nash

Updated local test script results.

Options
    • -1
    • +1
    /results/Build_Status_Report.csv
    • -275
    • +257
    /results/VectorCAST.log
8:38 am

Sean Nash

DEN-4217: Addressed code review feedback.

Options
    • -1
    • +1
    /firmware/App/Controllers/TemperatureSensors.c