dgfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 02 Nov 2020
11:41 am

Quang Nguyen <qnguyen@diality.com>

DEN-3504: Fixed UT for system comm messages

Options
    • -0
    • +1
    /firmware/App/Services/SystemCommMessages.c
    • -1
    • +1
    /results/Build_Status_Report.csv
    • -842
    • +868
    /results/VectorCAST.log
10:43 am

Quang Nguyen <qnguyen@diality.com>

DEN-3504: Addressed code reviews

Options
    • -0
    • +1
    /firmware/App/DGCommon.h
    • -1
    • +1
    /firmware/App/Modes/ModeDrain.c
10:28 am

Quang Nguyen <qnguyen@diality.com>

DEN-3504: Addressed code reviews

Options
    • -1
    • +18
    /firmware/App/Controllers/ConcentratePumps.c
    • -6
    • +23
    /firmware/App/Controllers/ConductivitySensors.c
    • -19
    • +4
    /firmware/App/Services/SystemCommMessages.c
    • -2
    • +2
    /firmware/App/Services/SystemCommMessages.h
Friday 30 Oct 2020
2:57 pm

Quang Nguyen <qnguyen@diality.com>

DEN-3504: Addressed code review

Options
    • -1
    • +1
    /firmware/App/Controllers/ConductivitySensors.c
2:55 pm

Quang Nguyen <qnguyen@diality.com>

DEN-3504: Addressed code reviews

Options
    • -6
    • +6
    /firmware/App/Controllers/ConductivitySensors.c
    • -1
    • +1
    /firmware/App/Modes/ModeDrain.c
Thursday 29 Oct 2020
4:46 pm

Quang Nguyen <qnguyen@diality.com>

DEN-3504: Added concentrate pump publish data override functions

Options
    • -2
    • +72
    /firmware/App/Controllers/ConcentratePumps.c
    • -0
    • +2
    /firmware/App/Controllers/ConcentratePumps.h
    • -0
    • +4
    /firmware/App/Services/SystemComm.c
    • -0
    • +32
    /firmware/App/Services/SystemCommMessages.c
    • -0
    • +3
    /firmware/App/Services/SystemCommMessages.h
Wednesday 28 Oct 2020
9:17 pm

Dara Navaei

DEN-3421 made modification to the UVReactors module and started the thermistors driver

Options
    • -1
    • +0
    /firmware/App/Controllers/Fans.h
    • -4
    • +2
    /firmware/App/Controllers/TemperatureSensors.c
    • -0
    • +365
    /firmware/App/Controllers/Thermistors.c
    • -0
    • +57
    /firmware/App/Controllers/Thermistors.h
    • -5
    • +27
    /firmware/App/Controllers/UVReactors.c
    • -2
    • +2
    /firmware/App/Controllers/UVReactors.h
    • -0
    • +3
    /firmware/App/Services/AlarmMgmt.h
    • -0
    • +28
    /firmware/App/Services/SystemCommMessages.c
    • -2
    • +6
    /firmware/App/Services/SystemCommMessages.h
Monday 26 Oct 2020
9:37 am

Dara Navaei

DEN-3421 fixed a doxygen header function

Options
    • -2
    • +2
    /firmware/App/Modes/ModeStandby.c
9:24 am

Dara Navaei

DEN-3421 addressed the code reivew comments

Options
    • -2
    • +0
    /firmware/App/Controllers/DrainPump.c
    • -3
    • +0
    /firmware/App/DGCommon.h
    • -6
    • +12
    /firmware/App/Modes/ModeStandby.c
9:02 am

Dara Navaei

DEN-3421 addressed code review comments and worked on UV reactors driver

Options
    • -0
    • +1
    /firmware/App/Controllers/DrainPump.c
    • -6
    • +6
    /firmware/App/Controllers/ROPump.c
    • -2
    • +0
    /firmware/App/Controllers/ROPump.h
    • -1
    • +1
    /firmware/App/Controllers/TemperatureSensors.c
    • -38
    • +371
    /firmware/App/Controllers/UVReactors.c
    • -8
    • +9
    /firmware/App/Controllers/UVReactors.h
    • -1
    • +1
    /firmware/App/Drivers/SafetyShutdown.c
    • -8
    • +1
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -0
    • +1
    /firmware/App/Services/AlarmMgmt.h
    • -0
    • +8
    /firmware/App/Services/SystemComm.c
    • -0
    • +63
    /firmware/App/Services/SystemCommMessages.c
    • -0
    • +6
    /firmware/App/Services/SystemCommMessages.h
Thursday 22 Oct 2020
5:38 pm

Dara Navaei

DEN-3421 addressed code review comments and added GIO ports for UV reactors

Options
    • -10
    • +19
    /firmware/App/Controllers/DrainPump.c
    • -3
    • +3
    /firmware/App/Controllers/DrainPump.h
    • -11
    • +16
    /firmware/App/Controllers/ROPump.c
    • -1
    • +13
    /firmware/App/Controllers/ROPump.h
    • -23
    • +174
    /firmware/App/Controllers/UVReactors.c
    • -7
    • +25
    /firmware/App/Controllers/UVReactors.h
    • -3
    • +3
    /firmware/App/DGCommon.h
    • -28
    • +12
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -1
    • +0
    /firmware/App/Modes/ModeHeatDisinfect.h
    • -0
    • +16
    /firmware/App/Modes/ModeStandby.c
    • -0
    • +2
    /firmware/App/Modes/ModeStandby.h
    • -0
    • +1
    /firmware/App/Services/AlarmMgmt.h
    • -10
    • +0
    /firmware/App/Services/MessagePayloads.h
    • -12
    • +32
    /firmware/App/Services/SystemCommMessages.c
    • -3
    • +8
    /firmware/App/Services/SystemCommMessages.h
  16. … 7 more files in changeset.
11:02 am

Quang Nguyen <qnguyen@diality.com>

DEN-3504: Added DG operation mode change request

Options
    • -13
    • +9
    /firmware/App/Modes/OperationModes.c
    • -0
    • +4
    /firmware/App/Services/SystemComm.c
    • -0
    • +29
    /firmware/App/Services/SystemCommMessages.c
    • -0
    • +3
    /firmware/App/Services/SystemCommMessages.h
10:55 am

Quang Nguyen <qnguyen@diality.com>

DEN-3504: Added concentrate pump monitor and controller

Options
    • -0
    • +408
    /firmware/App/Controllers/ConcentratePumps.c
    • -0
    • +66
    /firmware/App/Controllers/ConcentratePumps.h
    • -0
    • +3
    /firmware/App/Modes/ModeFill.c
    • -0
    • +3
    /firmware/App/Services/AlarmMgmt.h
    • -6
    • +138
    /firmware/App/Services/FPGA.c
    • -1
    • +7
    /firmware/App/Services/FPGA.h
    • -0
    • +4
    /firmware/App/Services/SystemComm.c
    • -64
    • +132
    /firmware/App/Services/SystemCommMessages.c
    • -0
    • +6
    /firmware/App/Services/SystemCommMessages.h
    • -1
    • +6
    /firmware/App/Tasks/TaskGeneral.c
    • -0
    • +2
    /firmware/source/sys_main.c
9:55 am

Quang Nguyen <qnguyen@diality.com>

DEN-3504: Added handler to concentrate pump state change request

Options
    • -0
    • +4
    /firmware/App/Services/SystemComm.c
    • -0
    • +34
    /firmware/App/Services/SystemCommMessages.c
    • -0
    • +3
    /firmware/App/Services/SystemCommMessages.h
9:52 am

Quang Nguyen <qnguyen@diality.com>

DEN-3504: Moved target fill reached logic inside reservoir module

Options
    • -8
    • +2
    /firmware/App/Modes/ModeFill.c
    • -46
    • +68
    /firmware/App/Services/Reservoirs.c
    • -3
    • +2
    /firmware/App/Services/Reservoirs.h
Monday 19 Oct 2020
5:33 pm

Dara Navaei

DEN-3421 Addressed the code review comments. Continued testing the state machine

Options
    • -4
    • +3
    /firmware/App/Controllers/DrainPump.c
    • -1
    • +1
    /firmware/App/Controllers/ROPump.c
    • -3
    • +3
    /firmware/App/Controllers/ROPump.h
    • -102
    • +109
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -2
    • +2
    /firmware/App/Modes/ModeInitPOST.c
    • -1
    • +1
    /firmware/App/Modes/ModeRecirculate.c
    • -2
    • +2
    /firmware/App/Modes/OperationModes.c
    • -19
    • +53
    /results/Build_Status_Report.csv
    • -3474
    • +10774
    /results/VectorCAST.log
    • -48
    • +51
    /results/cppcheck.log
    • -13
    • +23
    /results/cppcheckError.csv
10:56 am

Quang Nguyen <qnguyen@diality.com>

DEN-3504: Added alarms for fill mode

Options
    • -2
    • +1
    /firmware/App/Controllers/ConductivitySensors.c
    • -0
    • +2
    /firmware/App/Controllers/ConductivitySensors.h
    • -0
    • +1
    /firmware/App/DGCommon.h
    • -20
    • +87
    /firmware/App/Modes/ModeFill.c
    • -2
    • +0
    /firmware/App/Modes/ModeFill.h
Friday 16 Oct 2020
5:33 pm

Quang Nguyen <qnguyen@diality.com>

DEN-3504: Change persistent count to persistent period

Options
    • -10
    • +10
    /firmware/App/Controllers/Pressures.c
    • -7
    • +7
    /firmware/App/Controllers/TemperatureSensors.c
Thursday 15 Oct 2020
12:00 pm

Quang Nguyen <qnguyen@diality.com>

DEN-3504: Added unit tests and integration tests

Options
    • -5
    • +2
    /results/Build_Status_Report.csv
    • -1496
    • +3226
    /results/VectorCAST.log
    • -47
    • +50
    /results/cppcheck.log
    • -75
    • +75
    /results/cppcheckError.csv
9:19 am

Quang Nguyen <qnguyen@diality.com>

DEN-3504: Added software reset handler

Options
    • -0
    • +4
    /firmware/App/Services/SystemComm.c
    • -2
    • +33
    /firmware/App/Services/SystemCommMessages.c
    • -0
    • +3
    /firmware/App/Services/SystemCommMessages.h
Thursday 08 Oct 2020
5:56 pm

Dara Navaei

DEN-3421 merged master

Options
    • -45
    • +67
    /firmware/App/Controllers/DrainPump.c
    • -3
    • +3
    /firmware/App/Controllers/DrainPump.h
    • -46
    • +154
    /firmware/App/Controllers/ROPump.c
    • -4
    • +7
    /firmware/App/Controllers/ROPump.h
    • -431
    • +414
    /firmware/App/Controllers/TemperatureSensors.c
    • -3
    • +9
    /firmware/App/DGCommon.h
    • -10
    • +14
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -2
    • +3
    /firmware/App/Modes/ModeHeatDisinfect.h
    • -21
    • +43
    /firmware/App/Modes/ModeInitPOST.c
    • -24
    • +33
    /firmware/App/Modes/ModeRecirculate.c
    • -0
    • +141
    /firmware/App/Services/MessagePayloads.h
    • -40
    • +35
    /firmware/App/Services/PIControllers.c
    • -15
    • +14
    /firmware/App/Services/PIControllers.h
    • -353
    • +402
    /firmware/App/Services/SystemComm.c
    • -37
    • +43
    /firmware/App/Services/SystemComm.h
    • -367
    • +919
    /firmware/App/Services/SystemCommMessages.c
    • -4
    • +49
    /firmware/App/Services/SystemCommMessages.h
4:09 pm

Quang Nguyen <qnguyen@diality.com>

DEN-3504: Refactor load cell and reservoirs modules

Options
    • -45
    • +58
    /firmware/App/Controllers/LoadCell.c
    • -1
    • +2
    /firmware/App/Controllers/LoadCell.h
    • -32
    • +4
    /firmware/App/Modes/ModeDrain.c
    • -0
    • +4
    /firmware/App/Modes/ModeStandby.c
    • -43
    • +133
    /firmware/App/Services/Reservoirs.c
    • -4
    • +16
    /firmware/App/Services/Reservoirs.h
    • -3
    • +3
    /firmware/App/Services/SystemCommMessages.c
Wednesday 07 Oct 2020
2:01 pm

Dara Navaei

DEN-3421 updated the code

Options
    • -1
    • +1
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -1
    • +1
    /firmware/App/Services/PIControllers.c
Tuesday 06 Oct 2020
4:37 pm

Quang Nguyen <qnguyen@diality.com>

DEN-3504: Added monitor for conductivity sensors CD1 and CD2

Options
    • -23
    • +235
    /firmware/App/Controllers/ConductivitySensors.c
    • -0
    • +13
    /firmware/App/Controllers/ConductivitySensors.h
    • -3
    • +3
    /firmware/App/DGCommon.h
    • -0
    • +5
    /firmware/App/Services/FPGA.h
    • -8
    • +0
    /firmware/App/Services/MessagePayloads.h
    • -1
    • +3
    /firmware/App/Services/SystemCommMessages.c
    • -1
    • +1
    /firmware/App/Services/SystemCommMessages.h
10:43 am

Quang Nguyen <qnguyen@diality.com>

DEN-3504: Added auto calibration offset for loadcell

Options
    • -15
    • +25
    /firmware/App/Controllers/LoadCell.c
    • -0
    • +1
    /firmware/App/Controllers/LoadCell.h
    • -3
    • +26
    /firmware/App/Modes/ModeDrain.c
Wednesday 30 Sep 2020
2:57 pm

Quang Nguyen <qnguyen@diality.com>

DEN-3504: Put doxygen comment inside build switch

Options
    • -63
    • +49
    /firmware/App/Drivers/Comm.c
    • -6
    • +2
    /firmware/App/Services/SystemComm.c
Thursday 24 Sep 2020
1:40 pm

Sean Nash

Fixed EMC build issue with trimmer heater control.

Options
    • -9
    • +9
    /firmware/App/Controllers/Heaters.c
10:40 am

Quang Nguyen <qnguyen@diality.com>

DEN-3504: Added @details and remove extra space for inputs and outputs

Options
    • -39
    • +26
    /firmware/App/Controllers/ConductivitySensors.c
    • -48
    • +32
    /firmware/App/Controllers/DrainPump.c
    • -78
    • +52
    /firmware/App/Controllers/Heaters.c
    • -24
    • +16
    /firmware/App/Controllers/LoadCell.c
    • -44
    • +30
    /firmware/App/Controllers/Pressures.c
    • -63
    • +42
    /firmware/App/Controllers/ROPump.c
    • -66
    • +44
    /firmware/App/Controllers/TemperatureSensors.c
    • -38
    • +26
    /firmware/App/Controllers/Valves.c
    • -18
    • +12
    /firmware/App/Drivers/CPLD.c
    • -51
    • +34
    /firmware/App/Drivers/Comm.c
    • -12
    • +8
    /firmware/App/Drivers/InternalADC.c
    • -15
    • +10
    /firmware/App/Drivers/SafetyShutdown.c
    • -12
    • +8
    /firmware/App/Modes/ModeChemicalDisinfect.c
    • -15
    • +10
    /firmware/App/Modes/ModeDrain.c
    • -12
    • +8
    /firmware/App/Modes/ModeFault.c
  16. … 24 more files in changeset.
Wednesday 23 Sep 2020
4:13 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/DGCommon.h
4:13 pm

Dara Navaei

Bamboo Commit: Updated the Copyright with the current year and replaced tabs with 4 spaces

Options
    • -1
    • +1
    /firmware/App/Controllers/DrainPump.c
    • -1
    • +1
    /firmware/App/Controllers/Heaters.c
    • -1
    • +1
    /firmware/App/Controllers/Pressures.c
    • -1
    • +1
    /firmware/App/Controllers/Pressures.h
    • -1
    • +1
    /firmware/App/Controllers/ROPump.c
    • -1
    • +1
    /firmware/App/Controllers/TemperatureSensors.c
    • -1
    • +1
    /firmware/App/Modes/ModeChemicalDisinfect.c
    • -1
    • +1
    /firmware/App/Modes/ModeFill.h
    • -1
    • +1
    /firmware/App/Modes/ModeFlush.c
    • -1
    • +1
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -1
    • +1
    /firmware/App/Modes/ModeRecirculate.h
    • -1
    • +1
    /firmware/App/Services/FPGA.c
    • -1
    • +1
    /firmware/App/Services/WatchdogMgmt.c
    • -1
    • +1
    /firmware/App/Tasks/TaskTimer.c