dgfirmware / firmware / App / Controllers

ConductivitySensors.c

Clone Tools

Stats

Commits this week: 0
Total Committers: 10
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 28 Mar 2023
4:48 pm

Dara Navaei

DEN-15014 addressed the code review comments

Options
    • -1
    • +1
    ./ConductivitySensors.c
  2. … 5 more files in changeset.
4:47 pm

Dara Navaei

Done

Done

4:43 pm

Dara Navaei

Changed it to TRUE/FALSE.

Changed it to TRUE/FALSE.

4:43 pm

Dara Navaei

Updated the code.

Updated the code.

4:42 pm

Dara Navaei

Done

Done

4:17 pm

Dara Navaei

Done

Done

4:17 pm

Dara Navaei

Done

Done

4:15 pm

Dara Navaei

Done

Done

4:13 pm

Dara Navaei

Done

Done

4:10 pm

Sean Nash

Prefer to say RO only != TRUE so that any other value than 1 will cause RR alarm to be enforced.

Prefer to say RO only != TRUE so that any other value than 1 will cause RR alarm to be enforced.

4:08 pm

Sean Nash

Needs param so caller can set it to FALSE too?

Needs param so caller can set it to FALSE too?

4:07 pm

Sean Nash

Doesn't look like this list is complete. In my opinion, init functions should be allowed to generalize here (e.g. Fill mode variables initialized.).

Doesn't look like this list is complete. In my opinion, init functions should be allowed to generalize here (e.g. Fill mode variables initialized.).

4:04 pm

Sean Nash

I don't think we need to ack/nak since we always respond with response msg.

I don't think we need to ack/nak since we always respond with response msg.

4:02 pm

Sean Nash

Need else for if FALSE - disable RO only.

Need else for if FALSE - disable RO only.

4:02 pm

Sean Nash

Should take a BOOL param and set RO only flag to given BOOL. As it is, you can only set to TRUE - never FALSE.

Should take a BOOL param and set RO only flag to given BOOL. As it is, you can only set to TRUE - never FALSE.

4:00 pm

Sean Nash

Standby Solo too? In case Dialin sends by proxy.

Standby Solo too? In case Dialin sends by proxy.

3:59 pm

Sean Nash

This is really a BOOL (FALSE/TRUE). Why not make result a BOOL instead of U32?

This is really a BOOL (FALSE/TRUE). Why not make result a BOOL instead of U32?

3:54 pm

Sean Nash

This message is sent by UI to DG. Should be MSG_ID_UI_SET_DG_RO_ONLY_MODE.

This message is sent by UI to DG. Should be MSG_ID_UI_SET_DG_RO_ONLY_MODE.

11:16 am

Dara Navaei

Merged staging

Options
    • -1
    • +2
    ./ConductivitySensors.c
  2. … 7 more files in changeset.
Monday 27 Mar 2023
11:29 am

Dara Navaei

DEN-15014 added code to support RO only mode

Options
    • -3
    • +25
    ./ConductivitySensors.c
  2. … 6 more files in changeset.
10:43 am

Sean Nash

Can we rename variable to reflect it is a timer counter at least?

Can we rename variable to reflect it is a timer counter at least?

10:31 am

wbracken  (deleted user)

The variable that define is being compared to is valveStateMismatchCounter which is why I called it such.

The variable that define is being compared to is valveStateMismatchCounter which is why I called it such.

9:36 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:35 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:35 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:34 am

Sean Nash

Yes, and #define has "COUNT" in its name which was my point.

Yes, and #define has "COUNT" in its name which was my point.

Friday 24 Mar 2023
10:18 am

Dara Navaei

Thursday 23 Mar 2023
2:01 pm

Dara Navaei

DG-DEN-15014_DG HD Dev HD DG Dvt Update Part 11
DG-DEN-15014_DG HD Dev HD DG Dvt Update Part 11
Wednesday 22 Mar 2023
2:25 pm

wbracken  (deleted user)

Corrected

Corrected

2:23 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-14646 Updates per code review.

Options
    • -7
    • +3
    ./ConductivitySensors.c