dgfirmware / firmware / App / Controllers

ConductivitySensors.c

Clone Tools

Stats

Commits this week: 0
Total Committers: 10
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 31 Mar 2023
7:17 pm

Dara Navaei

DEN-14999: merged staging

Options
    • -25
    • +49
    ./ConductivitySensors.c
  2. … 5 more files in changeset.
4:02 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./ConductivitySensors.c
  2. … 8 more files in changeset.
3:35 pm

wbracken  (deleted user)

3:32 pm

jtaylor  (deleted user) , Darren Cox and Sean Nash

3:18 pm

Michael Garthwaite

1:45 pm

Darren Cox

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

1:44 pm

jtaylor  (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

1:43 pm

jtaylor  (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

1:42 pm

wbracken  (deleted user)

Corrected

Corrected

1:42 pm

wbracken  (deleted user)

Corrected

Corrected

1:42 pm

wbracken  (deleted user)

Corrected

Corrected

1:39 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-14646 Correction per code review comments

Options
    • -3
    • +2
    ./ConductivitySensors.c
1:03 pm

Darren Cox

Does TODO need to be resolved?

Does TODO need to be resolved?

1:01 pm

jtaylor  (deleted user)

Extra space before the last paren.

Extra space before the last paren.

12:59 pm

jtaylor  (deleted user)

Missing space.

Missing space.

9:14 am

Michael Garthwaite

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

9:03 am

Sean Nash

I think VPi is closed during standby mode, so not sure why we want to check inlet conductivity in this mode. I imagine new system would get installed by service - would need some kind of priming do...

I think VPi is closed during standby mode, so not sure why we want to check inlet conductivity in this mode.
I imagine new system would get installed by service - would need some kind of priming done in service mode, so I'm not worried about that.

8:54 am

Michael Garthwaite

will these alarms trigger with open air? Ex: if a user has a device shipped to them, will they be greeted with conductivity alarms on first power up before any water has ran through the system? If...

will these alarms trigger with open air?

Ex: if a user has a device shipped to them, will they be greeted with conductivity alarms on first power up before any water has ran through the system? If so, how will they be able to fix it?

Thursday 30 Mar 2023
8:18 pm

Dara Navaei

DEN-14999 updated the code based on the alarms table update

Options
    • -2
    • +1
    ./ConductivitySensors.c
  2. … 8 more files in changeset.
7:04 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

7:04 pm

Dara Navaei

Merged DEN-14999

Options
    • -5
    • +28
    ./ConductivitySensors.c
  2. … 5 more files in changeset.
2:36 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-14646 Changes per code review

Options
    • -1
    • +1
    ./ConductivitySensors.c
  2. … 1 more file in changeset.
1:42 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

Merge branch 'staging' into DEN-14646-fpga-alarm-properties-and-timing-3

Options
    • -4
    • +26
    ./ConductivitySensors.c
1:35 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-14646 Update per code review

Options
    • -1
    • +1
    ./ConductivitySensors.c
11:35 am

Dara Navaei

DEN-14999 merged the remote changes and updated the fill mode with the acid conductivity values

Options
    • -1
    • +2
    ./ConductivitySensors.c
  2. … 1 more file in changeset.
11:35 am

Sean Nash

I don't see it, but resolving anyway. RESOLVED in CODE WALKTHROUGH.

I don't see it, but resolving anyway.
RESOLVED in CODE WALKTHROUGH.

Wednesday 29 Mar 2023
2:52 pm

Sean Nash

Spaces inside (). And explicit condition (i.e. ( TRUE == isConvNotValid ).

Spaces inside (). And explicit condition (i.e. ( TRUE == isConvNotValid ).

11:25 am

wbracken  (deleted user)

Corrected

Corrected

8:39 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./ConductivitySensors.c
  2. … 7 more files in changeset.
8:37 am

Dara Navaei