Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-13834 addressed the code review comments

  1. … 15 more files in changeset.
Done.

Done.

Removed the #define.

Removed the #define.

Remove #ifndef and remove the center condition (msgID <= END_OF_MSG_IDS -1).

Remove #ifndef and remove the center condition (msgID <= END_OF_MSG_IDS -1).

Done.

Done.

Done.

Done.

Done.

Done.

This is part of the SRSs. This alarm is uncommented and is running.

This is part of the SRSs. This alarm is uncommented and is running.

Done.

Done.

Done.

Done.

This is not called in the ModeInitPOST. Right now, it does not do anything.

This is not called in the ModeInitPOST. Right now, it does not do anything.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Please see the comments.

Please see the comments.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

These are implemented like HD is implemented.

These are implemented like HD is implemented.

Done.

Done.

Done.

Done.

For the overrides, if the sensor is not in range, the command is just ignored.

For the overrides, if the sensor is not in range, the command is just ignored.

For the overrides, if the sensor is not in range, the command is just ignored.

For the overrides, if the sensor is not in range, the command is just ignored.

But, since there is not loop, you can arrange default to be reached in vectorcast - so no need to have #ifndef.

But, since there is not loop, you can arrange default to be reached in vectorcast - so no need to have #ifndef.

I guess what I'm asking is - can loops be combined? Is there any reason not to convert and monitor each sensor before moving to next?

I guess what I'm asking is - can loops be combined? Is there any reason not to convert and monitor each sensor before moving to next?

Done.

Done.

Done.

Done.