Activity dgfirmware/firmware/App/Controllers/TemperatureSensors.c

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	10
Last Commit:	19 Nov
Commits this week:	0

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Wednesday 23 Feb 2022

3:00 pm

Hung Nguyen <hnguyen@diality.com>

More
a8f6e75
changed 2 files
DEN-11928-dg-conductivity-update-den-tbd, DEN-12224-dg_hd_dev-switches-monitor and 201 more DG-DEN-11928-1

DEN-11928 Updated temperature out of range test

- -3
- +6
./TemperatureSensors.c
- History
- Source
- Diff
./TemperatureSensors.c
… 1 more file in changeset.

2:08 pm

Hung Nguyen <hnguyen@diality.com>

More
de90339
changed 3 files
DEN-11928-dg-conductivity-update-den-tbd, DEN-12224-dg_hd_dev-switches-monitor and 201 more DG-DEN-11928-1

DEN-11928 Updated temperature, rejection ratio, CPo with new values

- -6
- +26
./TemperatureSensors.c
- History
- Source
- Diff
./TemperatureSensors.c
… 2 more files in changeset.

Tuesday 22 Feb 2022

5:16 pm

Michael Garthwaite

More
Re: DG-DEN-11750-1
commented on review

Could we move these fields outside of the for loop? They dont need to be initialized NUM_OF_FANS_NAMES times.

Could we move these fields outside of the for loop? They dont need to be initialized NUM_OF_FANS_NAMES times.

5:13 pm

Michael Garthwaite

More
Re: DG-DEN-11750-1
commented on review

If the DG is broadcasting these raw values, shouldn't Dialin be sync'd as well to handle these new fields?

If the DG is broadcasting these raw values, shouldn't Dialin be sync'd as well to handle these new fields?

5:07 pm

Michael Garthwaite

More
Re: DG-DEN-11750-1
commented on review

All the new timer counters no longer are initialized to 0. I understand that they get set in their respective init()'s to the timer counter, but was this intentional?

All the new timer counters no longer are initialized to 0. I understand that they get set in their respective init()'s to the timer counter, but was this intentional?

5:05 pm

Michael Garthwaite

More
Re: DG-DEN-11750-1
commented on review

We should probably keep the = 0;

We should probably keep the = 0;

4:01 pm

Dara Navaei

More
Re: DG-DEN-11750-1
commented on review

Most of the files are VectorCAST that has been brought back from Code Clinic. Look at the files but they are auto generated so they are mostly passing through.

Most of the files are VectorCAST that has been brought back from Code Clinic. Look at the files but they are auto generated so they are mostly passing through.

3:57 pm

Michael Garthwaite

More
Re: DG-DEN-11750-1
commented on review

Notices the 170 files that need to be reviewed https://c.tenor.com/RXMxqsRKEn0AAAAC/this-is-fine.gif

Notices the 170 files that need to be reviewed

https://c.tenor.com/RXMxqsRKEn0AAAAC/this-is-fine.gif

3:47 pm

Dara Navaei

More
DG-DEN-11750-1
started review

DG-DEN-11750_DG Dev Dialysate Temperature Control Tune Up

DG-DEN-11750_DG Dev Dialysate Temperature Control Tune Up

Friday 04 Feb 2022

11:03 am

Dara Navaei

More
e7dd4d4
changed 8 files
DEN-14902-bootloader-for-dg, cdc-demo-branch-218 and 3 more

Merge branch 'DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up' into develop

- -1
- +1
./TemperatureSensors.c
- History
- Source
- Diff
./TemperatureSensors.c
… 7 more files in changeset.

10:58 am

Dara Navaei

More
986abcf
changed 19 files
DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up, DEN-11928-dg-conductivity-update-den-tbd and 203 more DG-DEN-11750-1

DEN-11750 updated the publish staggers

- -1
- +1
./TemperatureSensors.c
- History
- Source
- Diff
./TemperatureSensors.c
… 18 more files in changeset.

Thursday 03 Feb 2022

5:48 pm

Dara Navaei

More
72feea3
changed 4 files
DEN-14902-bootloader-for-dg, cdc-demo-branch-218 and 3 more

Merge branch 'DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up' into develop

- -1
- +1
./TemperatureSensors.c
- History
- Source
- Diff
./TemperatureSensors.c
… 3 more files in changeset.

5:47 pm

Dara Navaei

More
f3a37b7
changed 10 files
DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up, DEN-11928-dg-conductivity-update-den-tbd and 203 more DG-UCOMMITS-37

DEN-11750 updated the publish times

- -1
- +1
./TemperatureSensors.c
- History
- Source
- Diff
./TemperatureSensors.c
… 9 more files in changeset.

Tuesday 01 Feb 2022

4:37 pm

Dara Navaei

More
7ce76eb
changed 13 files
DEN-14902-bootloader-for-dg, cdc-demo-branch-218 and 3 more

Merged DEN-11750

- -2
- +3
./TemperatureSensors.c
- History
- Source
- Diff
./TemperatureSensors.c
… 12 more files in changeset.

Thursday 27 Jan 2022

6:53 pm

Dara Navaei

More
31aa23b
changed 20 files
DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up, DEN-11928-dg-conductivity-update-den-tbd and 203 more DG-UCOMMITS-37

DEN-11750 updated the publish counters

- -2
- +3
./TemperatureSensors.c
- History
- Source
- Diff
./TemperatureSensors.c
… 19 more files in changeset.

Sunday 16 Jan 2022

11:23 am

Dara Navaei

More
adeea59
changed 17 files
DEN-14902-bootloader-for-dg, cdc-demo-branch-218 and 3 more

Merged DEN-11750 and resolved the merge conflicts

- -7
- +15
./TemperatureSensors.c
- History
- Source
- Diff
./TemperatureSensors.c
… 16 more files in changeset.

11:14 am

Dara Navaei

More
44222e8
changed 12 files
DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up, DEN-11928-dg-conductivity-update-den-tbd and 203 more DG-UCOMMITS-37 DG-DEN-11750-1 DG-UCOMMITS-38

DEN-11750 updated the NV data and the drivers

- -5
- +13
./TemperatureSensors.c
- History
- Source
- Diff
./TemperatureSensors.c
… 11 more files in changeset.

Wednesday 05 Jan 2022

8:16 pm

Dara Navaei

More
025612a
changed 95 files
DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up, DEN-11928-dg-conductivity-update-den-tbd and 204 more DG-UCOMMITS-37

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -2
- +2
./TemperatureSensors.c
- History
- Source
- Diff
./TemperatureSensors.c
… 94 more files in changeset.

7:09 pm

Dara Navaei

More
DG-DEN-11114-1
Closed

5:21 pm

hnguyen (deleted user) and Sean Nash

More
DG-DEN-11114-1
finished reviewing

10:30 am

hnguyen (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

10:30 am

hnguyen (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

10:29 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:29 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:28 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:28 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:27 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:26 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:26 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:25 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2025-12-19 08:44 -0800