TemperatureSensors.c

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-13834 removed and addressed some of the TODOs in the code base and renamed the heaters' voltage enums for better clarification. Updated the DG RO volume generated calculations

  1. … 19 more files in changeset.
Merge branch 'DEN-13786-hd_dg_dev-s78_bb' into develop

DEN-13768 DEN-13572 Corrected getTemperatureValue for V3 temperature overrides.

Fixed a merge issue

Merged DEN-13460

Merge branch 'DEN-13460-dg_hd_dev-hd_dg_dvt-update-part-2' into develop

  1. … 5 more files in changeset.
Line 1902 is the same check but reverses the order.

Line 1902 is the same check but reverses the order.

This code is un-commented.

This code is un-commented.

Done.

Done.

In in DEN-13834.

In in DEN-13834.

Done.

Done.

Added TODO to un-comment this line of code.

Added TODO to un-comment this line of code.

"FAPI_CHECK_FSM_READY_BUSY" is a macro.

"FAPI_CHECK_FSM_READY_BUSY" is a macro.

Done.

Done.

DEN-13460 updated the heaters driver. Moved the heaters data broadcast structure to the fwcommon so the HD can use it too. Updated the temperature sensors FPGA persistent alarm

  1. … 3 more files in changeset.
Done.

Done.

Merge branch 'DEN-13427-sw_dev-sprint-75_mg' into develop

  1. … 1 more file in changeset.
DEN-13427: DIAL-201. Updated temp sensors broadcast message to include thd RTD.

  1. … 1 more file in changeset.
Merge branch 'DEN-13786-hd_dg_dev-s78_bb' into develop

# Conflicts:

# firmware/App/Controllers/DialysateFlow.c

Commented out alarm 196

Align on "*" maybe?

Align on "*" maybe?

What is the value of SEMAPHORE_IN_USE_TIMEOUT_MS? The timeout appears to only be check when getSemaphore is called. Seems like you could acquire the semaphore and the process that acquired the sema...

What is the value of SEMAPHORE_IN_USE_TIMEOUT_MS? The timeout appears to only be check when getSemaphore is called. Seems like you could acquire the semaphore and the process that acquired the semaphore could hold onto it for a time much longer than SEMAPHORE_IN_USE_TIMEOUT.

Should this function handle invalid hex characters?

Should this function handle invalid hex characters?

Set "status" to FALSE.

Set "status" to FALSE.

Should this be removed?

Should this be removed?

Should variables in if be reversed?

Should variables in if be reversed?

Should this be in or not?

Should this be in or not?

Some values have "U"?

Some values have "U"?

Are we moving away from initializing via definition?

Are we moving away from initializing via definition?

Merged DEN-13460

  1. … 6 more files in changeset.