dgfirmware / firmware / App / Controllers

TemperatureSensors.c

Clone Tools

Stats

Commits this week: 0
Total Committers: 10
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 20 Sep 2022
10:22 am

Sean Nash

Restore this blank line.

Restore this blank line.

10:21 am

Sean Nash

This is legal, but odd looking. Can we define this structure type at top of module and have a normal declaration for baroCoeffs here?

This is legal, but odd looking. Can we define this structure type at top of module and have a normal declaration for baroCoeffs here?

10:19 am

Sean Nash

Can we add a comment explaining why these temp sensors are monitored and the rest are ignored?

Can we add a comment explaining why these temp sensors are monitored and the rest are ignored?

10:16 am

Sean Nash

Add blank line between declaration and code.

Add blank line between declaration and code.

8:59 am

Dong Nguyen

Already uncommented.

Already uncommented.

8:57 am

Sean Nash

Keep blank line.

Keep blank line.

8:51 am

Dong Nguyen

Already removed the marge markers.

Already removed the marge markers.

8:50 am

Dong Nguyen

Already removed marge markers.

Already removed marge markers.

Monday 19 Sep 2022
3:10 pm

Darren Cox

F32 needs 0.0F init value.

F32 needs 0.0F init value.

2:49 pm

Dong Nguyen

Already removed the merge markers.

Already removed the merge markers.

2:48 pm

Dong Nguyen

Already removed the merge markers.

Already removed the merge markers.

2:46 pm

Dong Nguyen

Already removed the merge markers.

Already removed the merge markers.

2:44 pm

Dong Nguyen

Already removed merge markers.

Already removed merge markers.

2:41 pm

Dong Nguyen

Already removed the merge markers .

Already removed the merge markers .

1:06 pm

Darren Cox

Merge markers need to be removed.

Merge markers need to be removed.

1:06 pm

Darren Cox

Remove this test code.

Remove this test code.

1:05 pm

Darren Cox

No explanation for commenting this function.

No explanation for commenting this function.

1:03 pm

Darren Cox

Merge markers need to be removed.

Merge markers need to be removed.

1:03 pm

Darren Cox

Merge markers need to be removed.

Merge markers need to be removed.

1:02 pm

Darren Cox

Merge markers need to be removed.

Merge markers need to be removed.

1:01 pm

Darren Cox

Merge markers need to be removed.

Merge markers need to be removed.

1:01 pm

Darren Cox

Merge markers need to be removed.

Merge markers need to be removed.

1:00 pm

Darren Cox

Merge markers need to be removed.

Merge markers need to be removed.

1:00 pm

Darren Cox

These merge markers will cause a build failure. Need to be removed.

These merge markers will cause a build failure. Need to be removed.

9:41 am

Dara Navaei

DG-DEN-13834_DG HD Dev HD DG Dvt Update Part 3
DG-DEN-13834_DG HD Dev HD DG Dvt Update Part 3
Friday 16 Sep 2022
11:08 am

Sean Nash

Probably a good idea for consistency, but not necessary. Where we need to add the 'F' suffix to floating point literals is when the literal will not be typed. Here, we are assigning 0.0 to an F32 t...

Probably a good idea for consistency, but not necessary. Where we need to add the 'F' suffix to floating point literals is when the literal will not be typed. Here, we are assigning 0.0 to an F32 typed variable so it will be typed properly. A #define may or may not be typed depending on how it's used. If it's used in a mathematical expression, the compiler will make it max precision (double) if we don't explicitly add the 'F' suffix and that can cause some problems with the precision in the math.

10:31 am

Sean Nash

Remove blank line.

Remove blank line.

Monday 12 Sep 2022
4:24 pm

Darren Cox

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

4:24 pm

Darren Cox

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

4:23 pm

Darren Cox

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH