dgfirmware / firmware / App / Controllers

TemperatureSensors.c

Clone Tools

Stats

Commits this week: 0
Total Committers: 10
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 21 Sep 2022
5:58 pm

Dara Navaei

DEN-13460 addressed the code review comments

Options
    • -14
    • +22
    ./TemperatureSensors.c
  2. … 7 more files in changeset.
5:50 pm

Dara Navaei

Done.

Done.

5:37 pm

Dara Navaei

Done.

Done.

5:35 pm

Dara Navaei

Done.

Done.

5:33 pm

Dara Navaei

Added the VectorCAST #define.

Added the VectorCAST #define.

5:31 pm

Dara Navaei

Done.

Done.

5:30 pm

Dara Navaei

Done.

Done.

5:26 pm

Dara Navaei

Done.

Done.

5:23 pm

Dara Navaei

Done.

Done.

5:23 pm

Dara Navaei

Done.

Done.

5:22 pm

Dara Navaei

Done.

Done.

5:21 pm

Dara Navaei

Done.

Done.

5:20 pm

Dara Navaei

Done.

Done.

5:19 pm

Dara Navaei

The typo has been fixed in DEN-13834.

The typo has been fixed in DEN-13834.

5:17 pm

Dara Navaei

This function will be modified in DEN-13834.

This function will be modified in DEN-13834.

5:17 pm

Dara Navaei

Done.

Done.

11:27 am

Sean Nash

Remove comment at end of line.

Remove comment at end of line.

11:26 am

Sean Nash

Indent here looks smaller than others. Should be 4 spaces.

Indent here looks smaller than others. Should be 4 spaces.

11:25 am

Sean Nash

Initialize these in init function below (like other variables).

Initialize these in init function below (like other variables).

11:25 am

Sean Nash

Align these with first 2 #defines.

Align these with first 2 #defines.

11:05 am

Sean Nash

Move this to after execHeaters() and before #endif.

Move this to after execHeaters() and before #endif.

11:01 am

Sean Nash

Remove comment at end of line.

Remove comment at end of line.

10:58 am

Sean Nash

Please restore to normal return value and remove comments.

Please restore to normal return value and remove comments.

10:57 am

Sean Nash

Remove blank line.

Remove blank line.

10:56 am

Sean Nash

Remove this extra blank line.

Remove this extra blank line.

10:55 am

Sean Nash

Not sure why this code is here - comment says remove so please remove these 2 lines of code.

Not sure why this code is here - comment says remove so please remove these 2 lines of code.

10:46 am

Sean Nash

I think idea here is that we don't want any process to hold onto semaphore for very long so it can't block other processes for too long. If another process is calling this function to try to access...

I think idea here is that we don't want any process to hold onto semaphore for very long so it can't block other processes for too long. If another process is calling this function to try to access the protected resource, it will check for timeout and alarm if semaphore has been held for too long.

10:33 am

Sean Nash

Need a default and s/w fault for this switch statement.

Need a default and s/w fault for this switch statement.

10:13 am

Sean Nash

Keep this blank line.

Keep this blank line.

9:13 am

Sean Nash

Should default trigger a s/w fault?

Should default trigger a s/w fault?