TemperatureSensors.c

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

Corrected

Corrected

Corrected

Corrected

Corrected

Corrected

Does TODO need to be resolved?

Does TODO need to be resolved?

Extra space before the last paren.

Extra space before the last paren.

Missing space.

Missing space.

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

I think VPi is closed during standby mode, so not sure why we want to check inlet conductivity in this mode. I imagine new system would get installed by service - would need some kind of priming do...

I think VPi is closed during standby mode, so not sure why we want to check inlet conductivity in this mode.
I imagine new system would get installed by service - would need some kind of priming done in service mode, so I'm not worried about that.

will these alarms trigger with open air? Ex: if a user has a device shipped to them, will they be greeted with conductivity alarms on first power up before any water has ran through the system? If...

will these alarms trigger with open air?

Ex: if a user has a device shipped to them, will they be greeted with conductivity alarms on first power up before any water has ran through the system? If so, how will they be able to fix it?

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

I don't see it, but resolving anyway. RESOLVED in CODE WALKTHROUGH.

I don't see it, but resolving anyway.
RESOLVED in CODE WALKTHROUGH.

Spaces inside (). And explicit condition (i.e. ( TRUE == isConvNotValid ).

Spaces inside (). And explicit condition (i.e. ( TRUE == isConvNotValid ).

Corrected

Corrected

Can we rename variable to reflect it is a timer counter at least?

Can we rename variable to reflect it is a timer counter at least?

The variable that define is being compared to is valveStateMismatchCounter which is why I called it such.

The variable that define is being compared to is valveStateMismatchCounter which is why I called it such.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Yes, and #define has "COUNT" in its name which was my point.

Yes, and #define has "COUNT" in its name which was my point.

Corrected

Corrected

Alarm is based on a counter. The #define corresponds to a 100ms time.

Alarm is based on a counter. The #define corresponds to a 100ms time.

Corrected

Corrected

Added DEBUG WARNING

Added DEBUG WARNING