Activity dgfirmware/firmware/App/Controllers

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	16
Last Commit:	19 Nov
Commits this week:	0

Lines of code count not available

Commit Activity

last updated a few minutes ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Thursday 29 Apr 2021

11:39 am

Quang Nguyen <qnguyen@diality.com>

More
7017f6b
changed 2 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 209 more DG-DEN-7802-1

DEN-7802: Removed alarm data type and unused variable

- -1
- +0
./DrainPump.c
- History
- Source
- Diff
./DrainPump.c
… 1 more file in changeset.

11:00 am

qnguyen (deleted user)

More
Re: DG-DEN-7802-1
replied to Sean Nash

Fixed.

Fixed.

10:59 am

qnguyen (deleted user)

More
Re: DG-DEN-7802-1
replied to Sean Nash

Done.

Done.

10:59 am

qnguyen (deleted user)

More
Re: DG-DEN-7802-1
replied to Sean Nash

Fixed. Compared to target temperature set by HD.

Fixed. Compared to target temperature set by HD.

10:59 am

Quang Nguyen <qnguyen@diality.com>

More
da3fb95
changed 3 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 209 more DG-DEN-7802-1

DEN-7802: Addressed code reviews

- -0
- +13
./Heaters.c
- History
- Source
- Diff
./Heaters.c
- -0
- +2
./Heaters.h
- History
- Source
- Diff
./Heaters.h
… 1 more file in changeset.

10:31 am

pmontazemi (deleted user)

More
Re: DG-DEN-7802-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:43 am

Sean Nash

More
Re: DG-DEN-7802-1
commented on review

Generally, when writing conditions involving a BOOL, try to form condition to use TRUE or FALSE depending on whichever will favor the safer path (e.g. if a bug or stack/array overflow corrupted the...

Generally, when writing conditions involving a BOOL, try to form condition to use TRUE or FALSE depending on whichever will favor the safer path (e.g. if a bug or stack/array overflow corrupted the BOOL to a value like 0x12345678, this condition would still pass).
So in this condition, we are deciding whether dialysate can be delivered to the reservoir. We would like to err on the side of not delivering to the reservoir (safer state). So we should form the condition in a way that conductivity and temperature ranges being good must be TRUE (1) in order to deliver dialysate to the reservoir. Any other value would result in coming out of dialysate delivery state which is the safer thing to do.

9:30 am

Sean Nash

More
Re: DG-DEN-7802-1
commented on review

Add blank line between declarations and code.

Add blank line between declarations and code.

9:04 am

Sean Nash

More
Re: DG-DEN-7802-1
commented on review

Replace "good" with "in range". Is this function checking temp range for alarm or for acceptable for dialysate to go to reservoir? If latter, shouldn't the range be target +/- 2°C?

Replace "good" with "in range". Is this function checking temp range for alarm or for acceptable for dialysate to go to reservoir? If latter, shouldn't the range be target +/- 2°C?

Wednesday 28 Apr 2021

8:17 pm

qnguyen (deleted user)

More
Re: DG-DEN-7802-1
replied to pmontazemi (deleted user)

Fixed.

Fixed.

5:08 pm

Dara Navaei

More
60fc5c7
changed 4 files
develop_1-24

Merged DEN-8030 chemical disinfect

- -4
- +12
./Heaters.c
- History
- Source
- Diff
./Heaters.c
- -14
- +39
./TemperatureSensors.c
- History
- Source
- Diff
./TemperatureSensors.c
… 2 more files in changeset.

4:09 pm

Dara Navaei

More
c48569a
changed 9 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 213 more DG-DEN-8030-1

DEN-8030 debugged and fixed UV reactors driver

- -11
- +11
./UVReactors.c
- History
- Source
- Diff
./UVReactors.c
… 8 more files in changeset.

11:20 am

Quang Nguyen <qnguyen@diality.com>

More
c76b192
changed 1 file
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 209 more DG-DEN-7802-1

DEN-7802: Addressed code review

- -2
- +2
./ConcentratePumps.c
- History
- Source
- Diff
./ConcentratePumps.c

10:47 am

pmontazemi (deleted user)

More
Re: DG-DEN-7802-1
commented on review

The if should be < and the else if should be >= otherwise there is double-dipping in case the value equals.

The if should be < and the else if should be >= otherwise there is double-dipping in case the value equals.

Tuesday 27 Apr 2021

10:01 am

Dara Navaei

More
DG-DEN-7568-1
Closed

Monday 26 Apr 2021

11:05 am

qnguyen (deleted user)

More
DG-DEN-7802-1
started review

DG-DEN-7802_DG-DEV Dialysate Generation

DG-DEN-7802_DG-DEV Dialysate Generation

10:33 am

Sean Nash

More
Re: DG-DEN-7568-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:32 am

qnguyen (deleted user)

More
Re: DG-DEN-7568-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:17 am

Dara Navaei

More
34ed52c
changed 4 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 215 more DG-DEN-7568-1 DG-DEN-7605-1

DEN-7568 addressed code review comments

- -5
- +12
./Heaters.c
- History
- Source
- Diff
./Heaters.c
- -14
- +39
./TemperatureSensors.c
- History
- Source
- Diff
./TemperatureSensors.c
- -24
- +24
./TemperatureSensors.h
- History
- Source
- Diff
./TemperatureSensors.h
… 1 more file in changeset.

10:16 am

Dara Navaei

More
Re: DG-DEN-7568-1
replied to qnguyen (deleted user)

Done.

Done.

Sunday 25 Apr 2021

10:36 pm

qnguyen (deleted user)

More
Re: DG-DEN-7568-1
commented on review

This struct needs doxygen comment on individual member.

This struct needs doxygen comment on individual member.

9:00 am

Dara Navaei

More
1a7b3fd
changed 3 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 215 more DG-DEN-7568-1 DG-DEN-7605-1

DEN-7568 added more states to flush mode

- -1
- +1
./ROPump.c
- History
- Source
- Diff
./ROPump.c
… 2 more files in changeset.

Saturday 24 Apr 2021

11:04 am

Dara Navaei

More
Re: DG-DEN-7568-1
replied to Sean Nash

Moved this function to the FaultMode.c.

Moved this function to the FaultMode.c.

11:04 am

Dara Navaei

More
d792668
changed 6 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 215 more DG-DEN-7568-1 DG-DEN-7605-1

DEN-7568 added more states to DG flush mode

- -0
- +1
./Heaters.c
- History
- Source
- Diff
./Heaters.c
… 5 more files in changeset.

Friday 23 Apr 2021

3:59 pm

Quang Nguyen <qnguyen@diality.com>

More
25a1a0d
changed 2 files
develop_1-24

Merge branch 'DEN-7802-dg_dev-dialysate-generation' into develop

- -3
- +3
./Heaters.c
- History
- Source
- Diff
./Heaters.c
- -1
- +2
./TemperatureSensors.c
- History
- Source
- Diff
./TemperatureSensors.c

3:53 pm

Quang Nguyen <qnguyen@diality.com>

More
79970a6
changed 1 file
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 209 more DG-DEN-7802-1

DEN-7802: Fixed heater running during off state

- -3
- +3
./Heaters.c
- History
- Source
- Diff
./Heaters.c

10:36 am

qnguyen (deleted user)

More
Re: DG-DEN-7568-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:35 am

qnguyen (deleted user)

More
Re: DG-DEN-7568-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:35 am

qnguyen (deleted user)

More
Re: DG-DEN-7568-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:34 am

qnguyen (deleted user)

More
Re: DG-DEN-7568-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2025-12-27 11:25 -0800