Controllers

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-8030 tested modes and continued developing chemical disinfect

  1. … 13 more files in changeset.
DG-DEN-8030_DG-HD DEV Mode Chemical Disinfect
DG-DEN-8030_DG-HD DEV Mode Chemical Disinfect
Good point. The module has been moved to fwcommon.

Good point. The module has been moved to fwcommon.

Removed the wrapper function. For now, only support one type of 32-bit CRC algorithm.

Removed the wrapper function. For now, only support one type of 32-bit CRC algorithm.

DEN-8103: Moved integrity module to fwcommon

  1. … 4 more files in changeset.
Done.

Done.

Noe said they updated the ID and this is the new ID for DG FPGA. The FPGA test will fail without this change.

Noe said they updated the ID and this is the new ID for DG FPGA.
The FPGA test will fail without this change.

Should mention somewhere that timer is counting ms.

Should mention somewhere that timer is counting ms.

Why did this change?

Why did this change?

Is there a reason why this module isn't in fwcommon? And if it can't be common for some reason, should this module (or group name) be named DGIntegrity?

Is there a reason why this module isn't in fwcommon? And if it can't be common for some reason, should this module (or group name) be named DGIntegrity?

Do we need to support more than one 32-bit CRC algorithm in firmware? If not, do we need this wrapper function?

Do we need to support more than one 32-bit CRC algorithm in firmware? If not, do we need this wrapper function?

Done.

Done.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Fixed.

Fixed.

Yes. Fixed.

Yes. Fixed.

Consider re-word to something more general. This function might be used by ModeHeatDisinfect to tare on an active reservoir.

Consider re-word to something more general. This function might be used by ModeHeatDisinfect to tare on an active reservoir.

Should this be in interval count?

Should this be in interval count?

DEN-7802: Updated temperature sensor alarms

DEN-7802: Added persistence to concentrate pumps check

  1. … 1 more file in changeset.
Fixed merge conflicts.

  1. … 6 more files in changeset.
DEN-7605: Fixed merge conflicts.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

DEN-7605: Addressed code review feedback.

Fixed.

Fixed.

Fixed.

Fixed.

Fixed merge conflicts.

  1. … 5 more files in changeset.