Controllers

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Please remove dead code.

Please remove dead code.

Should this be F64 as well?

Should this be F64 as well?

Remove dead code.

Remove dead code.

Yes, please remove. HD should set the target temp. I assume this was for dialysate heating tests.

Yes, please remove. HD should set the target temp. I assume this was for dialysate heating tests.

Not quite what I had in mind. I meant that, regardless of whether sharing a connector, you would always "get" the new heat disinfect temperature. Inside TempSensors, you would have the build switch...

Not quite what I had in mind.
I meant that, regardless of whether sharing a connector, you would always "get" the new heat disinfect temperature.
Inside TempSensors, you would have the build switch. If using TRO connector for new sensor, fill THd from TRo temp sensor and fill TRo from TDi temp sensor (both TDi and TRo share TDi sensor). If THd has its own connector (DVT system?), then fill THd from THd sensor and TRo from TRo sensor as you would normally expect.

Done

Done

Done.

Done.

Done.

Done.

This was for testing. It is uncommented.

This was for testing. It is uncommented.

Done.

Done.

I removed it.

I removed it.

Done

Done

I removed the function.

I removed the function.

Done.

Done.

Done.

Done.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

I think we should not stop RO pump or heater. Just go to drain like production state (but no mixing).

I think we should not stop RO pump or heater. Just go to drain like production state (but no mixing).

Call checkDialysateConductivity() once at top of function. Then use return value for the two if conditions. Also, this second if should be an else if to ensure you don't do both.

Call checkDialysateConductivity() once at top of function. Then use return value for the two if conditions.
Also, this second if should be an else if to ensure you don't do both.

Change order of comparison.

Change order of comparison.

Blank line after declaration.

Blank line after declaration.

I think we should add the new THd temperature sensor now. I know it's currently using TRo connection (and so we don't have a TRo), but we should handle that with build switch (THd reads from TRo ch...

I think we should add the new THd temperature sensor now. I know it's currently using TRo connection (and so we don't have a TRo), but we should handle that with build switch (THd reads from TRo channel and TRo can just be a copy of TDi for now if THD_USING_TRO_CONNECTOR build switch enabled, actual future code where both sensors exist on their own connectors if build switch is disabled).