dgfirmware / firmware / App

Controllers

Clone Tools

Stats

Commits this week: 0
Total Committers: 16
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 12 Jul 2023
10:47 am

Dara Navaei

DEN-15660 addressed the code review comments

Options
    • -5
    • +5
    ./TemperatureSensors.c
  2. … 5 more files in changeset.
9:58 am

Dara Navaei

Nelson is not part of the commercial code.

Nelson is not part of the commercial code.

9:57 am

Dara Navaei

Done

Done

9:08 am

Dara Navaei

Done

Done

9:06 am

Dara Navaei

Done

Done

8:53 am

Dara Navaei

Nelson support is only in debug mode.

Nelson support is only in debug mode.

8:51 am

Dara Navaei

Done

Done

8:49 am

Dara Navaei

Done

Done

8:47 am

Dara Navaei

The un-averaged TDi and TRo are used for dialysate temperature checking and trimmer heater control I think we should keep them to be able to have a full picture if needed unless the CAN bus is real...

The un-averaged TDi and TRo are used for dialysate temperature checking and trimmer heater control I think we should keep them to be able to have a full picture if needed unless the CAN bus is really flooded.

8:44 am

Dara Navaei

This is a time and not timeout.

This is a time and not timeout.

8:42 am

Dara Navaei

Done

Done

8:41 am

Dara Navaei

Done

Done

8:39 am

Dara Navaei

Done

Done

8:39 am

Dara Navaei

Done

Done

8:21 am

jtaylor  (deleted user)

Tuesday 11 Jul 2023
5:42 pm

wbracken  (deleted user)

Correct indentation

Correct indentation

5:42 pm

wbracken  (deleted user)

Correct indentation

Correct indentation

5:41 pm

wbracken  (deleted user)

Indentation needs to be corrected.

Indentation needs to be corrected.

5:30 pm

wbracken  (deleted user)

handleEmptyBottleFlag is only an input

handleEmptyBottleFlag is only an input

4:03 pm

Dara Navaei

DG-DEN-15702_Alarm 150 Inlet Water Conductivity High Does Not Disappear ON Standby Screen When
DG-DEN-15702_Alarm 150 Inlet Water Conductivity High Does Not Disappear ON Standby Screen When
3:37 pm

Darren Cox <darren_m@cox.net>

DEN-15702 Check VPI Open for Inlet Conductivity, Pressure, temperature. If VPI Closed, clear alarms.

Options
    • -8
    • +17
    ./ConductivitySensors.c
    • -8
    • +17
    ./Pressures.c
    • -10
    • +24
    ./TemperatureSensors.c
  4. … 1 more file in changeset.
12:28 pm

Sean Nash

9:08 am

Sean Nash

What about acid?

What about acid?

9:06 am

Sean Nash

This looks strange. If we have a empty bottle alarm, shouldn't we just not start a fill in the first place? With this approach, you're just stuck in fill start state until user clears the alarm.

This looks strange. If we have a empty bottle alarm, shouldn't we just not start a fill in the first place?
With this approach, you're just stuck in fill start state until user clears the alarm.

8:52 am

Dara Navaei

DEN-15660, DEN-15781, added code to not check the dialysate temperature sensorswhen the dialysate flow is zero. DEN-15808, Added code to process the empty jug alarm

Options
    • -6
    • +10
    ./TemperatureSensors.c
  2. … 2 more files in changeset.
Monday 10 Jul 2023
5:56 pm

Sean Nash

Can we move these declarations up to top of scope?

Can we move these declarations up to top of scope?

5:37 pm

Sean Nash

Replace "TIMEOUT" with "TIME"

Replace "TIMEOUT" with "TIME"

5:37 pm

Sean Nash

Is this really a timeout? Or is it a minimum duration?

Is this really a timeout? Or is it a minimum duration?

5:34 pm

Sean Nash

Do we still want un-averaged TDi and TRo in this broadcast? Is anybody using them? If not, why not replace the old temps with the new averages?

Do we still want un-averaged TDi and TRo in this broadcast? Is anybody using them? If not, why not replace the old temps with the new averages?

5:23 pm

Sean Nash

Swap first and TRo positions in enum. TRo should be first, then we add a first to mark it as first.

Swap first and TRo positions in enum. TRo should be first, then we add a first to mark it as first.