dgfirmware / firmware / App / Modes

ModeFill.c

Clone Tools

Stats

Commits this week: 0
Total Committers: 11
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 31 Mar 2022
1:55 pm

Dara Navaei

DEN-11928 merged staging

Options
    • -1
    • +1
    ./ModeFill.c
  2. … 15 more files in changeset.
1:35 pm

Dara Navaei

DEN-12224 addressed the code review comments

Options
    • -10
    • +11
    ./ModeFill.c
1:24 pm

Sean Nash

RESOLVED in WALKTHROUGH.

RESOLVED in WALKTHROUGH.

1:24 pm

Sean Nash

RESOLVED in WALKTHROUGH.

RESOLVED in WALKTHROUGH.

1:23 pm

Sean Nash

RESOLVED in WALKTHROUGH.

RESOLVED in WALKTHROUGH.

1:23 pm

Sean Nash

RESOLVED in WALKTHROUGH.

RESOLVED in WALKTHROUGH.

1:22 pm

Sean Nash

RESOLVED in WALKTHROUGH.

RESOLVED in WALKTHROUGH.

1:21 pm

Sean Nash

RESOLVED in WALKTHROUGH.

RESOLVED in WALKTHROUGH.

1:21 pm

Sean Nash

RESOLVED in WALKTHROUGH.

RESOLVED in WALKTHROUGH.

1:20 pm

Sean Nash

RESOLVED in WALKTHROUGH.

RESOLVED in WALKTHROUGH.

1:20 pm

Sean Nash

RESOLVED in WALKTHROUGH.

RESOLVED in WALKTHROUGH.

1:18 pm

Sean Nash

RESOLVED in WALKTHROUGH.

RESOLVED in WALKTHROUGH.

12:46 pm

Dara Navaei

It is zeroed in transition function and it is not used until the acid state.

It is zeroed in transition function and it is not used until the acid state.

9:09 am

Dara Navaei

DEN-11928 addressed the code review comments

Options
    • -2
    • +27
    ./ModeFill.c
  2. … 3 more files in changeset.
Wednesday 30 Mar 2022
9:38 pm

Dara Navaei

Done.

Done.

9:33 pm

Dara Navaei

It is initialized in the init function and it is staggered.

It is initialized in the init function and it is staggered.

8:55 pm

Dara Navaei

DEN-11928 updated the fill mode and the RO pump

Options
    • -8
    • +3
    ./ModeFill.c
  2. … 3 more files in changeset.
7:41 pm

Hung Nguyen <hnguyen@diality.com>

DEN-11928 Corrected logic errors

Options
    • -2
    • +2
    ./ModeFill.c
4:31 pm

Dara Navaei

DEN-11928 updated the alarms and fill mode

Options
    • -37
    • +16
    ./ModeFill.c
  2. … 8 more files in changeset.
3:26 pm

hnguyen  (deleted user)

Initialized hdLostCommStartTime_ms in void initGenIdleMode( void )

Initialized hdLostCommStartTime_ms
in void initGenIdleMode( void )

2:18 pm

Hung Nguyen <hnguyen@diality.com>

DEN-11928 Updated per peer review

Options
    • -2
    • +6
    ./ModeFill.c
  2. … 1 more file in changeset.
2:06 pm

hnguyen  (deleted user)

Changed TxLog field from TRUE to FALSE

Changed TxLog field from TRUE to FALSE

2:00 pm

hnguyen  (deleted user)

Moved publishBadFillSubstates(); to the end of execGenIdle function

Moved publishBadFillSubstates(); to the end of execGenIdle function

1:54 pm

hnguyen  (deleted user)

Added test separator below /************************************************************************* *TEST SUPPORT FUNCTIONS *********************************************************************...

Added test separator below
/*************************************************************************

  • TEST SUPPORT FUNCTIONS
    *************************************************************************/
1:46 pm

hnguyen  (deleted user)

deleted blank line

deleted blank line

1:44 pm

hnguyen  (deleted user)

Aligned this comment with other comments ///< Used to schedule dialysate fill data publication to CAN bus.

Aligned this comment with other comments
///< Used to schedule dialysate fill data publication to CAN bus.

1:36 pm

Sean Nash

Clear alarm condition, not alarm.

Clear alarm condition, not alarm.

1:34 pm

Sean Nash

Do we still need this?

Do we still need this?

1:29 pm

Sean Nash

Remove blank line.

Remove blank line.

1:13 pm

Sean Nash

Doesn't next state need acid zeroed here?

Doesn't next state need acid zeroed here?